aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* [feature/auth-refactor] A possible fix for the functional test failuresJoseph Warner2013-07-011-1/+1
| | | | | | | I don't like this fix as it really shouldn't be needed. But it makes the functional tests pass. PHPBB3-9734
* [feature/auth-refactor] Forgot @inheritdoc on methodsJoseph Warner2013-06-283-0/+54
| | | | PHPBB3-9734
* [feature/auth-refactor] Finish and clean up documentationJoseph Warner2013-06-274-74/+43
| | | | PHPBB3-9734
* [feature/auth-refactor] Change phpEx to php_ext in new classesJoseph Warner2013-06-262-9/+9
| | | | PHPBB3-9734
* [feature/auth-refactor] Fix two session tests broken by changesJoseph Warner2013-06-262-0/+26
| | | | PHPBB3-9734
* [feature/auth-refactor] Removed no longer used variableJoseph Warner2013-06-261-1/+0
| | | | PHPBB3-9734
* [feature/auth-refactor] Fix errors in acp_boardJoseph Warner2013-06-251-2/+2
| | | | | | Fixes errors introduced by the last several commits. PHPBB3-9734
* [feature/auth-refactor] Fix indentation on acp_boardJoseph Warner2013-06-251-41/+38
| | | | PHPBB3-9734
* [feature/auth-refactor] Refactor auth in acp_boardJoseph Warner2013-06-251-22/+3
| | | | | | | | Changes the acp_board code to directly call the auth providers out of the $auth_providers variable that is populated by the phpbb_container. PHPBB3-9734
* [feature/auth-refactor] Don't truncate name then reattach same thingJoseph Warner2013-06-251-4/+4
| | | | PHPBB3-9734
* [feature/auth-refactor] Remove old auth pluginsJoseph Warner2013-06-253-886/+0
| | | | PHPBB3-9734
* [feature/auth-refactor] Remove references to old auth pluginsJoseph Warner2013-06-251-29/+9
| | | | | | | Removes what is hopefully the last references to the old auth plugins in the code base. PHPBB3-9734
* [feature/auth-refactor] Fix auth tests to use mock objects correctlyJoseph Warner2013-06-251-25/+123
| | | | PHPBB3-9734
* [feature/auth-refactor] Test validate_session on provider_apacheJoseph Warner2013-06-251-1/+5
| | | | | | | Provides a test for the validate_session() method of provider_apache. PHPBB3-9734
* [feature/auth-refactor] Test autologin() on provider_apacheJoseph Warner2013-06-251-0/+28
| | | | | | | Provides a test for the autologin() method of provider_apache that assumes the user already exists in the database. PHPBB3-9734
* [feature/auth-refactor] Test login() for provider_apacheJoseph Warner2013-06-251-1/+20
| | | | | | | | Provides a test for the login() method for provider_apache. Appears to be failing due to an issue with the mock phpBB request class. PHPBB3-9734
* [feature/auth-refactor] Test for init on provider_apacheJoseph Warner2013-06-251-4/+12
| | | | | | | Provides a test for the init() method of provider_apache. Appears to be failing due to an error with the mock request class. PHPBB3-9734
* [feature/auth-refactor] Skeleton of provider_apache_testJoseph Warner2013-06-251-0/+49
| | | | | | Creates a skeleton of the tests for provider_apache. PHPBB3-9734
* [feature/auth-refactor] Finish provider_db unit test for loginJoseph Warner2013-06-251-2/+12
| | | | | | | Finishes the provider_db unit test for login. The test currently passes. PHPBB3-9734
* [feature/auth-refactor] Initial auth unit test provider_dbJoseph Warner2013-06-242-0/+73
| | | | | | | Initial work on a unit test for the provider_db login function. Does not work currently. PHPBB3-9734
* [feature/auth-refactor] Refactor code to use servicesJoseph Warner2013-06-213-40/+24
| | | | | | | Refactors all loading of auth providers to use services instead of directly calling the class. PHPBB3-9734
* [feature/auth-refactor] Create an auth.provider_collector serviceJoseph Warner2013-06-201-0/+12
| | | | | | Creates an auth.provider_collector service for all auth providers. PHPBB3-9734
* [feature/auth-refactor] Convert provider_apache to a serviceJoseph Warner2013-06-202-41/+55
| | | | | | Removes globals from provider_apache and turns it into a service. PHPBB3-9734
* [feature/auth-refactor] Convert provider_ldap to a serviceJoseph Warner2013-06-202-59/+67
| | | | | | Removes globals from provider_ldap and converts it into a service. PHPBB3-9734
* [feature/auth-refactor] Turn provider_db into a serviceJoseph Warner2013-06-202-41/+74
| | | | | | Removes globals from provider_db and turns it into a service. PHPBB3-9734
* [feature/auth-refactor] Start turning auth providers into servicesJoseph Warner2013-06-202-0/+2
| | | | | | | Creates auth_provider.yml and includes auth_providers.yml in services.yml. PHPBB3-9734
* [feature/auth-refactor] Fix LDAP conversion errorJoseph Warner2013-06-201-3/+3
| | | | | | | | | I messed up when converting over auth_ldap this commit fixes that error. I have not been able to extensively test ldap due to not having ldap set up on this computer yet. Apache authentication appears to work. PHPBB3-9734
* [feature/auth-refactor] Finish refactoring auth pluginsJoseph Warner2013-06-195-10/+55
| | | | | | | | | | I believe that this commit should have final minimal changes needed to replace the old auth plugins with the refactored auth plugins. Added a few more elements to the interface based on the old auth plugins. Documentation is not complete and need works on these new elements. PHPBB3-9734
* [feature/auth-refactor] Refactor session for new auth interfaceJoseph Warner2013-06-191-4/+4
| | | | | | Refactors phpbb_session to use the new auth interface. PHPBB3-9734
* [feature/auth-refactor] Refactor acp_board for new auth interfaceJoseph Warner2013-06-195-23/+22
| | | | | | | | | | Partially refactors acp_board for the new authentication interface. Leaves some questionable if statements in the file. Modifies the interface to correctly impletment the acp() method. Modifies each provider to comply with the above mentioned interface modification. PHPBB3-9734
* [feature/auth-refactor] Fix typos causing changes to not workJoseph Warner2013-06-195-6/+5
| | | | | | | | Replaces short tags with long tags. Fixes the interface to be an interface and not class in the file. Removes unnecessary include_once from auth.php. PHPBB-9734
* [feature/auth-refactor] Refactor login to use new interfaceJoseph Warner2013-06-181-3/+4
| | | | | | Refactors auth.php to use the provider_interface during login. PHPBB-9734
* [feature/auth-refactor] Make DB auth consistent with interfaceJoseph Warner2013-06-181-13/+9
| | | | | | | | | Makes provider_db consistent with provider_interface. Removes $ip, $browser, and $forwarded_for from the arguments of phpbb_auth_provider_db::login() as these are provided by the global variable $user. PHPBB3-9734
* [feature/auth-refactor] Make LDAP consistent with interfaceJoseph Warner2013-06-181-5/+8
| | | | | | | | | | Makes the provider_ldap consistent with the provider_interface except for the acp() method which has not yet been finalized. Renames phpbb_auth_provider_ldap::user_filter to phpbb_auth_provider_ldap::ldap_user_filter to maintain the original name of the function from auth_ldap. PHPBB3-9734
* [feature/auth-refactor] Make Apache consistent with interfaceJoseph Warner2013-06-181-1/+1
| | | | | | | Makes the provider_apache consistent with the provider_interface by removing the pass-by-reference of $username and $password. PHPBB3-9734
* [feature/auth-refactor] Fix comment block indentationJoseph Warner2013-06-183-58/+58
| | | | | | | Comment block indentation was off by one space on the provider_* files due to being incorrectly copied over from the auth_* files. PHPBB3-9734
* [feature/auth-refactor] Document the provider interfaceJoseph Warner2013-06-181-1/+31
| | | | | | | | | | Provides basic documentation of the auth_provideR_interface. Changes the login method to login($username, $password) for consistency with the providers. acp() is not fully documented. It appears that it is meant to return an array of some sort and take in a variable by reference. PHPBB3-9734
* [feature/auth-refactor] LDAP Auth Provider SkeletonJoseph Warner2013-06-171-0/+358
| | | | | | | Creates a ldap auth provider using code taken verbatim from auth_ldap.php. PHPBB3-9734
* [feature/auth-refactor] Database Auth Provider SkeletonJoseph Warner2013-06-171-0/+309
| | | | | | | | Creates a skeleton of the database auth provider from auth_db.php. The functions are copied verbatim complete with globals and any existing errors. PHPBB3-9734
* [feature/auth-refactor] Auth Apache Provider SkeletonJoseph Warner2013-06-171-0/+265
| | | | | | | | | Creates a skeleton for Apache based authentication using the phpbb_auth_provider_interface named phpbb_auth_provider_apache. This brings over all code in auth_apache.php verbatim complete with all global variables currently in use. PHPBB3-9734
* [feature/auth-refactor] Provider Interface SkeletonJoseph Warner2013-06-171-0/+32
| | | | | | Creates a skeleton of the authentication provider interface. PHPBB3-9734
* Merge branch 'develop-olympus' into developJoas Schilling2013-06-130-0/+0
|\ | | | | | | * develop-olympus:
| * Merge remote-tracking branch 'remotes/dhruvgoel92/ticket/10820' into ↵Joas Schilling2013-06-131-9/+30
| |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | develop-olympus * remotes/dhruvgoel92/ticket/10820: [ticket/10820] fix if condition to check for IE [ticket/10820] Add additional check for IE in condition [ticket/10820] Fix function docblock [ticket/10820] Inject IE version in function [ticket/10820] fix regex Extract IE version from user agent string and then compare it with 7 [ticket/10820] remove unnecessary parentheses [ticket/10820] fix docblock [ticket/10820] add param and return to function [ticket/10820] simplify regex and escape dot [ticket/10820] Use singular return [ticket/10820] remove unnecessary condition checks [ticket/10820] add function docblock [ticket/10820] fix IE check function [ticket/10820] proper usage of global and local variable browser [ticket/10820] Image downloader recognize new version of ie When a user download image attachement using ie8, the file is displayed. However, when he uses ie version greater than 8, the image is download. A changes are made to phpbb/download/file.php to solve the problem. We check now if the ie version is greater or equal to 8 and not only equal to 8
* | \ Merge remote-tracking branch 'remotes/dhruvgoel92/ticket/10820-develop' into ↵Joas Schilling2013-06-133-7/+158
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | develop * remotes/dhruvgoel92/ticket/10820-develop: (34 commits) [ticket/10820] fix if condition to check for IE [ticket/10820] Add additional check for IE in condition [ticket/10820] Fix function docblock [ticket/10820] Inject IE version in function [ticket/10820] fix regex Extract IE version from user agent string and then compare it with 7 [ticket/10820] remove unnecessary parentheses [ticket/10820] fix docblock [ticket/10820] add param and return to function [ticket/10820] simplify regex and escape dot [ticket/10820] Use singular return [ticket/10820] remove unnecessary condition checks [ticket/10820] add function docblock [ticket/10820] fix IE check function [ticket/10820] proper usage of global and local variable browser [ticket/10820] Image downloader recognize new version of ie When a user download image attachement using ie8, the file is displayed. However, when he uses ie version greater than 8, the image is download. A changes are made to phpbb/download/file.php to solve the problem. We check now if the ie version is greater or equal to 8 and not only equal to 8 [ticket/10820] Fix function docblock [ticket/10820] Add test cases More test cases to check against different versions [ticket/10820] Rename function [ticket/10820] Fix copyright [ticket/10820] Change function call in tests ...
| * \ \ Merge branch 'ticket/10820' into ticket/10820-developDhruv2013-06-141-1/+1
| |\ \ \ | | | |/ | | |/| | | | | | | | | | | | | | | | | | | | | * ticket/10820: [ticket/10820] fix if condition to check for IE Conflicts: phpBB/download/file.php
| | * | [ticket/10820] fix if condition to check for IEDhruv2013-06-141-1/+1
| | | | | | | | | | | | | | | | PHPBB3-10820
| * | | Merge branch 'ticket/10820' into ticket/10820-developDhruv2013-06-132-2/+2
| |\ \ \ | | |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | # By Dhruv (13) and riadhchtara (1) * ticket/10820: [ticket/10820] Add additional check for IE in condition [ticket/10820] Fix function docblock [ticket/10820] Inject IE version in function [ticket/10820] fix regex Extract IE version from user agent string and then compare it with 7 [ticket/10820] remove unnecessary parentheses [ticket/10820] fix docblock [ticket/10820] add param and return to function [ticket/10820] simplify regex and escape dot [ticket/10820] Use singular return [ticket/10820] remove unnecessary condition checks [ticket/10820] add function docblock [ticket/10820] fix IE check function [ticket/10820] proper usage of global and local variable browser [ticket/10820] Image downloader recognize new version of ie When a user download image attachement using ie8, the file is displayed. However, when he uses ie version greater than 8, the image is download. A changes are made to phpbb/download/file.php to solve the problem. We check now if the ie version is greater or equal to 8 and not only equal to 8 Conflicts: phpBB/download/file.php
| | * | [ticket/10820] Add additional check for IE in conditionDhruv2013-06-131-2/+2
| | | | | | | | | | | | | | | | PHPBB3-10820
| | * | [ticket/10820] Fix function docblockDhruv2013-06-121-1/+1
| | | | | | | | | | | | | | | | PHPBB3-10820
| | * | [ticket/10820] Inject IE version in functionDhruv2013-06-121-8/+9
| | | | | | | | | | | | | | | | PHPBB3-10820
generated by cgit v1.2.1 (git 2.21.0) at 2026-04-21 17:33:59 +0000