diff options
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/dbal/fixtures/migrator_module.xml | 39 | ||||
| -rw-r--r-- | tests/dbal/migrator_tool_module_test.php | 120 | ||||
| -rw-r--r-- | tests/di/create_container_test.php | 2 | ||||
| -rw-r--r-- | tests/functional/search/base.php | 24 | ||||
| -rw-r--r-- | tests/text_formatter/s9e/default_formatting_test.php | 2 | ||||
| -rw-r--r-- | tests/text_processing/tickets_data/PHPBB3-14846.html | 1 | ||||
| -rw-r--r-- | tests/text_processing/tickets_data/PHPBB3-14846.txt | 1 | ||||
| -rw-r--r-- | tests/text_processing/tickets_data/PHPBB3-14846.xml | 28 | 
8 files changed, 195 insertions, 22 deletions
diff --git a/tests/dbal/fixtures/migrator_module.xml b/tests/dbal/fixtures/migrator_module.xml index e172d7a145..e85c43ee25 100644 --- a/tests/dbal/fixtures/migrator_module.xml +++ b/tests/dbal/fixtures/migrator_module.xml @@ -90,5 +90,44 @@  			<value></value>  			<value></value>  		</row> +		<row> +			<value>7</value> +			<value>1</value> +			<value>1</value> +			<value></value> +			<value>ucp</value> +			<value>0</value> +			<value>13</value> +			<value>18</value> +			<value>UCP_MAIN_CAT</value> +			<value></value> +			<value></value> +		</row> +		<row> +			<value>8</value> +			<value>1</value> +			<value>1</value> +			<value>ucp_subcat</value> +			<value>ucp</value> +			<value>7</value> +			<value>14</value> +			<value>17</value> +			<value>UCP_SUBCATEGORY</value> +			<value>ucp_test</value> +			<value></value> +		</row> +		<row> +			<value>9</value> +			<value>1</value> +			<value>1</value> +			<value>ucp_module</value> +			<value>ucp</value> +			<value>8</value> +			<value>15</value> +			<value>16</value> +			<value>UCP_MODULE</value> +			<value>ucp_module_test</value> +			<value></value> +		</row>  	</table>  </dataset> diff --git a/tests/dbal/migrator_tool_module_test.php b/tests/dbal/migrator_tool_module_test.php index 1744b7e92d..29b21166b6 100644 --- a/tests/dbal/migrator_tool_module_test.php +++ b/tests/dbal/migrator_tool_module_test.php @@ -45,10 +45,10 @@ class phpbb_dbal_migrator_tool_module_test extends phpbb_database_test_case  		$this->tool = new \phpbb\db\migration\tool\module($this->db, $this->cache, $this->user, $module_manager, $phpbb_root_path, $phpEx, 'phpbb_modules');  	} -	public function exists_data() +	public function exists_data_acp()  	{  		return array( -			// Test the category +			// Test the existing category  			array(  				'',  				'ACP_CAT', @@ -60,7 +60,7 @@ class phpbb_dbal_migrator_tool_module_test extends phpbb_database_test_case  				true,  			), -			// Test the module +			// Test the existing module  			array(  				'',  				'ACP_MODULE', @@ -76,17 +76,88 @@ class phpbb_dbal_migrator_tool_module_test extends phpbb_database_test_case  				'ACP_MODULE',  				true,  			), + +			// Test for non-existant modules +			array( +				'', +				'ACP_NON_EXISTANT_CAT', +				false, +			), +			array( +				'ACP_CAT', +				'ACP_NON_EXISTANT_MODULE', +				false, +			),  		);  	}  	/** -	* @dataProvider exists_data +	* @dataProvider exists_data_acp  	*/ -	public function test_exists($parent, $module, $expected) +	public function test_exists_acp($parent, $module, $expected)  	{  		$this->assertEquals($expected, $this->tool->exists('acp', $parent, $module));  	} +	public function exists_data_ucp() +	{ +		return array( +			// Test the existing category +			array( +				'', +				'UCP_MAIN_CAT', +				true, +			), +			array( +				0, +				'UCP_MAIN_CAT', +				true, +			), + +			// Test the existing module +			array( +				'', +				'UCP_SUBCATEGORY', +				false, +			), +			array( +				false, +				'UCP_SUBCATEGORY', +				true, +			), +			array( +				'UCP_MAIN_CAT', +				'UCP_SUBCATEGORY', +				true, +			), +			array( +				'UCP_SUBCATEGORY', +				'UCP_MODULE', +				true, +			), + +			// Test for non-existant modules +			array( +				'', +				'UCP_NON_EXISTANT_CAT', +				false, +			), +			array( +				'UCP_MAIN_CAT', +				'UCP_NON_EXISTANT_MODULE', +				false, +			), +		); +	} + +	/** +	* @dataProvider exists_data_ucp +	*/ +	public function test_exists_ucp($parent, $module, $expected) +	{ +		$this->assertEquals($expected, $this->tool->exists('ucp', $parent, $module)); +	} +  	public function test_add()  	{  		try @@ -159,6 +230,45 @@ class phpbb_dbal_migrator_tool_module_test extends phpbb_database_test_case  			$this->fail($e);  		}  		$this->assertEquals(true, $this->tool->exists('acp', 'ACP_FORUM_BASED_PERMISSIONS', 'ACP_NEW_PERMISSIONS_MODULE')); + +		// Test adding UCP modules +		// Test adding new UCP category +		try +		{ +			$this->tool->add('ucp', 0, 'UCP_NEW_CAT'); +		} +		catch (Exception $e) +		{ +			$this->fail($e); +		} +		$this->assertEquals(true, $this->tool->exists('ucp', 0, 'UCP_NEW_CAT')); + +		// Test adding new UCP subcategory +		try +		{ +			$this->tool->add('ucp', 'UCP_NEW_CAT', 'UCP_NEW_SUBCAT'); +		} +		catch (Exception $e) +		{ +			$this->fail($e); +		} +		$this->assertEquals(true, $this->tool->exists('ucp', 'UCP_NEW_CAT', 'UCP_NEW_SUBCAT')); + +		// Test adding new UCP module +		try +		{ +			$this->tool->add('ucp', 'UCP_NEW_SUBCAT', array( +				'module_basename'	=> 'ucp_new_module', +				'module_langname'	=> 'UCP_NEW_MODULE', +				'module_mode'		=> 'ucp_test', +				'module_auth'		=> '', +			)); +		} +		catch (Exception $e) +		{ +			$this->fail($e); +		} +		$this->assertEquals(true, $this->tool->exists('ucp', 'UCP_NEW_SUBCAT', 'UCP_NEW_MODULE'));  	}  	public function test_remove() diff --git a/tests/di/create_container_test.php b/tests/di/create_container_test.php index 4dd0583ebe..aba7a3560b 100644 --- a/tests/di/create_container_test.php +++ b/tests/di/create_container_test.php @@ -73,8 +73,6 @@ namespace  			// Checks the construction of a dumped container  			$container = $this->builder->get_container();  			$this->assertInstanceOf('phpbb_cache_container', $container); -			$this->assertFalse($container->isFrozen()); -			$container->getParameterBag(); // needed, otherwise the container is not marked as frozen  			$this->assertTrue($container->isFrozen());  		} diff --git a/tests/functional/search/base.php b/tests/functional/search/base.php index fc6f4c0a0b..48c444fb76 100644 --- a/tests/functional/search/base.php +++ b/tests/functional/search/base.php @@ -79,18 +79,16 @@ abstract class phpbb_functional_search_base extends phpbb_functional_test_case  	{  		$this->add_lang('acp/search');  		$crawler = self::request('GET', 'adm/index.php?i=acp_search&mode=index&sid=' . $this->sid); -		$form_values = $crawler->selectButton('Create index')->form()->getValues(); -		$crawler = self::request( -			'POST', -			'adm/index.php?i=acp_search&mode=index&sid=' . $this->sid, +		$form = $crawler->selectButton('Create index')->form(); +		$form_values = $form->getValues(); +		$form_values = array_merge($form_values,  			array(  				'search_type'	=> ( ($backend === null) ? $this->search_backend : $backend ),  				'action'		=> 'create', -				'submit'		=> true, -				'form_token'	=> $form_values['form_token'], -				'creation_time'	=> $form_values['creation_time'],  			)  		); +		$form->setValues($form_values); +		$crawler = self::submit($form);  		$this->assertContainsLang('SEARCH_INDEX_CREATED', $crawler->text());  	} @@ -98,18 +96,16 @@ abstract class phpbb_functional_search_base extends phpbb_functional_test_case  	{  		$this->add_lang('acp/search');  		$crawler = self::request('GET', 'adm/index.php?i=acp_search&mode=index&sid=' . $this->sid); -		$form_values = $crawler->selectButton('Delete index')->form()->getValues(); -		$crawler = self::request( -			'POST', -			'adm/index.php?i=acp_search&mode=index&sid=' . $this->sid, +		$form = $crawler->selectButton('Delete index')->form(); +		$form_values = $form->getValues(); +		$form_values = array_merge($form_values,  			array(  				'search_type'	=> $this->search_backend,  				'action'		=> 'delete', -				'submit'		=> true, -				'form_token'	=> $form_values['form_token'], -				'creation_time'	=> $form_values['creation_time'],  			)  		); +		$form->setValues($form_values); +		$crawler = self::submit($form);  		$this->assertContainsLang('SEARCH_INDEX_REMOVED', $crawler->text());  	}  } diff --git a/tests/text_formatter/s9e/default_formatting_test.php b/tests/text_formatter/s9e/default_formatting_test.php index a70528aba3..e25c3246b5 100644 --- a/tests/text_formatter/s9e/default_formatting_test.php +++ b/tests/text_formatter/s9e/default_formatting_test.php @@ -298,7 +298,7 @@ class phpbb_textformatter_s9e_default_formatting_test extends phpbb_test_case  			),  			array(  				"Emoji: \xF0\x9F\x98\x80", -				'Emoji: <img alt="' . "\xF0\x9F\x98\x80" . '" class="smilies" draggable="false" width="18" height="18" src="//twemoji.maxcdn.com/svg/1f600.svg">' +				'Emoji: <img alt="' . "\xF0\x9F\x98\x80" . '" class="smilies" draggable="false" width="18" height="18" src="//cdn.jsdelivr.net/emojione/assets/svg/1f600.svg">'  			),  			array(  				"Emoji: \xF0\x9F\x98\x80", diff --git a/tests/text_processing/tickets_data/PHPBB3-14846.html b/tests/text_processing/tickets_data/PHPBB3-14846.html new file mode 100644 index 0000000000..461ca25bc6 --- /dev/null +++ b/tests/text_processing/tickets_data/PHPBB3-14846.html @@ -0,0 +1 @@ +<div style="padding: .2em .5em; font-size: .8em; width: 200px; background: #FFD;">moderator text<div style="font-weight: bold; text-align: right">- Mickroz</div></div>
\ No newline at end of file diff --git a/tests/text_processing/tickets_data/PHPBB3-14846.txt b/tests/text_processing/tickets_data/PHPBB3-14846.txt new file mode 100644 index 0000000000..ded7b3f1fe --- /dev/null +++ b/tests/text_processing/tickets_data/PHPBB3-14846.txt @@ -0,0 +1 @@ +[mod=Mickroz]moderator text[/mod]
\ No newline at end of file diff --git a/tests/text_processing/tickets_data/PHPBB3-14846.xml b/tests/text_processing/tickets_data/PHPBB3-14846.xml new file mode 100644 index 0000000000..94b094f0e3 --- /dev/null +++ b/tests/text_processing/tickets_data/PHPBB3-14846.xml @@ -0,0 +1,28 @@ +<?xml version="1.0" encoding="UTF-8" ?> +<dataset> +	<table name="phpbb_bbcodes"> +		<column>bbcode_id</column> +		<column>bbcode_tag</column> +		<column>bbcode_helpline</column> +		<column>display_on_posting</column> +		<column>bbcode_match</column> +		<column>bbcode_tpl</column> +		<column>first_pass_match</column> +		<column>first_pass_replace</column> +		<column>second_pass_match</column> +		<column>second_pass_replace</column> + +		<row> +			<value>13</value> +			<value>mod=</value> +			<value></value> +			<value>1</value> +			<value>[mod={TEXT1}]{TEXT2}[/mod]</value> +			<value><![CDATA[<div style="padding: .2em .5em; font-size: .8em; width: 200px; background: #FFD;">{TEXT2}<div style="font-weight: bold; text-align: right">- {TEXT1}</div></div>]]></value> +			<value><\[/mod\]!ies]]></value> +			<value><![CDATA['[mod='.str_replace(array("\r\n", '\"', '\'', '(', ')'), array("\n", '"', ''', '(', ')'), trim('${1}')).':$uid]'.str_replace(array("\r\n", '\"', '\'', '(', ')'), array("\n", '"', ''', '(', ')'), trim('${2}')).'[/mod:$uid]']]></value> +			<value><\[/mod:$uid\]!s]]></value> +			<value><![CDATA[<div style="padding: .2em .5em; font-size: .8em; width: 200px; background: #FFD;">${2}<div style="font-weight: bold; text-align: right">- ${1}</div></div>]]></value> +		</row> +	</table> +</dataset>  | 
