6 files changed, 88 insertions, 9 deletions
diff --git a/phpBB/phpbb/di/extension/config.php b/phpBB/phpbb/di/extension/config.php
index 403c9d50e7..a7d7284f85 100644
--- a/phpBB/phpbb/di/extension/config.php
+++ b/phpBB/phpbb/di/extension/config.php
@@ -15,8 +15,6 @@ namespace phpbb\di\extension;
 
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\HttpKernel\DependencyInjection\Extension;
-use Symfony\Component\DependencyInjection\Loader\XmlFileLoader;
-use Symfony\Component\Config\FileLocator;
 
 /**
 * Container config extension
@@ -34,7 +32,7 @@ class config extends Extension
 	* @param array            $config    An array of configuration values
 	* @param ContainerBuilder $container A ContainerBuilder instance
 	*
-	* @throws InvalidArgumentException When provided tag is not defined in this extension
+	* @throws \InvalidArgumentException When provided tag is not defined in this extension
 	*/
 	public function load(array $config, ContainerBuilder $container)
 	{
@@ -68,7 +66,7 @@ class config extends Extension
 	* Convert 3.0 ACM type to 3.1 cache driver class name
 	*
 	* @param string $acm_type ACM type
-	* @return cache driver class
+	* @return string cache driver class
 	*/
 	protected function convert_30_acm_type($acm_type)
 	{
diff --git a/phpBB/phpbb/di/extension/core.php b/phpBB/phpbb/di/extension/core.php
index 72026f3b54..ca4fa5c082 100644
--- a/phpBB/phpbb/di/extension/core.php
+++ b/phpBB/phpbb/di/extension/core.php
@@ -45,7 +45,7 @@ class core extends Extension
 	* @param array            $config    An array of configuration values
 	* @param ContainerBuilder $container A ContainerBuilder instance
 	*
-	* @throws InvalidArgumentException When provided tag is not defined in this extension
+	* @throws \InvalidArgumentException When provided tag is not defined in this extension
 	*/
 	public function load(array $config, ContainerBuilder $container)
 	{
diff --git a/phpBB/phpbb/di/extension/ext.php b/phpBB/phpbb/di/extension/ext.php
index 1205dffb53..718c992d2e 100644
--- a/phpBB/phpbb/di/extension/ext.php
+++ b/phpBB/phpbb/di/extension/ext.php
@@ -39,7 +39,7 @@ class ext extends Extension
 	* @param array            $config    An array of configuration values
 	* @param ContainerBuilder $container A ContainerBuilder instance
 	*
-	* @throws InvalidArgumentException When provided tag is not defined in this extension
+	* @throws \InvalidArgumentException When provided tag is not defined in this extension
 	*/
 	public function load(array $config, ContainerBuilder $container)
 	{
diff --git a/phpBB/phpbb/di/pass/kernel_pass.php b/phpBB/phpbb/di/pass/kernel_pass.php
index 44d4fcd07f..c154c7532d 100644
--- a/phpBB/phpbb/di/pass/kernel_pass.php
+++ b/phpBB/phpbb/di/pass/kernel_pass.php
@@ -23,6 +23,7 @@ class kernel_pass implements CompilerPassInterface
 	*
 	* @param ContainerBuilder $container ContainerBuilder object
 	* @return null
+	* @throws \InvalidArgumentException
 	*/
 	public function process(ContainerBuilder $container)
 	{
diff --git a/phpBB/phpbb/di/service_collection.php b/phpBB/phpbb/di/service_collection.php
index 3a18644891..82ca9bf679 100644
--- a/phpBB/phpbb/di/service_collection.php
+++ b/phpBB/phpbb/di/service_collection.php
@@ -21,6 +21,11 @@ use Symfony\Component\DependencyInjection\ContainerInterface;
 class service_collection extends \ArrayObject
 {
 	/**
+	* @var \Symfony\Component\DependencyInjection\ContainerInterface
+	*/
+	protected $container;
+
+	/**
 	* Constructor
 	*
 	* @param ContainerInterface $container Container object
@@ -31,6 +36,37 @@ class service_collection extends \ArrayObject
 	}
 
 	/**
+	* {@inheritdoc}
+	*/
+	public function getIterator()
+	{
+		return new service_collection_iterator($this);
+	}
+
+	// Because of a PHP issue we have to redefine offsetExists
+	// (even with a call to the parent):
+	// 		https://bugs.php.net/bug.php?id=66834
+	// 		https://bugs.php.net/bug.php?id=67067
+	// But it triggers a sniffer issue that we have to skip
+	// @codingStandardsIgnoreStart
+	/**
+	* {@inheritdoc}
+	*/
+	public function offsetExists($index)
+	{
+		return parent::offsetExists($index);
+	}
+	// @codingStandardsIgnoreEnd
+
+	/**
+	* {@inheritdoc}
+	*/
+	public function offsetGet($index)
+	{
+		return $this->container->get($index);
+	}
+
+	/**
 	* Add a service to the collection
 	*
 	* @param string $name The service name
@@ -38,8 +74,6 @@ class service_collection extends \ArrayObject
 	*/
 	public function add($name)
 	{
-		$task = $this->container->get($name);
-
-		$this->offsetSet($name, $task);
+		$this->offsetSet($name, null);
 	}
 }
diff --git a/phpBB/phpbb/di/service_collection_iterator.php b/phpBB/phpbb/di/service_collection_iterator.php
new file mode 100644
index 0000000000..0d031ab52d
--- /dev/null
+++ b/phpBB/phpbb/di/service_collection_iterator.php
@@ -0,0 +1,46 @@
+<?php
+/**
+*
+* This file is part of the phpBB Forum Software package.
+*
+* @copyright (c) phpBB Limited <https://www.phpbb.com>
+* @license GNU General Public License, version 2 (GPL-2.0)
+*
+* For full copyright and license information, please see
+* the docs/CREDITS.txt file.
+*
+*/
+
+namespace phpbb\di;
+
+/**
+* Iterator which loads the services when they are requested
+*/
+class service_collection_iterator extends \ArrayIterator
+{
+	/**
+	* @var \phpbb\di\service_collection
+	*/
+	protected $collection;
+
+	/**
+	* Construct an ArrayIterator for service_collection
+	*
+	* @param \phpbb\di\service_collection $collection The collection to iterate over
+	* @param int $flags Flags to control the behaviour of the ArrayObject object.
+	* @see ArrayObject::setFlags()
+	*/
+	public function __construct(service_collection $collection, $flags = 0)
+	{
+		parent::__construct($collection, $flags);
+		$this->collection = $collection;
+	}
+
+	/**
+	* {@inheritdoc}
+	*/
+	public function current()
+	{
+		return $this->collection->offsetGet($this->key());
+	}
+}