aboutsummaryrefslogtreecommitdiffstats
path: root/phpBB/includes/acp/acp_icons.php
diff options
context:
space:
mode:
Diffstat (limited to 'phpBB/includes/acp/acp_icons.php')
-rw-r--r--phpBB/includes/acp/acp_icons.php13
1 files changed, 8 insertions, 5 deletions
diff --git a/phpBB/includes/acp/acp_icons.php b/phpBB/includes/acp/acp_icons.php
index 23bd86ea3b..b74e5f8b4f 100644
--- a/phpBB/includes/acp/acp_icons.php
+++ b/phpBB/includes/acp/acp_icons.php
@@ -97,6 +97,8 @@ class acp_icons
unset($_images);
$_images = array();
+ // no break;
+
case 'add':
$order_list = '';
@@ -269,9 +271,10 @@ class acp_icons
{
$update = true;
- $result = $db->sql_query("SELECT {$fields}_order
+ $sql = "SELECT {$fields}_order
FROM $table
- WHERE {$fields}_id = " . $image_id[$image]);
+ WHERE {$fields}_id = " . $image_id[$image];
+ $result = $db->sql_query($sql);
$order_old = (int) $db->sql_fetchfield($fields . '_order');
$db->sql_freeresult($result);
@@ -403,8 +406,9 @@ class acp_icons
));
}
- $db->sql_query("UPDATE $table SET " . $db->sql_build_array('UPDATE', $sql) . "
- WHERE $field_sql = '" . $db->sql_escape($replace_sql) . "'");
+ $sql = "UPDATE $table SET " . $db->sql_build_array('UPDATE', $sql) . "
+ WHERE $field_sql = '" . $db->sql_escape($replace_sql) . "'";
+ $db->sql_query($sql);
}
else
{
@@ -638,7 +642,6 @@ class acp_icons
}
}
$db->sql_freeresult($result);
-
}
}