+ $phpbb_filesystem = new phpbb_filesystem($phpbb_root_path);

+$phpbb_filesystem = $phpbb_container->get('filesystem');

+ - @config

+ arguments:

+ - %core.root_path%

+ 'enable_mod_rewrite' => array('lang' => 'MOD_REWRITE_ENABLE', 'validate' => 'bool', 'type' => 'custom', 'method' => 'enable_mod_rewrite', 'explain' => true),

+ /**

+ * Option to enable/disable removal of 'app.php' from URLs

+ *

+ * Note that if mod_rewrite is on, URLs without app.php will still work,

+ * but any paths generated by the controller helper url() method will not

+ * contain app.php.

+ *

+ * @param int $value The current config value

+ * @param string $key The config key

+ * @return string The HTML for the form field

+ */

+ function enable_mod_rewrite($value, $key)

+ {

+ global $user, $config;

+

+ // Determine whether mod_rewrite is enabled on the server

+ // NOTE: This only works on Apache servers on which PHP is NOT

+ // installed as CGI. In that case, there is no way for PHP to

+ // determine whether or not the Apache module is enabled.

+ //

+ // To be clear on the value of $mod_rewite:

+ // null = Cannot determine whether or not the server has mod_rewrite

+ // enabled

+ // false = Can determine that the server does NOT have mod_rewrite

+ // enabled

+ // true = Can determine that the server DOES have mod_rewrite_enabled

+ $mod_rewrite = null;

+ if (function_exists('apache_get_modules'))

+ {

+ $mod_rewrite = (bool) in_array('mod_rewrite', apache_get_modules());

+ }

+

+ // If $message is false, mod_rewrite is enabled.

+ // Otherwise, it is not and we need to:

+ // 1) disable the form field

+ // 2) make sure the config value is set to 0

+ // 3) append the message to the return

+ $value = ($mod_rewrite === false) ? 0 : $value;

+ $message = $mod_rewrite === null ? 'MOD_REWRITE_INFORMATION_UNAVAILABLE' : ($mod_rewrite === false ? 'MOD_REWRITE_DISABLED' : false);

+

+ // Let's do some friendly HTML injection if we want to disable the

+ // form field because h_radio() has no pretty way of doing so

+ $field_name = 'config[enable_mod_rewrite]' . ($message === 'MOD_REWRITE_DISABLED' ? '" disabled="disabled' : '');

+

+ return h_radio($field_name, array(1 => 'YES', 0 => 'NO'), $value) .

+ ($message !== false ? '<br /><span>' . $user->lang($message) . '</span>' : '');

+ }

+ global $_SID, $_EXTRA_URL, $phpbb_hook, $phpbb_filesystem;

+ global $symfony_request, $phpbb_root_path, $phpbb_container;

+ // Update the root path with the correct relative web path

+ if ($phpbb_filesystem instanceof phpbb_filesystem)

+ $url = $phpbb_filesystem->update_web_root_path($url, $symfony_request);

+ $page = $user->page['page'];

+

+ // We need to be cautious here.

+ // On some situations, the redirect path is an absolute URL, sometimes a relative path

+ // For a relative path, let's prefix it with $phpbb_root_path to point to the correct location,

+ // else we use the URL directly.

+ $url_parts = @parse_url($page);

+

+ // URL

+ if ($url_parts !== false && !empty($url_parts['scheme']) && !empty($url_parts['host']))

+ {

+ $page = $phpbb_root_path . $page;

+ }

+

+ $redirect = append_sid($page, false, false);

+ return str_replace('&', '&amp;', $redirect);

+ global $phpbb_dispatcher, $request, $phpbb_container, $symfony_request, $adm_relative_path;

+ $phpbb_filesystem = $phpbb_container->get('filesystem');

+ $corrected_path = $phpbb_filesystem->get_web_root_path($symfony_request);

+ 'S_LOGIN_ACTION' => ((!defined('ADMIN_START')) ? append_sid("{$phpbb_root_path}ucp.$phpEx", 'mode=login') : append_sid("{$phpbb_root_path}{$adm_relative_path}index.$phpEx", false, true, $user->session_id)),

+ $symfony_request = new Symfony\Component\HttpFoundation\Request($get_parameters, $post_parameters, array(), $cookie_parameters, $files_parameters, $server_parameters);

+INSERT INTO phpbb_config (config_name, config_value) VALUES ('enable_mod_rewrite', '0');

+ 'MOD_REWRITE_ENABLE' => 'Enable URL Rewriting',

+ 'MOD_REWRITE_ENABLE_EXPLAIN' => 'When enabled, URLs containing ’app.php’ will be rewritten to remove the filename (i.e. app.php/foo will become /foo). <strong>Apache server’s mod_rewrite module is required for this functionality to work; if this option is enabled without mod_rewrite support, URLs on your board may be broken.</strong>',

+ 'MOD_REWRITE_DISABLED' => 'The <strong>mod_rewrite</strong> module on your Apache web server is disabled. Enable the module or contact your web hosting provider if you wish to enable this feature.',

+ 'MOD_REWRITE_INFORMATION_UNAVAILABLE' => 'We are unable to determine whether or not this server supports URL rewriting. This setting may be enabled but if URL rewriting is not available, paths generated by this board (such as for use in links) may be broken. Contact your web hosting provider if you are unsure whether or not you can safely enable this feature.',

+ * config object

+ * @var phpbb_config

+ protected $config;

+ public function __construct(phpbb_template $template, phpbb_user $user, phpbb_config $config, $phpbb_root_path, $php_ext)

+ $this->config = $config;

+ // If enable_mod_rewrite is false, we not need to include app.php

+ if (empty($this->config['enable_mod_rewrite']))

+ {

+ $route_prefix .= 'app.' . $this->php_ext . '/';

+ }

+<?php

+/**

+*

+* @package migration

+* @copyright (c) 2013 phpBB Group

+* @license http://opensource.org/licenses/gpl-license.php GNU Public License v2

+*

+*/

+

+class phpbb_db_migration_data_310_mod_rewrite extends phpbb_db_migration

+{

+ static public function depends_on()

+ {

+ return array(

+ 'phpbb_db_migration_data_310_dev',

+ );

+ }

+

+ public function update_data()

+ {

+ return array(

+ array('config.add', array('enable_mod_rewrite', '0')),

+ );

+ }

+}

+

+use Symfony\Component\HttpFoundation\Request;

+

+ /** @var string */

+ protected $phpbb_root_path;

+

+ /** @var string */

+ protected $web_root_path;

+

+ /**

+ * Constructor

+ *

+ * @param string $phpbb_root_path

+ */

+ public function __construct($phpbb_root_path)

+ {

+ $this->phpbb_root_path = $phpbb_root_path;

+ }

+

+ /**

+ * Get the phpBB root path

+ *

+ * @return string

+ */

+ public function get_phpbb_root_path()

+ {

+ return $this->phpbb_root_path;

+ }

+

+ /**

+ * Update a path to the correct relative root path

+ *

+ * This replaces $phpbb_root_path . some_url with

+ * get_web_root_path() . some_url OR if $phpbb_root_path

+ * is not at the beginning of $path, just prepends the

+ * web root path

+ *

+ * @param Request $symfony_request Symfony Request object

+ * @return string

+ */

+ public function update_web_root_path($path, Request $symfony_request = null)

+ {

+ $web_root_path = $this->get_web_root_path($symfony_request);

+

+ if (strpos($path, $this->phpbb_root_path) === 0)

+ {

+ $path = substr($path, strlen($this->phpbb_root_path));

+ }

+

+ return $web_root_path . $path;

+ }

+

+ /**

+ * Get a relative root path from the current URL

+ *

+ * @param Request $symfony_request Symfony Request object

+ * @return string

+ */

+ public function get_web_root_path(Request $symfony_request = null)

+ {

+ if ($symfony_request === null)

+ {

+ return $this->phpbb_root_path;

+ }

+

+ if (null !== $this->web_root_path)

+ {

+ return $this->web_root_path;

+ }

+

+ // Path info (e.g. /foo/bar)

+ $path_info = $this->clean_path($symfony_request->getPathInfo());

+

+ // Full request URI (e.g. phpBB/app.php/foo/bar)

+ $request_uri = $symfony_request->getRequestUri();

+

+ // Script name URI (e.g. phpBB/app.php)

+ $script_name = $symfony_request->getScriptName();

+

+ /*

+ * If the path info is empty (single /), then we're not using

+ * a route like app.php/foo/bar

+ */

+ if ($path_info === '/')

+ {

+ return $this->web_root_path = $this->phpbb_root_path;

+ }

+

+ // How many corrections might we need?

+ $corrections = substr_count($path_info, '/');

+

+ /*

+ * If the script name (e.g. phpBB/app.php) exists in the

+ * requestUri (e.g. phpBB/app.php/foo/template), then we

+ * are have a non-rewritten URL.

+ */

+ if (strpos($request_uri, $script_name) === 0)

+ {

+ /*

+ * Append ../ to the end of the phpbb_root_path as many times

+ * as / exists in path_info

+ */

+ return $this->web_root_path = $this->phpbb_root_path . str_repeat('../', $corrections);

+ }

+

+ /*

+ * If we're here it means we're at a re-written path, so we must

+ * correct the relative path for web URLs. We must append ../

+ * to the end of the root path as many times as / exists in path_info

+ * less one time (because the script, e.g. /app.php, doesn't exist in

+ * the URL)

+ */

+ return $this->web_root_path = $this->phpbb_root_path . str_repeat('../', $corrections - 1);

+ }

+

+ public function helper_url_data_no_rewrite()

+ {

+ return array(

+ array('foo/bar?t=1&amp;f=2', false, true, false, 'app.php/foo/bar?t=1&amp;f=2', 'parameters in url-argument'),

+ array('foo/bar', 't=1&amp;f=2', true, false, 'app.php/foo/bar?t=1&amp;f=2', 'parameters in params-argument using amp'),

+ array('foo/bar', 't=1&f=2', false, false, 'app.php/foo/bar?t=1&f=2', 'parameters in params-argument using &'),

+ array('foo/bar', array('t' => 1, 'f' => 2), true, false, 'app.php/foo/bar?t=1&amp;f=2', 'parameters in params-argument as array'),

+

+ // Custom sid parameter

+ array('foo/bar', 't=1&amp;f=2', true, 'custom-sid', 'app.php/foo/bar?t=1&amp;f=2&amp;sid=custom-sid', 'using session_id'),

+

+ // Testing anchors

+ array('foo/bar?t=1&amp;f=2#anchor', false, true, false, 'app.php/foo/bar?t=1&amp;f=2#anchor', 'anchor in url-argument'),

+ array('foo/bar', 't=1&amp;f=2#anchor', true, false, 'app.php/foo/bar?t=1&amp;f=2#anchor', 'anchor in params-argument'),

+ array('foo/bar', array('t' => 1, 'f' => 2, '#' => 'anchor'), true, false, 'app.php/foo/bar?t=1&amp;f=2#anchor', 'anchor in params-argument (array)'),

+

+ // Anchors and custom sid

+ array('foo/bar?t=1&amp;f=2#anchor', false, true, 'custom-sid', 'app.php/foo/bar?t=1&amp;f=2&amp;sid=custom-sid#anchor', 'anchor in url-argument using session_id'),

+ array('foo/bar', 't=1&amp;f=2#anchor', true, 'custom-sid', 'app.php/foo/bar?t=1&amp;f=2&amp;sid=custom-sid#anchor', 'anchor in params-argument using session_id'),

+ array('foo/bar', array('t' => 1, 'f' => 2, '#' => 'anchor'), true, 'custom-sid', 'app.php/foo/bar?t=1&amp;f=2&amp;sid=custom-sid#anchor', 'anchor in params-argument (array) using session_id'),

+

+ // Empty parameters should not append the &amp;

+ array('foo/bar', false, true, false, 'app.php/foo/bar', 'no params using bool false'),

+ array('foo/bar', '', true, false, 'app.php/foo/bar', 'no params using empty string'),

+ array('foo/bar', array(), true, false, 'app.php/foo/bar', 'no params using empty array'),

+ );

+ }

+

+ /**

+ * @dataProvider helper_url_data_no_rewrite()

+ */

+ public function test_helper_url_no_rewrite($route, $params, $is_amp, $session_id, $expected, $description)

+ {

+ global $phpbb_dispatcher, $phpbb_root_path, $phpEx;

+

+ $phpbb_dispatcher = new phpbb_mock_event_dispatcher;

+ $this->user = $this->getMock('phpbb_user');

+ $this->template = new phpbb_template_twig($phpbb_root_path, $phpEx, $config, $this->user, new phpbb_template_context());

+

+ // We don't use mod_rewrite in these tests

+ $config = new phpbb_config(array('enable_mod_rewrite' => '0'));

+ $helper = new phpbb_controller_helper($this->template, $this->user, $config, '', 'php');

+ $this->assertEquals($helper->url($route, $params, $is_amp, $session_id), $expected);

+ }

+

+ public function helper_url_data_with_rewrite()

+ * @dataProvider helper_url_data_with_rewrite()

+ public function test_helper_url_with_rewrite($route, $params, $is_amp, $session_id, $expected, $description)

+ $config = new phpbb_config(array('enable_mod_rewrite' => '1'));

+ $helper = new phpbb_controller_helper($this->template, $this->user, $config, '', 'php');

+ new phpbb_filesystem(dirname(__FILE__) . '/../../phpBB/'),

+ new phpbb_filesystem($phpbb_root_path),

+ new phpbb_filesystem($this->phpbb_root_path),

+ $this->filesystem = new phpbb_filesystem(__DIR__ . './../../phpBB/');

+<?php

+/**

+*

+* @package testing

+* @copyright (c) 2013 phpBB Group

+* @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2

+*

+*/

+

+class phpbb_filesystem_web_root_path_test extends phpbb_test_case

+{

+ protected $filesystem;

+ protected $phpbb_root_path = '';

+

+ public function setUp()

+ {

+ parent::setUp();

+

+ $this->set_phpbb_root_path();

+

+ $this->filesystem = new phpbb_filesystem($this->phpbb_root_path);

+ }

+

+ /**

+ * Set the phpbb_root_path

+ *

+ * This is necessary because dataProvider functions are called

+ * before setUp or setUpBeforeClass; so we must set the path

+ * any time we wish to use it in one of these functions (and

+ * also in general for everything else)

+ */

+ public function set_phpbb_root_path()

+ {

+ $this->phpbb_root_path = dirname(__FILE__) . './../../phpBB/';

+ }

+

+ public function test_get_web_root_path()

+ {

+ // Symfony Request = null, so always should return phpbb_root_path

+ $this->assertEquals($this->phpbb_root_path, $this->filesystem->get_web_root_path());

+ }

+

+ public function update_web_root_path_data()

+ {

+ $this->set_phpbb_root_path();

+

+ return array(

+ array(

+ $this->phpbb_root_path . 'test.php',

+ ),

+ array(

+ 'test.php',

+ $this->phpbb_root_path . 'test.php',

+ ),

+ array(

+ $this->phpbb_root_path . $this->phpbb_root_path . 'test.php',

+ ),

+ array(

+ $this->phpbb_root_path . 'test.php',

+ $this->phpbb_root_path . 'test.php',

+ '/',

+ ),

+ array(

+ $this->phpbb_root_path . 'test.php',

+ $this->phpbb_root_path . '../test.php',

+ '//',

+ ),

+ array(

+ $this->phpbb_root_path . 'test.php',

+ $this->phpbb_root_path . '../test.php',

+ '//',

+ 'foo/bar.php',

+ 'bar.php',

+ ),

+ array(

+ $this->phpbb_root_path . 'test.php',

+ $this->phpbb_root_path . '../../test.php',

+ '/foo/template',

+ '/phpbb3-fork/phpBB/app.php/foo/template',

+ '/phpbb3-fork/phpBB/app.php',

+ ),

+ array(

+ $this->phpbb_root_path . 'test.php',

+ $this->phpbb_root_path . '../test.php',

+ '/foo/template',

+ '/phpbb3-fork/phpBB/foo/template',

+ '/phpbb3-fork/phpBB/app.php',

+ ),

+ );

+ }

+

+ /**

+ * @dataProvider update_web_root_path_data

+ */

+ public function test_update_web_root_path($input, $expected = null, $getPathInfo = null, $getRequestUri = null, $getScriptName = null)

+ {

+ $expected = ($expected === null) ? $input : $expected;

+

+ $symfony_request = null;

+ if ($getPathInfo !== null)

+ {

+ $symfony_request = $this->getMock("Symfony\Component\HttpFoundation\Request");

+ $symfony_request->expects($this->any())

+ ->method('getPathInfo')

+ ->will($this->returnValue($getPathInfo));

+ $symfony_request->expects($this->any())

+ ->method('getRequestUri')

+ ->will($this->returnValue($getRequestUri));

+ $symfony_request->expects($this->any())

+ ->method('getScriptName')

+ ->will($this->returnValue($getScriptName));

+ }

+

+ $this->assertEquals($expected, $this->filesystem->update_web_root_path($input, $symfony_request));

+ }

+}

+ global $phpEx, $phpbb_dispatcher, $phpbb_container, $phpbb_root_path;

+ $phpbb_container = new phpbb_mock_container_builder();

+ $phpbb_container->set('filesystem', new phpbb_filesystem($phpbb_root_path));

+ $this->filesystem = new phpbb_filesystem($phpbb_root_path);

+ new phpbb_filesystem($phpbb_root_path),