diff options
| -rw-r--r-- | .travis.yml | 4 | ||||
| -rw-r--r-- | build/build.xml | 12 | ||||
| -rw-r--r-- | phpBB/adm/style/acp_ext_list.html | 17 | ||||
| -rw-r--r-- | phpBB/includes/ucp/ucp_remind.php | 2 | ||||
| -rw-r--r-- | phpBB/language/en/acp/extensions.php | 19 | ||||
| -rw-r--r-- | phpBB/phpbb/profilefields/manager.php | 2 | ||||
| -rw-r--r-- | phpBB/phpbb/profilefields/type/type_date.php | 1 | ||||
| -rw-r--r-- | phpBB/phpbb/profilefields/type/type_dropdown.php | 1 | ||||
| -rw-r--r-- | phpBB/phpbb/profilefields/type/type_int.php | 2 | ||||
| -rw-r--r-- | phpBB/viewtopic.php | 2 | ||||
| -rwxr-xr-x | travis/install-php-extensions.sh | 21 | ||||
| -rwxr-xr-x | travis/setup-php-extensions.sh | 56 | 
12 files changed, 101 insertions, 38 deletions
| diff --git a/.travis.yml b/.travis.yml index 4f4705e4f7..a077ade0b3 100644 --- a/.travis.yml +++ b/.travis.yml @@ -16,8 +16,8 @@ services:  install:    - sh -c "if [ '$DB' = 'mariadb' ]; then travis/setup-mariadb.sh; fi" +  - sh -c "if [ '$TRAVIS_PHP_VERSION' != 'hhvm' ]; then travis/setup-php-extensions.sh; fi"    - sh -c "if [ `php -r "echo (int) version_compare(PHP_VERSION, '5.3.19', '>=');"` = "1" ]; then travis/setup-webserver.sh; fi" -  - travis/install-php-extensions.sh    - cd phpBB    - php ../composer.phar install --dev --no-interaction --prefer-source    - cd .. @@ -32,7 +32,7 @@ script:    - sh -c "if [ '$TRAVIS_PHP_VERSION' = '5.5' -a '$DB' = 'mysql' ]; then ../phpBB/vendor/bin/phing sniff; fi"    - cd ..    - phpBB/vendor/bin/phpunit --configuration travis/phpunit-$DB-travis.xml -  - sh -c "if [ '$TRAVIS_PULL_REQUEST' != 'false' ]; then git-tools/commit-msg-hook-range.sh $TRAVIS_COMMIT_RANGE; fi" +  - sh -c "if [ '$TRAVIS_PHP_VERSION' = '5.5' -a '$DB' = 'mysql' -a '$TRAVIS_PULL_REQUEST' != 'false' ]; then git-tools/commit-msg-hook-range.sh origin/$TRAVIS_BRANCH...FETCH_HEAD; fi"  matrix:    allow_failures: diff --git a/build/build.xml b/build/build.xml index d4ba927d96..c65c71d2dc 100644 --- a/build/build.xml +++ b/build/build.xml @@ -139,7 +139,7 @@  			<property name="dir" value="build/old_versions/release-${version}" />  		</phingcall> -		<exec dir="build/old_versions" command="diff -crNEBwd release-${version} release-${newversion} > +		<exec dir="build/old_versions" command="LC_ALL=C diff -crNEBwd release-${version} release-${newversion} >  			../new_version/patches/phpBB-${version}_to_${newversion}.patch" escape="false" />  	</target> @@ -167,20 +167,20 @@  		<exec dir="build" command="php -f package.php '${versions}' > logs/package.log" escape="false" />  		<exec dir="build" escape="false"  			command="diff -crNEBwd old_versions/release-${prevversion}/language new_version/phpBB3/language > -				save/save_${prevversion}_to_${newversion}/language/phpbb-${prevversion}_to_${newversion}_language.patch" /> +				save/phpbb-${prevversion}_to_${newversion}_language.patch" />  		<exec dir="build" escape="false"  			command="diff -crNEBwd old_versions/release-${prevversion}/styles/prosilver new_version/phpBB3/styles/prosilver > -				save/save_${prevversion}_to_${newversion}/prosilver/phpbb-${prevversion}_to_${newversion}_prosilver.patch" /> +				save/phpbb-${prevversion}_to_${newversion}_prosilver.patch" />  		<exec dir="build" escape="false"  			command="diff -crNEBwd old_versions/release-${prevversion}/styles/subsilver2 new_version/phpBB3/styles/subsilver2 > -				save/save_${prevversion}_to_${newversion}/subsilver2/phpbb-${prevversion}_to_${newversion}_subsilver2.patch" /> +				save/phpbb-${prevversion}_to_${newversion}_subsilver2.patch" />  		<exec dir="build" escape="false"  			command="git shortlog --summary --numbered release-${prevversion}...HEAD > -				save/save_${prevversion}_to_${newversion}/phpbb-${prevversion}_to_${newversion}_git_shortlog.txt" /> +				save/phpbb-${prevversion}_to_${newversion}_git_shortlog.txt" />  		<exec dir="build" escape="false"  			command="git diff --stat release-${prevversion}...HEAD > -				save/save_${prevversion}_to_${newversion}/phpbb-${prevversion}_to_${newversion}_git_diffstat.txt" /> +				save/phpbb-${prevversion}_to_${newversion}_git_diffstat.txt" />  		<phingcall target="checksum-dir">  			<property name="dir" value="build/new_version/release_files" /> diff --git a/phpBB/adm/style/acp_ext_list.html b/phpBB/adm/style/acp_ext_list.html index 8408ebe748..09cf6a31f5 100644 --- a/phpBB/adm/style/acp_ext_list.html +++ b/phpBB/adm/style/acp_ext_list.html @@ -55,5 +55,22 @@  		<!-- ENDIF -->  	</tbody>  	</table> +	<br /> + +	<table class="table1"> +	<tr> +		<th>{L_EXTENSION_UPDATE_HEADLINE}</th> +	</tr> +	<tr> +		<td class="row3">{L_EXTENSION_UPDATE_EXPLAIN}</td> +	</tr> +	<tr> +		<th>{L_EXTENSION_REMOVE_HEADLINE}</th> +	</tr> +	<tr> +		<td class="row3">{L_EXTENSION_REMOVE_EXPLAIN}</td> +	</tr> +	</tbody> +	</table>  <!-- INCLUDE overall_footer.html --> diff --git a/phpBB/includes/ucp/ucp_remind.php b/phpBB/includes/ucp/ucp_remind.php index 44395abb44..99e945eeae 100644 --- a/phpBB/includes/ucp/ucp_remind.php +++ b/phpBB/includes/ucp/ucp_remind.php @@ -27,7 +27,7 @@ class ucp_remind  	function main($id, $mode)  	{  		global $config, $phpbb_root_path, $phpEx; -		global $db, $user, $auth, $template, $phpbb_container;; +		global $db, $user, $auth, $template, $phpbb_container;  		if (!$config['allow_password_reset'])  		{ diff --git a/phpBB/language/en/acp/extensions.php b/phpBB/language/en/acp/extensions.php index 67b34ff0c7..409b800ba6 100644 --- a/phpBB/language/en/acp/extensions.php +++ b/phpBB/language/en/acp/extensions.php @@ -64,9 +64,22 @@ $lang = array_merge($lang, array(  	'EXTENSION_DISABLE_SUCCESS'		=> 'The extension was disabled successfully',  	'EXTENSION_ENABLE_SUCCESS'		=> 'The extension was enabled successfully', -	'EXTENSION_NAME'		=> 'Extension Name', -	'EXTENSION_ACTIONS'		=> 'Actions', -	'EXTENSION_OPTIONS'		=> 'Options', +	'EXTENSION_NAME'			=> 'Extension Name', +	'EXTENSION_ACTIONS'			=> 'Actions', +	'EXTENSION_OPTIONS'			=> 'Options', +	'EXTENSION_UPDATE_HEADLINE'	=> 'Updating an extension', +	'EXTENSION_UPDATE_EXPLAIN'	=> '<ol> +			<li>Disable the extension</li> +			<li>Delete the extension’s files from the filesystem</li> +			<li>Upload the new files</li> +			<li>Enable the extension</li> +		</ol>', +	'EXTENSION_REMOVE_HEADLINE'	=> 'Completly removing an extension from your board', +	'EXTENSION_REMOVE_EXPLAIN'	=> '<ol> +			<li>Disable the extension</li> +			<li>Delete the extension’s data</li> +			<li>Delete the extension’s files from the filesystem</li> +		</ol>',  	'EXTENSION_DELETE_DATA_CONFIRM'	=> 'Are you sure that you wish to delete the data associated with “%s”?<br /><br />This removes all of its data and settings and cannot be undone!',  	'EXTENSION_DISABLE_CONFIRM'		=> 'Are you sure that you wish to disable the “%s” extension?', diff --git a/phpBB/phpbb/profilefields/manager.php b/phpBB/phpbb/profilefields/manager.php index 7564c920c9..ead978374c 100644 --- a/phpBB/phpbb/profilefields/manager.php +++ b/phpBB/phpbb/profilefields/manager.php @@ -313,7 +313,7 @@ class manager  				$profile_field = $this->type_collection[$ident_ary['data']['field_type']];  				$value = $profile_field->get_profile_value($ident_ary['value'], $ident_ary['data']); -				if ($value === NULL) +				if ($value === null)  				{  					continue;  				} diff --git a/phpBB/phpbb/profilefields/type/type_date.php b/phpBB/phpbb/profilefields/type/type_date.php index 409c2e7be0..0de80f2baf 100644 --- a/phpBB/phpbb/profilefields/type/type_date.php +++ b/phpBB/phpbb/profilefields/type/type_date.php @@ -327,7 +327,6 @@ class type_date extends type_base  			return $current_value;  		} -  		return parent::get_excluded_options($key, $action, $current_value, $field_data, $step);  	} diff --git a/phpBB/phpbb/profilefields/type/type_dropdown.php b/phpBB/phpbb/profilefields/type/type_dropdown.php index 9a6545249d..b5b393d91b 100644 --- a/phpBB/phpbb/profilefields/type/type_dropdown.php +++ b/phpBB/phpbb/profilefields/type/type_dropdown.php @@ -273,7 +273,6 @@ class type_dropdown extends type_base  			return sizeof(explode("\n", $this->request->variable('lang_options', '', true)));  		} -  		return parent::get_excluded_options($key, $action, $current_value, $field_data, $step);  	} diff --git a/phpBB/phpbb/profilefields/type/type_int.php b/phpBB/phpbb/profilefields/type/type_int.php index 6ffc8fbea0..77a4f813da 100644 --- a/phpBB/phpbb/profilefields/type/type_int.php +++ b/phpBB/phpbb/profilefields/type/type_int.php @@ -87,7 +87,7 @@ class type_int extends type_base  	*/  	public function get_default_field_value($field_data)  	{ -		 if ($field_data['field_default_value'] === '') +		if ($field_data['field_default_value'] === '')  		{  			// We cannot insert an empty string into an integer column.  			return null; diff --git a/phpBB/viewtopic.php b/phpBB/viewtopic.php index 227cfdd029..fab8e3b474 100644 --- a/phpBB/viewtopic.php +++ b/phpBB/viewtopic.php @@ -1901,7 +1901,7 @@ if (!request_var('t', 0) && !empty($topic_id))  	$request->overwrite('t', $topic_id);  } -$page_title = $topic_data['topic_title'] . ($start ? ' - ' . sprintf($user->lang['PAGE_TITLE_NUMBER'], $pagination->get_on_page($config['topics_per_page'], $start)) : ''); +$page_title = $topic_data['topic_title'] . ($start ? ' - ' . sprintf($user->lang['PAGE_TITLE_NUMBER'], $pagination->get_on_page($config['posts_per_page'], $start)) : '');  /**  * You can use this event to modify the page title of the viewtopic page diff --git a/travis/install-php-extensions.sh b/travis/install-php-extensions.sh deleted file mode 100755 index 55955c2905..0000000000 --- a/travis/install-php-extensions.sh +++ /dev/null @@ -1,21 +0,0 @@ -#!/bin/bash -# -# @copyright (c) 2013 phpBB Group -# @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2 -# -set -e - -function add_ext_to_php_ini -{ -	echo "extension=$1.so" >> `php --ini | grep "Loaded Configuration" | sed -e "s|.*:\s*||"` -} - -# redis -git clone git://github.com/nicolasff/phpredis.git -cd phpredis -phpize -./configure -make -make install -cd .. -add_ext_to_php_ini 'redis' diff --git a/travis/setup-php-extensions.sh b/travis/setup-php-extensions.sh new file mode 100755 index 0000000000..ebfe62839c --- /dev/null +++ b/travis/setup-php-extensions.sh @@ -0,0 +1,56 @@ +#!/bin/bash +# +# @copyright (c) 2013 phpBB Group +# @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2 +# +set -e +set -x + +function find_php_ini +{ +	echo $(php --ini | grep "Loaded Configuration" | sed -e "s|.*:\s*||") +} + +# $1 - PHP extension name +# $2 - PHP ini file path +function register_php_extension +{ +	echo "extension=$1.so" >> "$2" +} + +# $1 - PHP extension name +# $2 - PHP ini file path +function install_php_extension +{ +	echo "Installing $1 PHP extension" + +	# See http://www.php.net/manual/en/install.pecl.phpize.php +	cd "$1" +	phpize +	./configure +	make +	make install +	cd .. + +	register_php_extension "$1" "$2" +} + +php_ini_file=$(find_php_ini) + +# disable broken opcache on PHP 5.5.7 +if [ `php -r "echo (int) version_compare(PHP_VERSION, '5.5.8', '<');"` == "1" ] +then +	sed -i '/opcache.so/d' "$php_ini_file" +fi + +# apc +if [ `php -r "echo (int) version_compare(PHP_VERSION, '5.5.0-dev', '<');"` == "1" ] +then +	echo 'Enabling APC PHP extension' +	register_php_extension 'apc' "$php_ini_file" +	echo 'apc.enable_cli=1' >> "$php_ini_file" +fi + +# redis +git clone git://github.com/nicolasff/phpredis.git redis +install_php_extension 'redis' "$php_ini_file" | 
