diff options
| author | Nils Adermann <naderman@naderman.de> | 2010-07-08 22:44:28 +0200 |
|---|---|---|
| committer | Nils Adermann <naderman@naderman.de> | 2010-07-08 22:46:28 +0200 |
| commit | bbc3105466ccd43d94423325a68c626c76dec5f9 (patch) | |
| tree | f91a856e5c26f0a4a2a8198ff9b99541e767cd10 /phpBB/includes/acm | |
| parent | 6da582e8be50fa7211706625402215f6f87ed48b (diff) | |
| download | forums-bbc3105466ccd43d94423325a68c626c76dec5f9.tar forums-bbc3105466ccd43d94423325a68c626c76dec5f9.tar.gz forums-bbc3105466ccd43d94423325a68c626c76dec5f9.tar.bz2 forums-bbc3105466ccd43d94423325a68c626c76dec5f9.tar.xz forums-bbc3105466ccd43d94423325a68c626c76dec5f9.zip | |
[ticket/9701] Prevent notices from being hidden by template tests
The template tests disable NOTICEs for the duration of template execution since
the current version of the template engine does not generate sufficiently clean
code. The error level is reset aftwards, however that part is skipped when
trigger_error is called which is converted into a regular exception by PHPUnit
and passed down until caught. Such exceptions are now caught to reset the error
level, and then the exception is rethrown.
This uncovered another issue in the template tests which only passed because
NOTICEs were unintentionally disabled at this point. assign_display is also
required to operate without NOTICEs. The respective code has been added around
its callee as well. However no handling of exceptions takes place there. If
another test checking for errors in that function is ever added similar catch
logic will have to be added there.
PHPBB3-9701
Diffstat (limited to 'phpBB/includes/acm')
0 files changed, 0 insertions, 0 deletions