diff options
| author | Tristan Darricau <github@nicofuma.fr> | 2014-06-19 20:11:49 +0200 |
|---|---|---|
| committer | Tristan Darricau <github@nicofuma.fr> | 2014-06-19 21:04:43 +0200 |
| commit | 8595b2ae86ca14c83d8a61241fadec9f72a730c3 (patch) | |
| tree | dc6858e8dcc5356887d1a32e8f5596c4ac0c940d | |
| parent | 7c5141842081e7f9031cb3063089d2d03a30a0fe (diff) | |
| download | forums-8595b2ae86ca14c83d8a61241fadec9f72a730c3.tar forums-8595b2ae86ca14c83d8a61241fadec9f72a730c3.tar.gz forums-8595b2ae86ca14c83d8a61241fadec9f72a730c3.tar.bz2 forums-8595b2ae86ca14c83d8a61241fadec9f72a730c3.tar.xz forums-8595b2ae86ca14c83d8a61241fadec9f72a730c3.zip | |
[ticket/12716] Add regression test
PHPBB3-12716
| -rw-r--r-- | tests/auth/fixtures/oauth_tokens.xml | 6 | ||||
| -rw-r--r-- | tests/auth/phpbb_not_a_token.php | 23 | ||||
| -rw-r--r-- | tests/auth/provider_oauth_token_storage_test.php | 18 |
3 files changed, 47 insertions, 0 deletions
diff --git a/tests/auth/fixtures/oauth_tokens.xml b/tests/auth/fixtures/oauth_tokens.xml index 9bfb5a4422..cffa02a39d 100644 --- a/tests/auth/fixtures/oauth_tokens.xml +++ b/tests/auth/fixtures/oauth_tokens.xml @@ -5,6 +5,12 @@ <column>session_id</column> <column>provider</column> <column>oauth_token</column> + <row> + <value>1</value> + <value>9999</value> + <value>auth.provider.oauth.service.testing</value> + <value>{"token_class":"phpbb_not_a_token","accessToken":"error","refreshToken":0,"endOfLife":null,"extraParams":null}</value> + </row> </table> </dataset> diff --git a/tests/auth/phpbb_not_a_token.php b/tests/auth/phpbb_not_a_token.php new file mode 100644 index 0000000000..61cc14fa10 --- /dev/null +++ b/tests/auth/phpbb_not_a_token.php @@ -0,0 +1,23 @@ +<?php +/** +* +* This file is part of the phpBB Forum Software package. +* +* @copyright (c) phpBB Limited <https://www.phpbb.com> +* @license GNU General Public License, version 2 (GPL-2.0) +* +* For full copyright and license information, please see +* the docs/CREDITS.txt file. +* +*/ + +class phpbb_not_a_token +{ + public function __construct($param1, $param2, $param3, $param4) + { + } + + public function setEndOfLife() + { + } +} diff --git a/tests/auth/provider_oauth_token_storage_test.php b/tests/auth/provider_oauth_token_storage_test.php index ec28e546bd..8919345087 100644 --- a/tests/auth/provider_oauth_token_storage_test.php +++ b/tests/auth/provider_oauth_token_storage_test.php @@ -13,6 +13,8 @@ use OAuth\OAuth2\Token\StdOAuth2Token; +require_once dirname(__FILE__) . '/phpbb_not_a_token.php'; + class phpbb_auth_provider_oauth_token_storage_test extends phpbb_database_test_case { protected $db; @@ -73,6 +75,22 @@ class phpbb_auth_provider_oauth_token_storage_test extends phpbb_database_test_c $this->assertEquals($token, $stored_token); } + public function test_retrieveAccessToken_wrong_token() + { + $this->user->data['session_id'] = 9999; + try + { + $this->token_storage->retrieveAccessToken($this->service_name); + $this->fail('The token can not be deserialized and an exception should be thrown.'); + } + catch (\OAuth\Common\Storage\Exception\TokenNotFoundException $e) + { + } + + $row = $this->get_token_row_by_session_id(9999); + $this->assertFalse($row); + } + public function test_retrieveAccessToken_from_db() { $expected_token = new StdOAuth2Token('access', 'refresh', StdOAuth2Token::EOL_NEVER_EXPIRES); |