diff options
author | Marc Alexander <admin@m-a-styles.de> | 2013-05-14 21:27:25 +0200 |
---|---|---|
committer | Marc Alexander <admin@m-a-styles.de> | 2013-05-14 21:27:25 +0200 |
commit | 1fae7720e43c8ff853225e16d0de54395d9ab051 (patch) | |
tree | f5061ba73c7b830e41a425750548445c7e9af6af | |
parent | a547ba3f9d569410107574a151af9a2f301bb68e (diff) | |
download | forums-1fae7720e43c8ff853225e16d0de54395d9ab051.tar forums-1fae7720e43c8ff853225e16d0de54395d9ab051.tar.gz forums-1fae7720e43c8ff853225e16d0de54395d9ab051.tar.bz2 forums-1fae7720e43c8ff853225e16d0de54395d9ab051.tar.xz forums-1fae7720e43c8ff853225e16d0de54395d9ab051.zip |
[ticket/11538] Fix incorrect regex and test for duplicate # in color string
PHPBB3-11538
-rw-r--r-- | phpBB/includes/ucp/ucp_groups.php | 2 | ||||
-rw-r--r-- | tests/functional/ucp_groups_test.php | 1 |
2 files changed, 2 insertions, 1 deletions
diff --git a/phpBB/includes/ucp/ucp_groups.php b/phpBB/includes/ucp/ucp_groups.php index 3f06e74159..8ff76eac42 100644 --- a/phpBB/includes/ucp/ucp_groups.php +++ b/phpBB/includes/ucp/ucp_groups.php @@ -597,7 +597,7 @@ class ucp_groups if (!empty($submit_ary['colour'])) { - preg_match('/^(#?)+(?:[0-9a-fA-F]{6}|[0-9a-fA-F]{3})\b/', $submit_ary['colour'], $group_colour); + preg_match('/^#?(?:[0-9a-fA-F]{6}|[0-9a-fA-F]{3})\b/', $submit_ary['colour'], $group_colour); if (sizeof($group_colour)) { diff --git a/tests/functional/ucp_groups_test.php b/tests/functional/ucp_groups_test.php index f570c6af8d..d5ac6f697e 100644 --- a/tests/functional/ucp_groups_test.php +++ b/tests/functional/ucp_groups_test.php @@ -23,6 +23,7 @@ class phpbb_functional_ucp_groups_test extends phpbb_functional_test_case array('#a00', 'GROUP_UPDATED'), array('ag0', 'COLOUR_INVALID'), array('#ag0', 'COLOUR_INVALID'), + array('##bcc', 'COLOUR_INVALID'), ); } |