forums/git-tools/hooks/pre-commit, branch master

[ticket/11630] Improvements to the PHP lint pre-commit hook

2013-07-06T17:16:59+00:00

The PHP lint pre-commit hook fails to display any output when an error
other than a parse error is decteced.

Additionally, the hook may not display any meaningful output depending
on php.ini settings. This commit removes the dependency on php.ini.

PHPBB3-11630

[ticket/10760] Fix numbering in php fun facts.

2012-04-04T15:43:59+00:00

PHPBB3-10760

[ticket/10760] Value must be quoted as it might be two words.

2012-04-04T15:41:14+00:00

PHPBB3-10760

[ticket/10760] PHP is great. This commit is the proof.

2012-04-04T04:27:06+00:00

PHPBB3-10760

[ticket/10760] Catch both versions of parse error output in php.

2012-04-04T04:01:08+00:00

PHPBB3-10760

[ticket/10760] Account for display_errors=stderr in pre-commit hook.

2012-04-04T03:18:33+00:00

With that php.ini value set errors are printed to stderr, therefore
by redirecting stderr to /dev/null we also throw out the errors.

Instead merge stderr into stdout.

PHPBB3-10760

[ticket/10760] Quote PHP_BIN when using it.

2012-04-04T03:14:44+00:00

This should make a difference on windows where paths may include spaces.

PHPBB3-10760

[ticket/10760] Use echo -e only if echo understands -e.

2012-04-04T03:06:50+00:00

/bin/echo on freebsd and dash's builtin echo do not understand -e,
therefore -e is printed with the other messages in such cases.

Test if echo understands -e, if not do not use it.

PHPBB3-10760

[ticket/10760] Use externally specified PHP_BIN if any.

2012-04-04T03:05:15+00:00

We have a PHP_BIN variable but we always set it unconditionally,
therefore in order to use a different php binary one had to
modify the hook script.

Instead set PHP_BIN if it is not set.

Now one can set PHP_BIN in their environment to use a non-default
php binary.

PHPBB3-10760

[ticket/9777] Print error message in pre-commit hook when php is not installed.

2010-08-19T15:44:54+00:00

PHPBB3-9777