From d57079f4b474151515c6c5d298a3ed559943115e Mon Sep 17 00:00:00 2001
From: "lpsolit%gmail.com" <>
Date: Wed, 15 Nov 2006 03:02:01 +0000
Subject: =?UTF-8?q?Bug=20323031:=20process=5Fbug.cgi=20crashes=20when=20en?=
 =?UTF-8?q?countering=20a=20deleted=20user=20account=20and=20when=20strict?=
 =?UTF-8?q?=5Fisolation=20is=20on=20-=20Patch=20by=20Fr=C3=83=C2=A9d=C3=83?=
 =?UTF-8?q?=C2=A9ric=20Buclin=20<LpSolit@gmail.com>=20r=3Dwicked=20a=3Djus?=
 =?UTF-8?q?tdave?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 process_bug.cgi | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

(limited to 'process_bug.cgi')

diff --git a/process_bug.cgi b/process_bug.cgi
index d3f52641e..00594d89e 100755
--- a/process_bug.cgi
+++ b/process_bug.cgi
@@ -1342,7 +1342,8 @@ if ($prod_changed && Bugzilla->params->{"strict_isolation"}) {
         $sth_cc->execute($id);
         my @blocked_cc = ();
         while (my ($pid) = $sth_cc->fetchrow_array) {
-            $usercache{$pid} ||= Bugzilla::User->new($pid);
+            # Ignore deleted accounts. They will never get notification.
+            $usercache{$pid} ||= Bugzilla::User->new($pid) || next;
             my $cc_user = $usercache{$pid};
             if (!$cc_user->can_edit_product($product->id)) {
                 push (@blocked_cc, $cc_user->login);
@@ -1357,7 +1358,7 @@ if ($prod_changed && Bugzilla->params->{"strict_isolation"}) {
         $sth_bug->execute($id);
         my ($assignee, $qacontact) = $sth_bug->fetchrow_array;
         if (!$assignee_checked) {
-            $usercache{$assignee} ||= Bugzilla::User->new($assignee);
+            $usercache{$assignee} ||= Bugzilla::User->new($assignee) || next;
             my $assign_user = $usercache{$assignee};
             if (!$assign_user->can_edit_product($product->id)) {
                     ThrowUserError('invalid_user_group',
@@ -1367,7 +1368,7 @@ if ($prod_changed && Bugzilla->params->{"strict_isolation"}) {
             }
         }
         if (!$qacontact_checked && $qacontact) {
-            $usercache{$qacontact} ||= Bugzilla::User->new($qacontact);
+            $usercache{$qacontact} ||= Bugzilla::User->new($qacontact) || next;
             my $qa_user = $usercache{$qacontact};
             if (!$qa_user->can_edit_product($product->id)) {
                     ThrowUserError('invalid_user_group',
-- 
cgit v1.2.1