From 2545c0950c4f0fde8f78b265217fa9f523eff7bf Mon Sep 17 00:00:00 2001
From: "lpsolit%gmail.com" <>
Date: Tue, 20 Jun 2006 03:15:17 +0000
Subject: =?UTF-8?q?Bug=20304601:=20Bugzilla::Config's=20:locations=20expor?=
 =?UTF-8?q?ts=20need=20to=20be=20in=20their=20own=20module=20-=20Patch=20b?=
 =?UTF-8?q?y=20Fr=C3=A9d=C3=A9ric=20Buclin=20<LpSolit@gmail.com>=20r=3Dmka?=
 =?UTF-8?q?nat=20for=20the=20main=20patch,=20r=3Dmyk=20for=20the=20patch?=
 =?UTF-8?q?=20about=20CGI.pm=20a=3Djustdave?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Bug 328637: Remove all legal_* versioncache arrays - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=justdave

Bug 110503 - Eliminate versioncache
---
 editvalues.cgi | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

(limited to 'editvalues.cgi')

diff --git a/editvalues.cgi b/editvalues.cgi
index b0a1fbb71..2da48eed2 100755
--- a/editvalues.cgi
+++ b/editvalues.cgi
@@ -217,8 +217,6 @@ if ($action eq 'new') {
                              VALUES ( ?, ? )");
     $sth->execute($value, $sortkey);
 
-    unlink "$datadir/versioncache";
-
     $vars->{'value'} = $value;
     $vars->{'field'} = $field;
     $template->process("admin/fieldvalues/created.html.tmpl",
@@ -287,8 +285,6 @@ if ($action eq 'delete') {
 
     $dbh->bz_unlock_tables();
 
-    unlink "$datadir/versioncache";
-
     $vars->{'value'} = $value;
     $vars->{'field'} = $field;
     $template->process("admin/fieldvalues/deleted.html.tmpl",
@@ -354,7 +350,6 @@ if ($action eq 'update') {
         $dbh->do("UPDATE $field SET sortkey = ? WHERE value = ?",
                  undef, $sortkey, $valueold);
 
-        unlink "$datadir/versioncache";
         $vars->{'updated_sortkey'} = 1;
         $vars->{'sortkey'} = $sortkey;
     }
@@ -377,8 +372,6 @@ if ($action eq 'update') {
         $dbh->do("UPDATE $field SET value = ? WHERE value = ?",
                  undef, $value, $valueold);
 
-        unlink "$datadir/versioncache";
-
         $vars->{'updated_value'} = 1;
     }
 
@@ -387,13 +380,12 @@ if ($action eq 'update') {
     # If the old value was the default value for the field,
     # update data/params accordingly.
     # This update is done while tables are unlocked due to the
-    # annoying call to GetVersionTable in Bugzilla/Config/Common.pm.
+    # annoying calls in Bugzilla/Config/Common.pm.
     if ($value ne $valueold
         && $valueold eq Param($defaults{$field}))
     {
         SetParam($defaults{$field}, $value);
         WriteParams();
-        unlink "$datadir/versioncache";
         $vars->{'default_value_updated'} = 1;
     }
 
-- 
cgit v1.2.1