From c658f1b025d74ae9b4c7716d81377b68a1cc5a52 Mon Sep 17 00:00:00 2001
From: Sunil Joshi <joshi_sunil@in.com>
Date: Wed, 19 Sep 2012 21:55:56 +0200
Subject: Bug 308709: Misleading confirmation when entering an invalid sort key
 for a field value r/a=LpSolit

---
 Bugzilla/Field/Choice.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'Bugzilla/Field')

diff --git a/Bugzilla/Field/Choice.pm b/Bugzilla/Field/Choice.pm
index 2b6d8195f..52fb7b409 100644
--- a/Bugzilla/Field/Choice.pm
+++ b/Bugzilla/Field/Choice.pm
@@ -257,7 +257,7 @@ sub _check_sortkey {
     return 0 if !$value;
     # Store for the error message in case detaint_natural clears it.
     my $orig_value = $value;
-    detaint_natural($value)
+    (detaint_natural($value) && $value <= MAX_SMALLINT)
         || ThrowUserError('fieldvalue_sortkey_invalid',
                           { sortkey => $orig_value,
                             field   => $invocant->field });
-- 
cgit v1.2.1