Bug 304267: Large lists in admin pages fail to display (they take too much time) - Patch by Michael Thomas <mockodin@gmail.com> r/a=LpSolit

1 files changed, 18 insertions, 21 deletions

diff --git a/template/en/default/admin/users/list.html.tmpl b/template/en/default/admin/users/list.html.tmpl
index 4788e527d..cb05e827b 100644
--- a/template/en/default/admin/users/list.html.tmpl
+++ b/template/en/default/admin/users/list.html.tmpl
@@ -63,36 +63,33 @@
 [% END %]
 
 [%# Disabled users are crossed out. Missing realnames are noticed in red. %]
-[% overrides.login_name = [] %]
-[% overrides.realname = [] %]
+[% overrides.login_name = {} %]
+[% overrides.realname = {} %]
 
 [% FOREACH thisuser = users %]
   [% IF !thisuser.realname %]
     [%# We cannot pass one class now and one class later. %]
     [% SET classes = (thisuser.disabledtext ? "bz_inactive missing" : "missing") %]
-    [% overrides.realname.push({
-        match_value      => "$thisuser.login_name"
-        match_field      => 'login_name'
-        content          => "missing"
-        override_content => 1
-        class            => "$classes"
-        override_class   => 1 })
+    [% overrides.realname.login_name.${thisuser.login_name} = {
+           content          => "missing"
+           override_content => 1
+           class            => "$classes"
+           override_class   => 1
+       }
+    %]
+  [% ELSIF thisuser.disabledtext %]
+    [% overrides.realname.login_name.${thisuser.login_name} = {
+           class          => "bz_inactive"
+           override_class => 1
+       }
     %]
   [% END %]
 
   [% IF thisuser.disabledtext %]
-    [% overrides.login_name.push({
-        match_value    => "$thisuser.login_name"
-        match_field    => 'login_name'
-        class          => "bz_inactive"
-        override_class => 1 })
-    %]
-
-    [% overrides.realname.push({
-        match_value    => "$thisuser.login_name"
-        match_field    => 'login_name'
-        class          => "bz_inactive"
-        override_class => 1 })
+    [% overrides.login_name.login_name.${thisuser.login_name} = {
+           class          => "bz_inactive"
+           override_class => 1
+       }
     %]
   [% END %]
 [% END %]