1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
|
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<TITLE> [Mageia-dev] get-skype package for submission
</TITLE>
<LINK REL="Index" HREF="index.html" >
<LINK REL="made" HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20get-skype%20package%20for%20submission&In-Reply-To=%3C4DF323EA.40006%40iki.fi%3E">
<META NAME="robots" CONTENT="index,nofollow">
<META http-equiv="Content-Type" content="text/html; charset=us-ascii">
<LINK REL="Previous" HREF="005393.html">
<LINK REL="Next" HREF="005411.html">
</HEAD>
<BODY BGCOLOR="#ffffff">
<H1>[Mageia-dev] get-skype package for submission</H1>
<B>Anssi Hannula</B>
<A HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20get-skype%20package%20for%20submission&In-Reply-To=%3C4DF323EA.40006%40iki.fi%3E"
TITLE="[Mageia-dev] get-skype package for submission">anssi.hannula at iki.fi
</A><BR>
<I>Sat Jun 11 10:14:34 CEST 2011</I>
<P><UL>
<LI>Previous message: <A HREF="005393.html">[Mageia-dev] get-skype package for submission
</A></li>
<LI>Next message: <A HREF="005411.html">[Mageia-dev] get-skype package for submission
</A></li>
<LI> <B>Messages sorted by:</B>
<a href="date.html#5397">[ date ]</a>
<a href="thread.html#5397">[ thread ]</a>
<a href="subject.html#5397">[ subject ]</a>
<a href="author.html#5397">[ author ]</a>
</LI>
</UL>
<HR>
<!--beginarticle-->
<PRE>On 11.06.2011 03:05, Barry Jackson wrote:
><i> On 10/06/11 18:06, Anssi Hannula wrote:
</I>
>><i> 3. You cp files to %_datadir using a wildcard (*), but these
</I>>><i> files may not be removed on uninstallation as you only have filename
</I>>><i> lists for avatars/sounds/langs. While it may work now (I didn't
</I>>><i> test, I hope you did), this will cause unnoticed problems when the
</I>>><i> skype tarball contents change.
</I>><i>
</I>><i> The wildcard is used to move the remaining files which are all
</I>><i> individually handled by touch and the dir is removed by a %ghost.
</I>><i> I was just saving spec lines.
</I>><i>
</I>><i> Yes it does work fine and all files/dirs are removed on uninstall.
</I>><i>
</I>><i> The tarball contents can't change or the md5sum would fail :\
</I>
I meant that when updating the package to a new version it is easy to
not notice some added files in the tarball, leaving the wildcard in
place but not add respective %ghosted files.
>><i> 4. Provide the script/commandline used to create the filelist files.
</I>><i>
</I>><i> Do you mean the avatars.txt etc.
</I>><i> It was all done semi-manually, but I will write a script if necessary.
</I>><i> It did cross my mind, but it was quicker to just copy/paste into txt files.
</I>><i> I was assuming I could maintain it manually.
</I>
Maintaining manually is fine, just add a comment beside the SourceXX
lines to tell what to do.
>><i> 5. Versionize the filelist files to make sure they are renegerated
</I>>><i> when the package is updated to a new version (avatars-%version.txt)
</I>><i>
</I>><i> OK - again I was expecting to maintain it manually.
</I>
Yes, but this makes sure they are not forgotten (i.e. the pkg build
fails completely if you forget to update them, instead of creating a
broken package).
>><i> 6. Your usage of /tmp seems unsafe security-wise. What if some user
</I>>><i> has created something under /tmp/skype-%version already?
</I>><i>
</I>><i> Hmm.. point taken
</I>><i>
</I>>><i> Instead use mktemp to create a temporary directory.
</I>><i>
</I>><i> OK ... but:
</I>><i> I can't figure out how to get a temp filename into a %define
</I>><i> If I use
</I>><i> %define mytmp $(mktemp -d -q)
</I>><i> then every reference to the %define generates a new tmp file.
</I>><i> How can I assign the output of a command expansion to a %define so it's
</I>><i> evaluated only once on assignment?
</I>
%global mytmp %(mktemp -d -q)
However, that doesn't do what you want. That creates a temporary
directory in the system where package build is not done, while you want
to create a temporary directory in the user system. See below.
><i> I can use a variable in %pre but that is invisible in %post as it's in
</I>><i> another shell so I'm sorta stuck on that for now :(
</I>
Probably the easiest way is to use a fixed location under
%{_localstatedir}/lib/%{name} for the tarball instead. Then you can use
mktemp locally in %post.
Also, is there a need to use -q for mktemp?
--
Anssi Hannula
</PRE>
<!--endarticle-->
<HR>
<P><UL>
<!--threads-->
<LI>Previous message: <A HREF="005393.html">[Mageia-dev] get-skype package for submission
</A></li>
<LI>Next message: <A HREF="005411.html">[Mageia-dev] get-skype package for submission
</A></li>
<LI> <B>Messages sorted by:</B>
<a href="date.html#5397">[ date ]</a>
<a href="thread.html#5397">[ thread ]</a>
<a href="subject.html#5397">[ subject ]</a>
<a href="author.html#5397">[ author ]</a>
</LI>
</UL>
<hr>
<a href="https://www.mageia.org/mailman/listinfo/mageia-dev">More information about the Mageia-dev
mailing list</a><br>
</body></html>
|
