[Mageia-sysadm] [2003] add header to the mail on the sympa, popular request asked on

[Michael Scherer]

Le lundi 12 septembre 2011 à 23:43 +0200, nicolas vigier a écrit :
> On Mon, 12 Sep 2011, root at mageia.org wrote:
> 
> > Revision: 2003
> > Author:   misc
> > Date:     2011-09-12 23:38:16 +0200 (Mon, 12 Sep 2011)
> > Log Message:
> > -----------
> > add header to the mail on the sympa, popular request asked on
> > sysadmin. Disable previous commit since the xml file is used only when the
> > ml is created ( and not used after anymore )
> > 
> > Modified Paths:
> > --------------
> >     puppet/modules/sympa/manifests/init.pp
> >     puppet/modules/sympa/templates/config
> >     puppet/modules/sympa/templates/list.xml
> > 
> > Modified: puppet/modules/sympa/manifests/init.pp
> > ===================================================================
> > --- puppet/modules/sympa/manifests/init.pp	2011-09-12 20:32:25 UTC (rev 2002)
> > +++ puppet/modules/sympa/manifests/init.pp	2011-09-12 21:38:16 UTC (rev 2003)
> > @@ -186,7 +186,7 @@
> >                  $subscriber_ldap_group = false,
> >                  $public_archive = true,
> >                  $subscription_open = false,
> > -    		$custom_subject = '') {
> > +    		) {
> >  
> >          include sympa::variable
> >          $ldap_password = extlookup("sympa_ldap",'x')
> > 
> > Modified: puppet/modules/sympa/templates/config
> > ===================================================================
> > --- puppet/modules/sympa/templates/config	2011-09-12 20:32:25 UTC (rev 2002)
> > +++ puppet/modules/sympa/templates/config	2011-09-12 21:38:16 UTC (rev 2003)
> > @@ -104,4 +104,4 @@
> >  
> >  review private
> >  
> > -
> > +custom_subject [%list.name%]
> 
> Can we add it only as an option ? I think some lists like bugs lists
> don't need it.

When it was asked to add a custom subject, use cases given were :
- quick ad-hoc filtering ( evolution, tb, kmail )
- differentiation of ml, for provider that do not allow to filter by
header
- differentiation of ml, when someone do not want to filter

I think the quick ad-hoc filtering could be needed also on bugs lists.
And depending the volume of the ml, the 2 others could apply too ( even
if I as I said, I think that's unneeded ).

Sympa is one of our biggest module, 2nd to the whole build system, and
IMHO slightly more complex and twisted than the BS ( who is big because
we pushed IMHO too much thing in it, and that we shall one day split in
smaller submodule, or at least, in different file ). 

Sympa is also quite complex to debug and something that will likely
break on upgrade ( because it already did when upgrading to 6.1 ), so I
would really prefer to keep the variation and potential options as low
as possible if we can, as this will lower the number of thing to test.

So technically, yes, we can add it as a option. Now, for the
aforementioned reasons, I would prefer that we don't ( and I have a
paper of the doctor telling that I should not touch or read sympa source
code if I can avoid )
-- 
Michael Scherer