<span id="result_box" class="" lang="en"><span class="hps">Hello</span><span>,</span><br><span class="hps">I'm</span> <span class="hps">sorry</span><span class="">,</span> <span class="hps">I'm just</span> <span class="hps">Padawan</span><span class="">,</span>� <span class="hps">I thought it was</span> <span class="hps">working fine</span><span>.</span> <span class="hps">I'll try to</span> <span class="hps">fix it</span> <span class="hps">as</span> <span class="hps">soon</span> <span class="hps">as</span> <span class="hps">possible<br> </span></span><span id="result_box" class="short_text" lang="en"><span class="hps">What would be</span> <span class="hps">the best way</span> <span class="hps">to fix it</span><span class="">?<br><br>Bersuit<br><br></span></span><div class="gmail_quote"> 2013/1/12 Colin Guthrie <span dir="ltr"><<a href="mailto:mageia@colin.guthr.ie" target="_blank">mageia@colin.guthr.ie</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> Hello,<br> <br> I see you blindly imported the proftpd package from Mandriva a few days ago.<br> <br> <a href="http://svnweb.mageia.org/packages?view=revision&revision=337420" target="_blank">http://svnweb.mageia.org/packages?view=revision&revision=337420</a><br> <br> This overwrote the changes I pushed a few weeks back.<br> <br> <a href="http://svnweb.mageia.org/packages?view=revision&revision=331311" target="_blank">http://svnweb.mageia.org/packages?view=revision&revision=331311</a><br> <a href="http://svnweb.mageia.org/packages?view=revision&revision=331662" target="_blank">http://svnweb.mageia.org/packages?view=revision&revision=331662</a><br> <br> And you've added a whole bunch of legacy service calls in %post and<br> %postun. Please use systemctl syntax here.<br> <br> In addition, you've overwritten several changes we've made in the last<br> year. e.g. xinetd fixes, ftpuser fixes etc.<br> <br> <br> <br> Please be careful not to break things and don't blindly import something<br> on the assumption it's better :(<br> <br> I think it's is likely quite rare now that importing another distro's<br> package over the top of a package we've updated several times is a good<br> idea...<br> <br> <br> I've reapplied the changes we made now, but I'm guessing a more thorough<br> review would still be a good idea.<br> <br> I've got enough of a package backlog to fix up, so please ensure you do<br> not break things again :(<br> <br> Col<br> <span class="HOEnZb"><font color="#888888"><br> --<br> <br> Colin Guthrie<br> colin(at)<a href="http://mageia.org" target="_blank">mageia.org</a><br> <a href="http://colin.guthr.ie/" target="_blank">http://colin.guthr.ie/</a><br> <br> Day Job:<br> � Tribalogic Limited <a href="http://www.tribalogic.net/" target="_blank">http://www.tribalogic.net/</a><br> Open Source:<br> � Mageia Contributor <a href="http://www.mageia.org/" target="_blank">http://www.mageia.org/</a><br> � PulseAudio Hacker <a href="http://www.pulseaudio.org/" target="_blank">http://www.pulseaudio.org/</a><br> � Trac Hacker <a href="http://trac.edgewall.org/" target="_blank">http://trac.edgewall.org/</a><br> </font></span></blockquote></div><br>