<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<TITLE> [Mageia-dev] [soft-commits] [5525] (mkinitrd) Fix prefix checking in foreign partition check (mga#6966)
</TITLE>
<LINK REL="Index" HREF="index.html" >
<LINK REL="made" HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20%5Bsoft-commits%5D%20%5B5525%5D%20%28mkinitrd%29%20Fix%20prefix%0A%20checking%20in%20foreign%20partition%20check%20%28mga%236966%29&In-Reply-To=%3C504228AD.1080807%40colin.guthr.ie%3E">
<META NAME="robots" CONTENT="index,nofollow">
<META http-equiv="Content-Type" content="text/html; charset=us-ascii">
<LINK REL="Previous" HREF="018406.html">
<LINK REL="Next" HREF="018405.html">
</HEAD>
<BODY BGCOLOR="#ffffff">
<H1>[Mageia-dev] [soft-commits] [5525] (mkinitrd) Fix prefix checking in foreign partition check (mga#6966)</H1>
<B>Colin Guthrie</B>
<A HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20%5Bsoft-commits%5D%20%5B5525%5D%20%28mkinitrd%29%20Fix%20prefix%0A%20checking%20in%20foreign%20partition%20check%20%28mga%236966%29&In-Reply-To=%3C504228AD.1080807%40colin.guthr.ie%3E"
TITLE="[Mageia-dev] [soft-commits] [5525] (mkinitrd) Fix prefix checking in foreign partition check (mga#6966)">mageia at colin.guthr.ie
</A><BR>
<I>Sat Sep 1 17:24:29 CEST 2012</I>
<P><UL>
<LI>Previous message: <A HREF="018406.html">[Mageia-dev] [soft-commits] [5525] (mkinitrd) Fix prefix checking in foreign partition check (mga#6966)
</A></li>
<LI>Next message: <A HREF="018405.html">[Mageia-dev] [soft-commits] [5526] (mkinitrd) More logging on why initrd generation is skipped
</A></li>
<LI> <B>Messages sorted by:</B>
<a href="date.html#18408">[ date ]</a>
<a href="thread.html#18408">[ thread ]</a>
<a href="subject.html#18408">[ subject ]</a>
<a href="author.html#18408">[ author ]</a>
</LI>
</UL>
<HR>
<!--beginarticle-->
<PRE>'Twas brillig, and Thierry Vignaud at 01/09/12 16:20 did gyre and gimble:
><i> On 1 September 2012 17:15, Thierry Vignaud <<A HREF="https://www.mageia.org/mailman/listinfo/mageia-dev">thierry.vignaud at gmail.com</A>> wrote:
</I>>>><i> (mkinitrd) Fix prefix checking in foreign partition check (mga#6966)
</I>>><i>
</I>>><i> Nice spot.
</I>>><i>
</I>>>><i> Modified: drakx/trunk/perl-install/bootloader.pm
</I>>>><i> ===================================================================
</I>>>><i> --- drakx/trunk/perl-install/bootloader.pm 2012-08-31 23:38:35 UTC (rev
</I>>>><i> 5524)
</I>>>><i> +++ drakx/trunk/perl-install/bootloader.pm 2012-09-01 14:40:52 UTC (rev
</I>>>><i> 5525)
</I>>>><i> @@ -113,7 +113,7 @@
</I>>>><i> return $initrd if $::testing # testing mode
</I>>>><i> || -e "$::prefix/$initrd" # already exists
</I>>>><i> || $initrd =~ /\(hd/ # unrecognized partition
</I>>>><i> - || !-d $dir; # dir doesn't exist (probably !mounted
</I>>>><i> foreign part)
</I>>>><i> + || !-d "$::prefix/$dir";# dir doesn't exist (probably !mounted
</I>>>><i> foreign part)
</I>><i>
</I>><i> Err, this is not related to bugs mga#6966 which is fixed for long...
</I>
I'm just quoted the bug number from the commit where you introduced the
breakage:
commit 908a594b10b966e0a80701262f989b9ca6b0070c
Author: tv <<A HREF="https://www.mageia.org/mailman/listinfo/mageia-dev">tv at 5b7c3c08-40e5-403b-9995-ace06908e4af</A>>
Date: Tue Aug 7 10:37:22 2012 +0000
(mkinitrd) do not crash if a foreign partition is not mounted (mga#6966)
git-svn-id: svn+<A HREF="ssh://svn.mageia.org/svn/soft/drakx/trunk@5294">ssh://svn.mageia.org/svn/soft/drakx/trunk@5294</A>
5b7c3c08-40e5-403b-9995-ace06908e4af
Col
--
Colin Guthrie
colin(at)mageia.org
<A HREF="http://colin.guthr.ie/">http://colin.guthr.ie/</A>
Day Job:
Tribalogic Limited <A HREF="http://www.tribalogic.net/">http://www.tribalogic.net/</A>
Open Source:
Mageia Contributor <A HREF="http://www.mageia.org/">http://www.mageia.org/</A>
PulseAudio Hacker <A HREF="http://www.pulseaudio.org/">http://www.pulseaudio.org/</A>
Trac Hacker <A HREF="http://trac.edgewall.org/">http://trac.edgewall.org/</A>
</PRE>
<!--endarticle-->
<HR>
<P><UL>
<!--threads-->
<LI>Previous message: <A HREF="018406.html">[Mageia-dev] [soft-commits] [5525] (mkinitrd) Fix prefix checking in foreign partition check (mga#6966)
</A></li>
<LI>Next message: <A HREF="018405.html">[Mageia-dev] [soft-commits] [5526] (mkinitrd) More logging on why initrd generation is skipped
</A></li>
<LI> <B>Messages sorted by:</B>
<a href="date.html#18408">[ date ]</a>
<a href="thread.html#18408">[ thread ]</a>
<a href="subject.html#18408">[ subject ]</a>
<a href="author.html#18408">[ author ]</a>
</LI>
</UL>
<hr>
<a href="https://www.mageia.org/mailman/listinfo/mageia-dev">More information about the Mageia-dev
mailing list</a><br>
</body></html>