[Mageia-dev] [soft-commits] [4332] - fix rebooting on autoinstall

[Arnaud Patard (Rtp)]

Thierry Vignaud <thierry.vignaud at gmail.com> writes:

> On 30 April 2012 09:54,  <root at mageia.org> wrote:
>> Modified: drakx/trunk/perl-install/NEWS
>> ===================================================================
>> --- drakx/trunk/perl-install/NEWS	2012-04-30 07:49:17 UTC (rev 4331)
>> +++ drakx/trunk/perl-install/NEWS	2012-04-30 07:54:17 UTC (rev 4332)
>> @@ -1,3 +1,6 @@
>> +- fix rebooting on autoinstall by using a "wider" regexp (otherwise udevd
>> was
>> +  not found by fuzzy_pidofs) and gives some time to udevd process to
>> disappear.
>> +  Also, don't try to unmount /dev as it's still used by other processes.
>>  - pkgs.pm, http.pm: Allow to set urpm curl options in order to be able
>>    to make curl quiet when running an autoinstall in text mode. This can
>>    be set throught the new option "curl_options" in the auto_inst file.
>>
>> Modified: drakx/trunk/perl-install/install/install2.pm
>> ===================================================================
>> --- drakx/trunk/perl-install/install/install2.pm	2012-04-30 07:49:17 UTC
>> (rev 4331)
>> +++ drakx/trunk/perl-install/install/install2.pm	2012-04-30 07:54:17 UTC
>> (rev 4332)
>> @@ -311,9 +311,10 @@
>>  }
>>
>>  sub stop_udev() {
>> -    kill 15, fuzzy_pidofs('^udevd\b');
>> +    kill 15, fuzzy_pidofs('udevd');
>> +    sleep(2);
>>      require fs::mount;
>> -    fs::mount::umount($_) foreach '/dev/pts', '/dev/shm', '/run', '/dev';
>> +    fs::mount::umount($_) foreach '/dev/pts', '/dev/shm', '/run';
>>  }
>
> Then we could keep /dev/pts & /dev/shm mounted.
> Maybe even not try at all to umount anything.
> After all that doesn't matter much...

I've removed the blocking one and I've no opinion about /dev/pts and
/dev/shm. If you find it cleaner to not unmount them, feel free to
change that in the svn. Anyway, it's stop_udev is called right before
rebooting so it should not make a big difference.

Arnaud