<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN"> <HTML> <HEAD> <TITLE> [Mageia-dev] [soft-commits] [4324] Do not install bootloader when configuring X during install. </TITLE> <LINK REL="Index" HREF="index.html" > <LINK REL="made" HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20%5Bsoft-commits%5D%20%5B4324%5D%20Do%20not%20install%20bootloader%0A%20when%20configuring%20X%20during%20install.&In-Reply-To=%3CCAONrEtYf1bo_uqagGqn8asLyKKayE0wfjE7PZdm0yO3LSnRpug%40mail.gmail.com%3E"> <META NAME="robots" CONTENT="index,nofollow"> <META http-equiv="Content-Type" content="text/html; charset=us-ascii"> <LINK REL="Previous" HREF="015084.html"> <LINK REL="Next" HREF="015069.html"> </HEAD> <BODY BGCOLOR="#ffffff"> <H1>[Mageia-dev] [soft-commits] [4324] Do not install bootloader when configuring X during install.</H1> <B>Thierry Vignaud</B> <A HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20%5Bsoft-commits%5D%20%5B4324%5D%20Do%20not%20install%20bootloader%0A%20when%20configuring%20X%20during%20install.&In-Reply-To=%3CCAONrEtYf1bo_uqagGqn8asLyKKayE0wfjE7PZdm0yO3LSnRpug%40mail.gmail.com%3E" TITLE="[Mageia-dev] [soft-commits] [4324] Do not install bootloader when configuring X during install.">thierry.vignaud at gmail.com </A><BR> <I>Mon Apr 30 08:28:12 CEST 2012</I> <P><UL> <LI>Previous message: <A HREF="015084.html">[Mageia-dev] [soft-commits] [4320] do not explicitely disable cpufreq services, it should always be on </A></li> <LI>Next message: <A HREF="015069.html">[Mageia-dev] [soft-commits] [4332] - fix rebooting on autoinstall </A></li> <LI> <B>Messages sorted by:</B> <a href="date.html#15067">[ date ]</a> <a href="thread.html#15067">[ thread ]</a> <a href="subject.html#15067">[ subject ]</a> <a href="author.html#15067">[ author ]</a> </LI> </UL> <HR> <!--beginarticle--> <PRE>On 30 April 2012 00:59, <<A HREF="https://www.mageia.org/mailman/listinfo/mageia-dev">root at mageia.org</A>> wrote: ><i> - bootloader::action($bootloader, 'write', $all_hds); </I>><i> - bootloader::action($bootloader, 'when_config_changed'); </I>><i> + # Do not install bootloader when configuring X during install. </I>><i> + # This will be done at end of summary to allow selecting where </I>><i> + # to install bootloader. </I>><i> + unless ($::isInstall) { </I>><i> + bootloader::action($bootloader, 'write', $all_hds); </I>><i> + bootloader::action($bootloader, 'when_config_changed'); </I>><i> + } </I>><i> + </I>><i> 1; </I>><i> } </I> You did not run perl_checker as it would have told you the preferedd style is "if !" over "unless" :-) </PRE> <!--endarticle--> <HR> <P><UL> <!--threads--> <LI>Previous message: <A HREF="015084.html">[Mageia-dev] [soft-commits] [4320] do not explicitely disable cpufreq services, it should always be on </A></li> <LI>Next message: <A HREF="015069.html">[Mageia-dev] [soft-commits] [4332] - fix rebooting on autoinstall </A></li> <LI> <B>Messages sorted by:</B> <a href="date.html#15067">[ date ]</a> <a href="thread.html#15067">[ thread ]</a> <a href="subject.html#15067">[ subject ]</a> <a href="author.html#15067">[ author ]</a> </LI> </UL> <hr> <a href="https://www.mageia.org/mailman/listinfo/mageia-dev">More information about the Mageia-dev mailing list</a><br> </body></html>