<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<TITLE> [Mageia-dev] [soft-commits] [4252] fix removing several notebook pages
</TITLE>
<LINK REL="Index" HREF="index.html" >
<LINK REL="made" HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20%5Bsoft-commits%5D%20%5B4252%5D%20fix%20removing%20several%0A%20notebook%20pages&In-Reply-To=%3C4F97B291.7060809%40gmail.com%3E">
<META NAME="robots" CONTENT="index,nofollow">
<META http-equiv="Content-Type" content="text/html; charset=us-ascii">
<LINK REL="Previous" HREF="014757.html">
<LINK REL="Next" HREF="014771.html">
</HEAD>
<BODY BGCOLOR="#ffffff">
<H1>[Mageia-dev] [soft-commits] [4252] fix removing several notebook pages</H1>
<B>Guillaume Rousse</B>
<A HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20%5Bsoft-commits%5D%20%5B4252%5D%20fix%20removing%20several%0A%20notebook%20pages&In-Reply-To=%3C4F97B291.7060809%40gmail.com%3E"
TITLE="[Mageia-dev] [soft-commits] [4252] fix removing several notebook pages">guillomovitch at gmail.com
</A><BR>
<I>Wed Apr 25 10:15:13 CEST 2012</I>
<P><UL>
<LI>Previous message: <A HREF="014757.html">[Mageia-dev] [soft-commits] [4252] fix removing several notebook pages
</A></li>
<LI>Next message: <A HREF="014771.html">[Mageia-dev] [soft-commits] [4252] fix removing several notebook pages
</A></li>
<LI> <B>Messages sorted by:</B>
<a href="date.html#14760">[ date ]</a>
<a href="thread.html#14760">[ thread ]</a>
<a href="subject.html#14760">[ subject ]</a>
<a href="author.html#14760">[ author ]</a>
</LI>
</UL>
<HR>
<!--beginarticle-->
<PRE>Le 25/04/2012 09:56, Thierry Vignaud a écrit :
><i> On 24 April 2012 23:17,<<A HREF="https://www.mageia.org/mailman/listinfo/mageia-dev">root at mageia.org</A>> wrote:
</I>>><i> fix removing several notebook pages
</I>><i>
</I>><i> (...)
</I>><i>
</I>>><i> --- drakx/trunk/perl-install/diskdrake/hd_gtk.pm 2012-04-24 20:10:47 UTC
</I>>><i> (rev 4251)
</I>>><i> +++ drakx/trunk/perl-install/diskdrake/hd_gtk.pm 2012-04-24 21:17:30 UTC
</I>>><i> (rev 4252)
</I>>><i> @@ -285,9 +285,15 @@
</I>>><i> $may_add->(raid2kind()) if @{$all_hds->{raids}};
</I>>><i> $may_add->(loopback2kind()) if @{$all_hds->{loopbacks}};
</I>>><i>
</I>>><i> - @notebook = grep_index {
</I>>><i> - my $b = $_->{marked} or $notebook_widget->remove_page($::i);
</I>>><i> - $b;
</I>>><i> + my $i = 0;
</I>>><i> + @notebook = grep {
</I>>><i> + if ($_->{marked}) {
</I>>><i> + $i++;
</I>>><i> + 1;
</I>>><i> + } else {
</I>>><i> + $notebook_widget->remove_page($i);
</I>>><i> + 0;
</I>>><i> + }
</I>><i>
</I>><i> Wouldn't have been simpler to decrease $::i instead?
</I>I'm more concerned about the ugly mix between variable affectation (
@notebook = grep {} @list) and additional concerns hidden inside
($notebook_widget->remove_page($i) ). And explicit loop would be easier
to understand, and less error-prone:
my @notebook;
my $i = 0;
foreach my $notebook (@list) {
if ($notebook->{marked}) {
push @notebook, $notebook;
$i++;
} else {
$notebook_widget->remove_page($i);
}
}
--
BOFH excuse #136:
Daemons loose in system.
</PRE>
<!--endarticle-->
<HR>
<P><UL>
<!--threads-->
<LI>Previous message: <A HREF="014757.html">[Mageia-dev] [soft-commits] [4252] fix removing several notebook pages
</A></li>
<LI>Next message: <A HREF="014771.html">[Mageia-dev] [soft-commits] [4252] fix removing several notebook pages
</A></li>
<LI> <B>Messages sorted by:</B>
<a href="date.html#14760">[ date ]</a>
<a href="thread.html#14760">[ thread ]</a>
<a href="subject.html#14760">[ subject ]</a>
<a href="author.html#14760">[ author ]</a>
</LI>
</UL>
<hr>
<a href="https://www.mageia.org/mailman/listinfo/mageia-dev">More information about the Mageia-dev
mailing list</a><br>
</body></html>