[Mageia-dev] mariadb

[Maarten Vanraes]

why are you doing this?

%mklibname works fine, your issue was the bug that mysql-devel wasn't properly 
obsoleted... 

problem is, that you've removed some provides now, so if packages will be 
depending on lib64mysql18, it'll not be working now...

you also did a wrong obsolete with %{version}-%{release}

also, if a package has a maintainer, i think policy (or at least common 
courtesy) is to speak with maintainer about this?

and why even submitting amarok, when mikala will bring new KDE soon?

i'm resubmitting mariadb

you should've just fixed the wrong obsoletes and vendor tag and missing 
provides.

regards,

AL13N

[alien at localhost mariadb]$ svn diff -c 182925
Index: SPECS/mariadb.spec
===================================================================
--- SPECS/mariadb.spec  (revision 182924)
+++ SPECS/mariadb.spec  (revision 182925)
@@ -49,7 +49,7 @@
 Summary:       A very fast and reliable SQL database engine
 Name:          mariadb
 Version:       5.5.18
-Release:       %mkrel 0.bzr%bzrrev
+Release:       %mkrel 0.bzr%{bzrrev}.1
 Group:         Databases
 License:       GPLv2 with exceptions
 URL:           http://mariadb.org/
@@ -228,8 +228,8 @@
 Group:         System/Libraries
 Provides:      %{name}-shared-libs = %{version}-%{release}
 Provides:      %{name}-shared = %{version}-%{release}
-Provides:      %mklibname mysql %{major} = %{version}-%{release}
-Obsoletes:     %mklibname mysql %{major} < 5.5.18
+Provides:      %{_lib}mysql%{major} = %{version}-%{release}
+Obsoletes:     %{_lib}mysql%{major} < 5.5.18
 
 %description -n        %{libname}
 This package contains the shared libraries (*.so*) which certain languages 
and
@@ -239,8 +239,8 @@
 %package -n    %{libmariadbservices}
 Summary:       Shared libraries
 Group:         System/Libraries
-Provides:      %mklibname mysqlservices = %{version}-%{release}
-Obsoletes:     %mklibname mysqlservices < 5.5.18
+Provides:      %{_lib}mysqlservices = %{version}-%{release}
+Obsoletes:     %{_lib}mysqlservices < 5.5.18
 
 %description -n        %{libmariadbservices}
 The libmariadbservices library provides access to the available services and 
@@ -262,11 +262,10 @@
 Requires:      %{name}-client >= %{version}-%{release}
 Provides:      %{name}-devel = %{version}-%{release}
 Provides:      %{libname}-devel = %{version}-%{release}
-Obsoletes:     %{libname}-devel
+Obsoletes:     %{libname}-devel < %{version}-%{release}
 Obsoletes:     %{old_staticdevelname} < 5.5.10
-Obsoletes:     %mklibname -d mysql < 5.5.18
-Provides:      %mklibname -d mysql = %{version}-%{release}
-Provides:      mysql-devel
+Obsoletes:     %{_lib}mysql-devel < 5.5.18
+Provides:      mysql-devel = %{version}-%{release}

 %description -n        %{develname}
 This package contains the development header files and libraries necessary to
@@ -277,8 +276,7 @@
 Group:                 System/Libraries
 Provides:      %{name}-embedded = %{version}-%{release}
 Obsoletes:     %{name}-embedded < 5.5.10-6
-Provides:      %mklibname mysqld %{libmysqlembedded_major} = 
%{version}-%{release}
-Obsoletes:     %mklibname mysqld %{libmysqlembedded_major} < 5.5.18
+Obsoletes:     %{_lib}mysqld%{libmysqlembedded_major} < 5.5.18

 %description -n %{libmariadbembedded}
 MariaDB is a multi-user, multi-threaded SQL database server. This
@@ -292,11 +290,11 @@
 Summary:       Development files for MySQL as an embeddable library
 Group:                 Development/Other
 Provides:      %{name}-embedded-devel = %{version}-%{release}
-Obsoletes:     %{name}-embedded-devel <  5.5.10-6
+Obsoletes:     %{name}-embedded-devel < 5.5.10-6
 Requires:      %{libmariadbembedded} = %{version}-%{release}
 Requires:      %{name}-devel = %{version}-%{release}
-Provides:      %mklibname -d mysqld = %{version}-%{release}
-Obsoletes:     %mklibname -d mysqld < 5.5.18
+Obsoletes:     %{_lib}mysqld-devel < 5.5.18
+Provides:      mysql-embedded-devel = %{version}-%{release}

 %description -n %{libmariadbembedded_devel}
 MariaDB is a multi-user, multi-threaded SQL database server. This
@@ -381,7 +379,7 @@
     -DWITHOUT_DAEMON_EXAMPLE=1 \
     -DWITH_PLUGIN_PBXT=1 \
     -DFEATURE_SET="community" \
-    -DCOMPILATION_COMMENT="Mageia - MariaDB Community Edition (GPL)"
+    -DCOMPILATION_COMMENT="%{_vendor} - MariaDB Community Edition (GPL)"

 cp ../libmysql/libmysql.version libmysql/libmysql.version