[Mageia-dev] proftpd - why was mdv package imported over ours nuking our changes???

Sat Jan 12 16:08:10 CET 2013

'Twas brillig, and Sander Lepik at 12/01/13 15:01 did gyre and gimble:
+> 12.01.2013 16:52, Bersuit Vera kirjutas:
+>> Hello,
+>> I'm sorry, I'm just Padawan,  I thought it was working fine. I'll try to fix it as soon as
+>> possible
+>> What would be the best way to fix it?
+>>
+> Colin already fixed it. But this should not happen again. May I ask who's your mentor? And
+> who allowed such push? You can cherry-pick changes from other specs but you can't replace
+> the whole spec. Your mentor should know that..
+
+Mistakes happen. Don't feel too bad about it, but please do learn from
+it too :)
+
+The package probably worked fine, but if you look at the version history
+of the package you can see we already cleaned up a lot of things from
+the Mandriva package (when we initially forked) and your changes
+effectively undid those tidy ups.
+
+As mentioned previously it's likely far better these days to NOT import
+whole packages from other distros.
+
+As Sander said, it's likely better to cherry pick the changes made to
+the Mandriva package to update (i.e. any new or rediffed patches) over
+to our package (with appropriate credit for the source of the work of
+course - which you did do in your commit message)
+
+Hope this helps, but please feel free to review the changes I made
+(including looking at the previous changes by misc and ahmed to see if
+there are any I missed.
+
+All the best
+
+Col
+
+-- 
+
+Colin Guthrie
+colin(at)mageia.org
+http://colin.guthr.ie/
+
+Day Job:
+  Tribalogic Limited http://www.tribalogic.net/
+Open Source:
+  Mageia Contributor http://www.mageia.org/
+  PulseAudio Hacker http://www.pulseaudio.org/
+  Trac Hacker http://trac.edgewall.org/
+