[Mageia-dev] [soft-commits] [4522] - fix updates installation.

Tue May 15 17:52:37 CEST 2012

On 15 May 2012 17:21,  <root at mageia.org> wrote:
+> Revision 4522 Author rtp Date 2012-05-15 17:21:44 +0200 (Tue, 15 May 2012)
+>
+> Log Message
+>
+> - fix updates installation. installUpdates was relying on
+> urpmi_add_all_media
+>   return value different than 0, which was always 0 due to the 'undef $wait'
+>   line
+
+This is bogus:
+- if we don't have rpmdrake installed
+- if we're in the text mode install.
+
+What you wanted was probably this:
+
+    my $val = run_program::rooted($::prefix, $binary, '>>', $log_file,
+'2>>', $log_file, @options);
+    undef $wait;
+    $val;
+}
+
+Also your description in NEWS is ... undescriptive
+"fix detecting if adding update media succeeded" would have been better
+
+
+> --- drakx/trunk/perl-install/NEWS	2012-05-15 08:08:22 UTC (rev 4521)
+> +++ drakx/trunk/perl-install/NEWS	2012-05-15 15:21:44 UTC (rev 4522)
+> @@ -1,3 +1,6 @@
+> +Version 14.22 - 15 May 2012
+> +- fix urpmi_add_all_media
+> +
+>  Version 14.21 - 11 May 2012
+>
+>  - harddrake2: allow writing 0 as module option, and forbid options
+>
+> Modified: drakx/trunk/perl-install/any.pm
+> ===================================================================
+> --- drakx/trunk/perl-install/any.pm	2012-05-15 08:08:22 UTC (rev 4521)
+> +++ drakx/trunk/perl-install/any.pm	2012-05-15 15:21:44 UTC (rev 4522)
+> @@ -976,8 +976,8 @@
+>      local $ENV{URPMI_ADDMEDIA_REASON} = $reason;
+>
+>      my $log_file = '/root/drakx/updates.log';
+> +    undef $wait;
+>      run_program::rooted($::prefix, $binary, '>>', $log_file, '2>>',
+> $log_file, @options);
+> -    undef $wait;
+>  }
+