[Mageia-dev] [soft-commits] [3526] make clean-rpmsrate 11. 5% faster on average on cached repo directory by

Thu Mar 15 20:20:44 CET 2012

On Thu, Mar 15, 2012 at 19:13,  <root at mageia.org> wrote:
+> Revision 3526 Author tv Date 2012-03-15 20:13:03 +0100 (Thu, 15 Mar 2012)
+>
+> Log Message
+>
+> make clean-rpmsrate 11.5% faster on average on cached repo directory by
+> doing less work in the regexp engine and less path walks
+>
+> elapsed time consistently go down from 0.70 to 0.62 on scores of run
+> (mainly a win in time spend in the kernel)
+>
+> Modified Paths
+>
+> mgatools/trunk/NEWS
+> mgatools/trunk/clean-rpmsrate
+>
+> Modified: mgatools/trunk/NEWS
+> ===================================================================
+> --- mgatools/trunk/NEWS	2012-03-15 19:13:00 UTC (rev 3525)
+> +++ mgatools/trunk/NEWS	2012-03-15 19:13:03 UTC (rev 3526)
+> @@ -3,6 +3,7 @@
+>    o fix matching dkms packages (broken for years...)
+>    o fix matching locales-xx_XX for localized packages
+>    o fix matching mga extension (broken since mga fork)
+> +  o 11.5% faster on average on cached repo directory
+>
+>  0.1:
+>  - initial release
+>
+> Modified: mgatools/trunk/clean-rpmsrate
+> ===================================================================
+> --- mgatools/trunk/clean-rpmsrate	2012-03-15 19:13:00 UTC (rev 3525)
+> +++ mgatools/trunk/clean-rpmsrate	2012-03-15 19:13:03 UTC (rev 3526)
+> @@ -18,6 +18,9 @@
+>
+>  my %rpm;
+>  foreach my $dir (@ARGV) {
+> -    $rpm{$dir} = [ map { s!$dir/?(.*)\.rpm$!$1!; $_ } glob "$dir/*.rpm" ];
+> +    chdir($dir);
+> +    $rpm{$dir} = [ map { s!(.*)\.rpm$!$1!; $_ } glob "*.rpm" ];
+
+What about  s!\.rpm$!! ?
+
+>  }
+> +chdir($ENV{PWD}); # in case -o referes to a relative path
+> +
+>  cleanrpmsrate($rpmsrate_raw_file, $output_file, \%rpm);
+>
+