[Mageia-dev] wine [263611] new version 1.5.7

Fri Jul 27 15:10:59 CEST 2012

27.07.2012 15:27, Damien Lallement kirjoitti:
+> Le 27/07/2012 13:52, Anssi Hannula a écrit :
+>> 25.06.2012 20:48, root at mageia.org kirjoitti:
+>>> Revision
+>>>     263611
+>>> Author
+>>>     dams
+>>> Date
+>>>     2012-06-25 19:48:03 +0200 (Mon, 25 Jun 2012)
+>>>
+>>>
+>>>       Log Message
+>>>
+>>> new version 1.5.7
+>> [...]
+>>> Modified: cauldron/wine/current/SPECS/wine.spec
+>>> ===================================================================
+>>> --- cauldron/wine/current/SPECS/wine.spec    2012-06-25 17:42:45 UTC
+>>> (rev 263610)
+>>> +++ cauldron/wine/current/SPECS/wine.spec    2012-06-25 17:48:03 UTC
+>>> (rev 263611)
+>>> @@ -19,10 +19,10 @@
+>>>
+>>>   # When altering this, make sure the new wine-gecko is submitted or
+>>> at least
+>>>   # notify its maintainer of the needed update.
+>>> -%define gecko_version    1.5
+>>> +%define gecko_version    1.6
+>>
+>> Please read the above comment.
+>>
+>> Our wine-gecko is 1.4 and I haven't gotten any notification. So just
+>> remember it next time :)
+>
+> [dams at maximus wine]$ rpmbuild -ba SPECS/wine.spec
+> + [...]
+> + /bin/cat /home/dams/RPM/SOURCES/wine-mgaconf.patch
+> + /usr/bin/patch -s -p1 -b --suffix .conf --fuzz=0
+> ++ sed -rn 's,^#define\s+GECKO_VERSION\s+"([^"]*)".*$,\1,p'
+> dlls/appwiz.cpl/addons.c
+> + GECKO_VERSION=1.6
+> + '[' 1.6 = 1.4 ']'
+> + echo wine-gecko version mismatch
+> wine-gecko version mismatch
+> + exit 1
+> erreur :
+>
+> So... That's why I updated this %define in the time when pushing new
+> release of wine... :-/
+
+I didn't say you shouldn't have updated the define, but you should've 
+followed what the comment says. I.e. "When altering this, notify 
+wine-gecko maintainer or update wine-gecko yourself". If the comment 
+isn't clear enough, feel free to make it clearer (I'm not sure how).
+
+-- 
+Anssi Hannula
+