[Mageia-dev] RFC: task-obsolete and README.*.urpmi enhancement

Thu Jan 5 00:28:25 CET 2012

Le 04/01/2012 20:26, Anssi Hannula a écrit :
+> On 04.01.2012 17:53, Luc Menut wrote:
+[...]
+>> 1) add support for optional README.*.urpmi (%ghost in spec):
+>> >  This will allow to build this README.*.urpmi at install time in %pre,
+>> >  %post or %trigger only when it's necessary.
+>> >  One use case from the recent past in my mind:
+>> >  we have no way to inform users that still use nspluginwrapper + i586
+>> >  flashplayer on x86_64 (and only them), that this is now deprecated and
+>> >  they should replace the i586 by the x86_64 flashplayer,
+>> >  https://bugs.mageia.org/show_bug.cgi?id=2146#c22
+>> >  https://bugs.mageia.org/show_bug.cgi?id=2146#c25
+> This change seems reasonable.
+>
+>> >  2) handle README.*.(obsolete|deprecated).urpmi
+[...]
+> I don't understand the need for this one, isn't this just the same as
+> README.urpmi?
+
+You are right, we don't need this part; each trigger can add its message 
+in task-obsolete/README.urpmi.
+
+we just need the following patch to handle %ghost README.urpmi :
+
+Index: urpm/install.pm
+===================================================================
+--- urpm/install.pm     (revision 2572)
++++ urpm/install.pm     (working copy)
+@@ -109,6 +109,7 @@
+
+      foreach my $file ($pkg->files) {
+         my ($kind) = $file =~ m!/README([^/]*)\.urpmi$! or next;
++       -r $file or next;
+         my $valid;
+         if ($kind eq '') {
+             $valid = 1;
+
+
+
+-- 
+Luc Menut
+