[Mageia-dev] [soft-commits] [3047] - fix wrong dates in the NEWS file

Sat Feb 25 18:24:51 CET 2012

Op zaterdag 25 februari 2012 17:27:18 schreef Thierry Vignaud:
+> On 25 February 2012 17:09,  <root at mageia.org> wrote:
+> > Revision 3047 Author alien Date 2012-02-25 17:09:50 +0100 (Sat, 25 Feb
+> > 2012)
+> > 
+> > Log Message
+> > 
+> > - fix wrong dates in the NEWS file
+> > - add logging to dropbear
+> > - make sure /dev/pts is mounted (mga#1023)
+> > - make root user homedir /root
+> > - add agetty (mga#2052)
+> 
+> you introduced a bogus date btw :-)
+> More seriously please separate your commits next time, do not mix:
+> - styling (eg: fixing dates)
+> - actual changes
+> - version bumping
+> 
+> Also you failed to actually do the later because you didn't bump the
+> version in Makefile
+> 
+> Last but not least, this wasn't the right fix.
+> The right fix was to do it in rc.sysinit
+> (see my commit)
+
+hmm, are you sure that's the way to go?
+
+because those entries are in the etc/fstab (so it should be the same) and when 
+i tested beta1, i noticed that both mounts were actually to 
+/tmp/stage2/dev/pts and not /dev/pts; and for some reason that fails for 
+dropbear openpty allocation. only after i explicitly mounted again /dev/pts 
+did it work.
+
+can you test to make sure dropbear still works?
+