[Mageia-dev] Packages for review

Sun Dec 2 20:53:46 CET 2012

On 02/12/12 12:42, Barry Jackson wrote:
+> On 02/12/12 09:37, Joseph Wang wrote:
+>> Can someone check the following package submissions
+>>
+>> quantlib
+>> python-pyp2rpm
+>> leocad
+>> leocad-data
+>>
+>> Also, does anyone object if I add the following to task-games?
+>>
+>> vassal
+>> simutrans
+>> leocad (once it gets run)
+>>
+> Joseph I notice that some e.g. quantlib (I didn't look at all) of your
+> specs are missing proper tabbed (or spaced) indentation.
+> example here http://paste.kde.org/618332/
+>
+> quantlib:
+> There is a dot ending summary(s)
+>
+> svn should be part of release not version and I don't think the
+> %if...%endif is going to work as you expect.
+>
+>
+The %if is OK ignore my last comment ;)
+Attached is a patch that shows a possible approach regarding the Release 
+tag.
+-------------- next part --------------
+Index: SPECS/quantlib.spec
+===================================================================
+--- SPECS/quantlib.spec	(revision 325459)
++++ SPECS/quantlib.spec	(working copy)
+@@ -1,11 +1,11 @@
+ %define svn 0
+-%define baseversion 1.2.1
++%define rel 1 
+ %define major 0
+ 
+ %if %svn
+-%define version %{baseversion}.svn%{svn}
++%define release %mkrel -c %{svn} %{rel}
+ %else
+-%define version %{baseversion}
++%define release %mkrel %{rel}
+ %endif
+ 
+ # Define some specific macros
+@@ -15,8 +15,8 @@
+ 
+ Summary: The free/open-source library for quantitative finance.
+ Name: quantlib
+-Version: %{version}
+-Release: %mkrel 1
++Version: 1.2.1
++Release: %{release}
+ License: BSD License
+ Group: System/Libraries
+ Vendor: QuantLib.org
+@@ -29,6 +29,7 @@
+ URL: http://quantlib.org/
+ BuildRequires: boost-devel >= 1.34.1
+ BuildRequires: doxygen >= 1.3, graphviz
++BuildRequires: emacs
+ 
+ %define libname %mklibname %{name} 1
+ %define libname_devel %mklibname -d %{name}
+@@ -77,7 +78,7 @@
+ pre-constructed test cases, and helps in validating the library.
+ 
+ %prep
+-%setup -q -n QuantLib-%{baseversion}
++%setup -q -n QuantLib-%{version}
+ %apply_patches
+ 
+ %build
+