[Mageia-dev] [1266] add missing function ( and no titi, perl_checker didn' t notice this one, but pterjan checker did )

Wed May 11 10:26:58 CEST 2011

On 11 May 2011 07:28, Michael scherer <misc at zarb.org> wrote:
+>> > add missing function ( and no titi, perl_checker didn't notice this one, but
+>> > pterjan checker did )
+>>
+>> you lie:
+>
+> Or maybe I misued perl_checker :/
+>
+> How do you check, just perl_checker file ?
+
+You didn't misued it but you are not used to it :-)
+So you failed to see at end of log that it was aborting
+due to some core perl modules not following
+proper perl_checker style.
+Thus it didn't completed its checks on the file.
+
+So I blacklisted some more modules:
+http://svnweb.mageia.org/soft/build_system/iurt/trunk/.perl_checker?r1=17&r2=1272
+
+BTW, note that, in the previous years, I already run perl_checker
+on iurt and added comments about dubious stuff in the code...
+
+eg dead code:
+793 	# FIXME: (tv) kill this dead code or use it!!
+794 	my $_s = sub {
+795 	if ($run{main}) {
+796 	plog("dumping cache...");
+797 	dump_cache_par(\%run);
+798 	$Data::Dumper::Indent = 0;
+799 	$Data::Dumper::Terse = 1;
+800 	plog("Running environment:\n", Data::Dumper->Dump([\%run]), "\n");
+801 	plog("Configuration:\n", Data::Dumper->Dump([$config]), "\n");
+802 	}
+803 	exit();
+804 	};
+
+eg supposed to be doing stuff for arches but not actually using arch value
+(aka a look that is equivalent to one single assignment):
+1425 	foreach my $arch (@{$config->{supported_arch}}) { #FIXME: (tv)
+this loop looks suspiciously broken
+1426 	$ok &&= $cache->{queue}{$srpm};
+1427 	}
+
+and the like
+