diff options
Diffstat (limited to 'zarb-ml/mageia-dev/2012-May/015682.html')
| -rw-r--r-- | zarb-ml/mageia-dev/2012-May/015682.html | 126 |
1 files changed, 126 insertions, 0 deletions
diff --git a/zarb-ml/mageia-dev/2012-May/015682.html b/zarb-ml/mageia-dev/2012-May/015682.html new file mode 100644 index 000000000..720391c00 --- /dev/null +++ b/zarb-ml/mageia-dev/2012-May/015682.html @@ -0,0 +1,126 @@ +<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN"> +<HTML> + <HEAD> + <TITLE> [Mageia-dev] [soft-commits] [4522] - fix updates installation. + </TITLE> + <LINK REL="Index" HREF="index.html" > + <LINK REL="made" HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20%5Bsoft-commits%5D%20%5B4522%5D%20-%20fix%20updates%20installation.&In-Reply-To=%3CCAONrEtZPnoSFZnGT%2B5zWGYsV5884ijWYxMik%2B%3D0rX3LUnqgp5g%40mail.gmail.com%3E"> + <META NAME="robots" CONTENT="index,nofollow"> + <META http-equiv="Content-Type" content="text/html; charset=us-ascii"> + <LINK REL="Previous" HREF="015701.html"> + <LINK REL="Next" HREF="015685.html"> + </HEAD> + <BODY BGCOLOR="#ffffff"> + <H1>[Mageia-dev] [soft-commits] [4522] - fix updates installation.</H1> + <B>Thierry Vignaud</B> + <A HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20%5Bsoft-commits%5D%20%5B4522%5D%20-%20fix%20updates%20installation.&In-Reply-To=%3CCAONrEtZPnoSFZnGT%2B5zWGYsV5884ijWYxMik%2B%3D0rX3LUnqgp5g%40mail.gmail.com%3E" + TITLE="[Mageia-dev] [soft-commits] [4522] - fix updates installation.">thierry.vignaud at gmail.com + </A><BR> + <I>Tue May 15 17:52:37 CEST 2012</I> + <P><UL> + <LI>Previous message: <A HREF="015701.html">[Mageia-dev] Freeze push: muparser +</A></li> + <LI>Next message: <A HREF="015685.html">[Mageia-dev] [soft-commits] [4522] - fix updates installation. +</A></li> + <LI> <B>Messages sorted by:</B> + <a href="date.html#15682">[ date ]</a> + <a href="thread.html#15682">[ thread ]</a> + <a href="subject.html#15682">[ subject ]</a> + <a href="author.html#15682">[ author ]</a> + </LI> + </UL> + <HR> +<!--beginarticle--> +<PRE>On 15 May 2012 17:21, <<A HREF="https://www.mageia.org/mailman/listinfo/mageia-dev">root at mageia.org</A>> wrote: +><i> Revision 4522 Author rtp Date 2012-05-15 17:21:44 +0200 (Tue, 15 May 2012) +</I>><i> +</I>><i> Log Message +</I>><i> +</I>><i> - fix updates installation. installUpdates was relying on +</I>><i> urpmi_add_all_media +</I>><i> return value different than 0, which was always 0 due to the 'undef $wait' +</I>><i> line +</I> +This is bogus: +- if we don't have rpmdrake installed +- if we're in the text mode install. + +What you wanted was probably this: + + my $val = run_program::rooted($::prefix, $binary, '>>', $log_file, +'2>>', $log_file, @options); + undef $wait; + $val; +} + +Also your description in NEWS is ... undescriptive +"fix detecting if adding update media succeeded" would have been better + + +><i> --- drakx/trunk/perl-install/NEWS 2012-05-15 08:08:22 UTC (rev 4521) +</I>><i> +++ drakx/trunk/perl-install/NEWS 2012-05-15 15:21:44 UTC (rev 4522) +</I>><i> @@ -1,3 +1,6 @@ +</I>><i> +Version 14.22 - 15 May 2012 +</I>><i> +- fix urpmi_add_all_media +</I>><i> + +</I>><i> Version 14.21 - 11 May 2012 +</I>><i> +</I>><i> - harddrake2: allow writing 0 as module option, and forbid options +</I>><i> +</I>><i> Modified: drakx/trunk/perl-install/any.pm +</I>><i> =================================================================== +</I>><i> --- drakx/trunk/perl-install/any.pm 2012-05-15 08:08:22 UTC (rev 4521) +</I>><i> +++ drakx/trunk/perl-install/any.pm 2012-05-15 15:21:44 UTC (rev 4522) +</I>><i> @@ -976,8 +976,8 @@ +</I>><i> local $ENV{URPMI_ADDMEDIA_REASON} = $reason; +</I>><i> +</I>><i> my $log_file = '/root/drakx/updates.log'; +</I>><i> + undef $wait; +</I>><i> run_program::rooted($::prefix, $binary, '>>', $log_file, '2>>', +</I>><i> $log_file, @options); +</I>><i> - undef $wait; +</I>><i> } +</I></PRE> + + + + + + + + + + + + + + + + + + + + + + + +<!--endarticle--> + <HR> + <P><UL> + <!--threads--> + <LI>Previous message: <A HREF="015701.html">[Mageia-dev] Freeze push: muparser +</A></li> + <LI>Next message: <A HREF="015685.html">[Mageia-dev] [soft-commits] [4522] - fix updates installation. +</A></li> + <LI> <B>Messages sorted by:</B> + <a href="date.html#15682">[ date ]</a> + <a href="thread.html#15682">[ thread ]</a> + <a href="subject.html#15682">[ subject ]</a> + <a href="author.html#15682">[ author ]</a> + </LI> + </UL> + +<hr> +<a href="https://www.mageia.org/mailman/listinfo/mageia-dev">More information about the Mageia-dev +mailing list</a><br> +</body></html> |