From 511d8c7e5f5298458e6edb8a23511400cc845c93 Mon Sep 17 00:00:00 2001 From: Thierry Vignaud Date: Wed, 5 Aug 2009 12:56:48 +0000 Subject: (already_installed_or_not_installable) do not show empty dialogs (backported from TRUNK) (#47751) rationale: due to some bugs in urpmi, we cannot always keep the state and thus urpm::select::translate_already_installed() results in us displaying empty dialogs sometimes --- NEWS | 2 ++ Rpmdrake/pkg.pm | 4 +++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index bd5a9dc6..324b3721 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,5 @@ +- do not show empty dialogs when uninstalling packages (#47751) + Version 5.0.8 - 20 March 2009, Thierry Vignaud - fix crashing on uninstalling packages (#47751) diff --git a/Rpmdrake/pkg.pm b/Rpmdrake/pkg.pm index d8f05edb..1621e74e 100644 --- a/Rpmdrake/pkg.pm +++ b/Rpmdrake/pkg.pm @@ -833,7 +833,9 @@ you may now inspect some in order to take actions:"), }, already_installed_or_not_installable => sub { my ($msg1, $msg2) = @_; - interactive_msg(N("Error"), join("\n", @$msg1, @$msg2)); + my $msg = join("\n", @$msg1, @$msg2); + return if !$msg; # workaround missing state + interactive_msg(N("Error"), $msg); }, }, ); -- cgit v1.2.1