perl_checker cleanups

1 files changed, 3 insertions, 5 deletions

diff --git a/rpmdrake b/rpmdrake
index 7233897b..01c36ee2 100755
--- a/rpmdrake
+++ b/rpmdrake
@@ -46,7 +46,6 @@ use Rpmdrake::widgets;
 $ugtk2::wm_icon = "title-$MODE";
 
 our $w;
-my $treeview_dialog_run = 0;
 our $statusbar;
 
 
@@ -54,7 +53,7 @@ sub do_search($$$$$$$) {
     my ($find_entry, $tree, $tree_model, $options, $current_search_type, $urpm, $pkgs) = @_;
     my $entry = $find_entry->get_text or return;
     my $entry_rx = eval { qr/$entry/i } or return;
-    my ($results_ok) = (N("Search results"));
+    my $results_ok = N("Search results");
     $options->{delete_category}->($_) foreach $results_ok;
     $options->{state}{flat} and $options->{delete_all}->();
     $tree->collapse_all;
@@ -263,7 +262,7 @@ sub run_treeview_dialog {
         normal => [ 'normal' ],
     );
     my $old_value;
-    my $cbox = gtksignal_connect(Gtk2::ComboBox->new_with_strings([ @modes{ 'all', if_($compssUsers, 'mandrake_choices'),
+    my $cbox = gtksignal_connect(Gtk2::ComboBox->new_with_strings([ @modes{'all', if_($compssUsers, 'mandrake_choices'),
                                                                               qw(installed non_installed all_updates security bugfix normal)
                                                                           } ],
                                                                   $modes{$default_mode{$MODE} || 'all'}),
@@ -390,7 +389,7 @@ sub run_treeview_dialog {
            }, undef, '<CheckItem>' ],
 	    [ N("/_Options") . N("/_Media Manager"), undef, sub {
                require Rpmdrake::edit_urpm_sources;
-               Rpmdrake::edit_urpm_sources::run() and $rmodes{pkgs_provider({ skip_updating_mu => 1 }, $options->{tree_mode})};
+               Rpmdrake::edit_urpm_sources::run() && $rmodes{pkgs_provider({ skip_updating_mu => 1 }, $options->{tree_mode})};
            }, undef, '<Item>' ],
 	    [ N("/_Options") . N("/_Show automatically selected packages"), undef, sub {
 		$dont_show_selections = !$checkbox_show_autoselect->get_active;
@@ -529,7 +528,6 @@ sub run_treeview_dialog {
     };
     $options->{init_callback} = $find_callback if $options{search};
 
-    $treeview_dialog_run = 1;
     ask_browse_tree_given_widgets_for_rpmdrake($options);
 }