diff options
author | Thierry Vignaud <tv@mandriva.org> | 2009-03-18 15:11:19 +0000 |
---|---|---|
committer | Thierry Vignaud <tv@mandriva.org> | 2009-03-18 15:11:19 +0000 |
commit | 54d8d060193c7916f9c215de69c2e91917311b17 (patch) | |
tree | 9c6e0083a44dab29693abcdf7b1af74b2c858c81 | |
parent | 7f0cf8fdf74abd1ef56f430f40082bbc0ffe8285 (diff) | |
download | rpmdrake-54d8d060193c7916f9c215de69c2e91917311b17.tar rpmdrake-54d8d060193c7916f9c215de69c2e91917311b17.tar.gz rpmdrake-54d8d060193c7916f9c215de69c2e91917311b17.tar.bz2 rpmdrake-54d8d060193c7916f9c215de69c2e91917311b17.tar.xz rpmdrake-54d8d060193c7916f9c215de69c2e91917311b17.zip |
(run_treeview_dialog) do not harcode column id and fix it (in
'toggled' signal handler too) ;
this means we got the right cell renderer and thus the 'toggled'
signal handler does be connected ;
this means we stop ignoring selected/unselected packages (embarassing
bug #29835)
(this regression was introduced in r242980 on 2008-06-18:
"(refresh_packages_list, run_treeview_dialog) show type of update in
mandrivaupdate: fix, security, ... (spec 216)")
-rwxr-xr-x | MandrivaUpdate | 4 | ||||
-rw-r--r-- | NEWS | 5 |
2 files changed, 7 insertions, 2 deletions
diff --git a/MandrivaUpdate b/MandrivaUpdate index 680bc857..77de8580 100755 --- a/MandrivaUpdate +++ b/MandrivaUpdate @@ -214,7 +214,7 @@ sub run_treeview_dialog { $list->set_rules_hint(1); - my $bool_col = $list->get_column(0); + my $bool_col = $list->get_column($pkg_columns{selected}); $bool_col->set_fixed_width(24); $bool_col->set_sizing('fixed'); $bool_col->set_sort_column_id($pkg_columns{selected}); @@ -261,7 +261,7 @@ sub run_treeview_dialog { my $cell = ($bool_col->get_cell_renderers)[0]; $cell->signal_connect(toggled => sub { my ($cell, $text_path) = @_; - my ($val, $name) = @{$list->{data}[$text_path]}; + my $name = @{$list->{data}[$text_path]}[$pkg_columns{text}]; gtkset_mousecursor_wait($w->{real_window}->window); my $_guard = before_leaving(sub {gtkset_mousecursor_normal($w->{real_window}->window) }); toggle($list, $name); @@ -1,3 +1,8 @@ +- MandrivaUpdate: + o fix ignoring selected/unselected packages (embarassing bug #29835) + (regression introduced in 4.10 on 24 June 2008: "show type of + update in mandrivaupdate (fix, security, ...)") + Version 5.0.6 - 15 February 2009, Thierry Vignaud - edit-urpm-sources: |