From 98a24eafad4cafd2d140e8785348cc09543ac950 Mon Sep 17 00:00:00 2001 From: Pascal Rigaux Date: Fri, 7 Sep 2007 12:38:39 +0000 Subject: mark clearly what are errors (ERROR) and what could be better (WARNING) --- t/superuser--file-conflicts.t | 12 ++++++------ t/superuser--provide-and-no-obsolete.t | 2 +- t/superuser--split-transactions--conflict.t | 4 ++-- ...eruser--split-transactions--strict-require-and-obsolete.t | 2 +- 4 files changed, 10 insertions(+), 10 deletions(-) diff --git a/t/superuser--file-conflicts.t b/t/superuser--file-conflicts.t index 91436ac8..4fade655 100644 --- a/t/superuser--file-conflicts.t +++ b/t/superuser--file-conflicts.t @@ -30,7 +30,7 @@ test_urpmi_same_transaction(); test_urpmi_different_transactions(); sub test_rpm_same_transaction { - # disabled, fail (#32528) + # ERROR: disabled, fail (#32528) #test_rpm_i_fail('a', 'b'); #check_nothing_installed(); @@ -40,7 +40,7 @@ sub test_rpm_same_transaction { test_rpm_i_succeeds('a', 'd'); check_installed_and_remove('a', 'd'); - # disabled, fail (#32528) + # ERROR: disabled, fail (#32528) #test_rpm_i_fail('a', 'e'); #check_nothing_installed(); } @@ -68,7 +68,7 @@ sub test_rpm_different_transactions { check_no_etc_files(); test_rpm_i_succeeds('a', 'ga'); - #test_rpm_i_fail('gd'); # broken by rpm patch rpm-4.4.8-speedup-by-not-checking-same-files-with-different-paths-through-symlink.patch + #test_rpm_i_fail('gd'); # WARNING: broken by rpm patch rpm-4.4.8-speedup-by-not-checking-same-files-with-different-paths-through-symlink.patch check_installed_names('a', 'ga'); test_rpm_i_succeeds('gc'); @@ -80,7 +80,7 @@ sub test_rpm_different_transactions { } sub test_urpmi_same_transaction { - # disabled, fail (#32528) + # ERROR: disabled, fail (#32528) #test_urpmi_fail('a', 'b'); #check_nothing_installed(); @@ -90,7 +90,7 @@ sub test_urpmi_same_transaction { urpmi('a d'); check_installed_and_remove('a', 'd'); - # disabled, fail (#32528) + # ERROR: disabled, fail (#32528) #urpmi('a e'); #check_installed_and_remove('a', 'e'); } @@ -119,7 +119,7 @@ sub test_urpmi_different_transactions { check_no_etc_files(); urpmi('a ga'); - #test_urpmi_fail('gd'); # broken by rpm patch rpm-4.4.8-speedup-by-not-checking-same-files-with-different-paths-through-symlink.patch + #test_urpmi_fail('gd'); # WARNING: broken by rpm patch rpm-4.4.8-speedup-by-not-checking-same-files-with-different-paths-through-symlink.patch check_installed_names('a', 'ga'); urpmi('gc'); diff --git a/t/superuser--provide-and-no-obsolete.t b/t/superuser--provide-and-no-obsolete.t index 0ffdad6c..22e80b88 100644 --- a/t/superuser--provide-and-no-obsolete.t +++ b/t/superuser--provide-and-no-obsolete.t @@ -22,7 +22,7 @@ urpmi_addmedia("$medium_name $::pwd/media/$medium_name"); test(sub { urpmi('a'); check_installed_fullnames("a-2-1"); urpme('a') }); test(sub { urpmi('b'); check_installed_fullnames("a-1-1", "b-3-1"); urpme('a b') }); -#- the following test fail. "urpmi --auto-select" should do the same as "urpmi a" +#- ERROR: the following test fail. "urpmi --auto-select" should do the same as "urpmi a" #test(sub { urpmi('--auto-select'); check_installed_fullnames("a-2-1"); urpme('a') }); sub test { diff --git a/t/superuser--split-transactions--conflict.t b/t/superuser--split-transactions--conflict.t index ff3a089d..e41eb724 100644 --- a/t/superuser--split-transactions--conflict.t +++ b/t/superuser--split-transactions--conflict.t @@ -48,7 +48,7 @@ sub test_d { urpmi("--media $name-1 --auto a b c"); check_installed_fullnames('a-1-1', 'b-1-1', 'c-1-1'); - #- below would need the promotion of "b-2" (upgraded from "b-1") + #- WARNING: below would need the promotion of "b-2" (upgraded from "b-1") urpmi("--media $name-2 --auto $option d"); check_installed_fullnames_and_remove('d-1-1'); } @@ -59,7 +59,7 @@ sub test_e { urpmi("--media $name-1 --auto e"); check_installed_fullnames('d-1-1', 'e-1-1'); - #- below would need the promotion of "e-2" (upgraded from "e-1") + #- WARNING: below would need the promotion of "e-2" (upgraded from "e-1") urpmi("--media $name-2 --auto $option c"); check_installed_fullnames_and_remove('c-1-1'); } diff --git a/t/superuser--split-transactions--strict-require-and-obsolete.t b/t/superuser--split-transactions--strict-require-and-obsolete.t index f02cfbeb..c2e2fcd9 100644 --- a/t/superuser--split-transactions--strict-require-and-obsolete.t +++ b/t/superuser--split-transactions--strict-require-and-obsolete.t @@ -41,7 +41,7 @@ sub test_c { urpmi("--media $name-1 --auto a"); check_installed_fullnames('a-1-1', 'bb-1-1', 'c-1-1'); - #- below would need the promotion of "b" (obsoleting bb) to work + #- WARNING: below would need the promotion of "b" (obsoleting bb) to work urpmi("--media $name-2 $option --auto c"); check_installed_fullnames_and_remove('c-2-1'); # a and bb are removed } -- cgit v1.2.1