aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPascal Rigaux <pixel@mandriva.com>2008-05-06 15:04:01 +0000
committerPascal Rigaux <pixel@mandriva.com>2008-05-06 15:04:01 +0000
commit8d2413e9dda1808dbb1fdd477fe3b4a1c6c43b58 (patch)
tree1859f5cb6c01a02b8204e86498bcee70c8412da2
parent69c24794075043e4898aeadf1b93e6c6e728699b (diff)
downloadspec-helper-8d2413e9dda1808dbb1fdd477fe3b4a1c6c43b58.tar
spec-helper-8d2413e9dda1808dbb1fdd477fe3b4a1c6c43b58.tar.gz
spec-helper-8d2413e9dda1808dbb1fdd477fe3b4a1c6c43b58.tar.bz2
spec-helper-8d2413e9dda1808dbb1fdd477fe3b4a1c6c43b58.tar.xz
spec-helper-8d2413e9dda1808dbb1fdd477fe3b4a1c6c43b58.zip
fix *old* typo, but keep current behaviour anyway
(we would have noticed if the missing --strip-unneeded was breaking libs)
-rwxr-xr-xstrip_files13
1 files changed, 2 insertions, 11 deletions
diff --git a/strip_files b/strip_files
index 336b2ff..43ab258 100755
--- a/strip_files
+++ b/strip_files
@@ -23,20 +23,11 @@ $exclude_pattern = qr/$exclude_pattern/;
my (@shared_libs, @executables, @static_libs);
find(\&testfile, $buildroot);
-# Note that all calls to strip on shared libs *must* include the
-# --strip-unneeded.
system(
"strip",
"--remove-section=.comment",
"--remove-section=.note",
- "--strip-unneeded",
- $_) foreach @shared_libs;
-
-system(
- "strip",
- "--remove-section=.comment",
- "--remove-section=.note",
- $_) foreach @executables;
+ $_) foreach @shared_libs, @executables;
# TODO: we should write a binding for libfile...
sub expensive_test {
@@ -59,7 +50,7 @@ sub testfile() {
if (m/\.so/) {
# Ok, do the expensive test.
if (expensive_test($_) =~ m/ELF.*shared/) {
- push @executables, $File::Find::name;
+ push @shared_libs, $File::Find::name;
return;
}
}