From 0a25ba446c1cb47a21b3f6056a10c90fea630c6f Mon Sep 17 00:00:00 2001
From: Olav Vitters <olav@vitters.nl>
Date: Sat, 25 Jul 2020 20:19:44 +0200
Subject: add-group: ShellCheck: fix various quoting issues

---
 add-group | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/add-group b/add-group
index 4ecc350..3e8d967 100755
--- a/add-group
+++ b/add-group
@@ -20,8 +20,8 @@ num=$2				# number of packages installed
 name=$3				# name of the group
 users=$4			# users to add to this group
 
-if ! getent group $name > /dev/null 2>&1; then
-    /usr/sbin/groupadd -r $name > /dev/null
+if ! getent group "$name" > /dev/null 2>&1; then
+    /usr/sbin/groupadd -r "$name" > /dev/null
 
     if [ -n "$users" ]; then
 	SAVED_IFS="$IFS"
@@ -30,11 +30,11 @@ if ! getent group $name > /dev/null 2>&1; then
 	IFS="$SAVED_IFS"
 
 	for u in $*; do
-	    old=`egrep "[:,]$u(,|$)" /etc/group | cut -d : -f 1 | xargs echo`
+	    old=$(grep -E "[:,]$u(,|$)" /etc/group | cut -d : -f 1 | xargs echo)
 	    if [ -n "$old" ]; then
-		old=`echo ",$old" | sed 's/ /,/g'`
+		old=$(echo ",$old" | sed 's/ /,/g')
 	    fi
-	    /usr/sbin/usermod -G $name$old $u > /dev/null
+	    /usr/sbin/usermod -G "$name$old" "$u" > /dev/null
 	done
     fi
 fi
-- 
cgit v1.2.1