| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
fix by Panu Matilainen
When rpmlog() occurs, it now grabs a read/write lock on the log context
depending on whether it needs to save the log or not. The callback
executes while the context lock is held, so when one call
rpmlogMessage() or pretty much any rpmlog-related function from the
callback, it'll try to lock the context again. Which is okay as long as
rpmlog() only needed a read-lock on the context. However if it has a
write-lock then attempting to grab a read-lock for rpmlogMessage()
fails, but due to the largely missing error handling in rpmlog.c it
falls through to crash and burn.
The only reason we need to call rpmlogMessage() is that the callback
does not match the callback function type in rpm >= 4.6:
typedef int (*rpmlogCallback) (rpmlogRec rec, rpmlogCallbackData data);
We shouldn't call that from log callback.
We can avoid the issue by using rpmlogRecMessage() instead of
rpmlogMessage() inside the callback. These are not the same,
rpmlogRecMessage() returns the message of the *current* log event,
whereas rpmlogMessage() returns the last *saved* log event. Which might
not exist, might be from an earlier event or it might be the current
event.
...and it'll not only work in all rpm >= 4.6 versions, but also give
the actual log message at hand, instead of something that might have
happened in the past.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
Veuillez saisir le message de validation pour vos modifications. Les lignes
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
aka having @recommends@ lines instead of @suggests@ ones
|
| |
|
|
|
|
|
| |
in order to reflect reality
but keep a suggests alias for compatibility for the time being
|
|
|
|
| |
as this really what it is
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
rpm-4.12.0 introduces a new weak deps implementation (the 3rd one to be
used in mdv/mga!)
The tag we used to use (RPMTAG_SUGGESTSNAME) is now OLDSUGGESTSNAME
=> we need to handle both old & new tags
Hopefully rpm-4.12.x enables to check both old & new tags when using
xxxNVRS variants
We thus have a choice between RECOMMEND & SUGGEST tags, that both
fallback on older SUGGESTS tags if no new ones are found.
The difference is that they filter old suggests depending on
RPMSENSE_STRONG hint.
As we used suggests in the recommends role, this is the perfect time to
switch from suggests to recommends
(with a patch on rpm in order to fallback RECOMMEND on weak (old)
SUGGESTS instead of on strong (old) ENHANCES as we didn't used the later
in mga)
Our rpm is patched so that RECOMMENDNAME fallbacks too.
In Suse, only RECOMMENDNEVRS is the only RECOMMEND variant that handle
the fallback on old tags.
However, using RPMTAG_RECOMMENDNEVRS makes URPM->suggest_nosense to
return versionated suggests, which while not supported by urpmi, do are
used by a couple packages (such as git or gnome-user-share)
This breaks urpmi as suggests on "foo >= x.y" is not interpreted by
urpmi which thinks that "foo" is a new suggests and reinstalls a
previously removed suggests
Hence we patched rpm.
|
|
|
|
|
| |
in order to access to extension tags such as new weak deps tags
(needed for next commit)
|
| |
|
|
|
|
|
|
| |
suggests to use compare_pkg instead
(needs a new rpmdrake)
|
|
|
|
|
|
|
|
|
|
|
| |
its return value is now always ()
rationale: resolve_rejected() was wrong, since it blindly removes
installed pkgs w/o trying to promote anything and @diff_provides can be
nicely used to handle rejecting package one by one, then
_handle_diff_provides() should do the right job.
(spot by perl_checker)
|
|
|
|
| |
We don't have those since 2004 (10 years+)...
|
| |
|
|
|
|
| |
they're obsolete since switching to git
|
|
|
|
|
| |
present since commit 74c3cfe40e76d2cf047e7cbc57653298a460b658
(12 years ago...)
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
this broke installing 32 bit kernel for drakx-installer-binaries
(spotted by Pascal Terjan)
|
| |
|
| |
|
|
|
|
|
|
|
| |
'Argument "19697|19..." isn't numeric in array element at ...URPM/Resolve.pm'
introduced by pixel in commit 1d945d2a483598dc982cf73ae932d83d4e35df9
on Sep 7 2007 ("add some debug messages)
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
why didn't you document it when you introduced them (pascal & rafael)?
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
(for rpmdrake --env)
|
| |
|
|
|
|
| |
"fd" is passed to a parameter that cannot be negative.
|
|
|
|
|
| |
'leaked_storage: Variable "foo" going out of scope leaks the storage it
points to.'
|
|
|
|
|
| |
'Pointer "foo" returned by "_free(foo)" is never used'
(improve coverity scan's SNR)
|