aboutsummaryrefslogtreecommitdiffstats
path: root/URPM
diff options
context:
space:
mode:
authorOlivier Thauvin <nanardon@mandriva.org>2010-07-30 00:55:59 +0000
committerOlivier Thauvin <nanardon@mandriva.org>2010-07-30 00:55:59 +0000
commit57c70584abaa14f93fcf104e4b83d9821bfd5995 (patch)
tree1c02c60ecef9b3c1729bb47bda41b909614e8c3e /URPM
parent7bc27f76a81245ee8d201587b8031160d8dfbce5 (diff)
downloadperl-URPM-57c70584abaa14f93fcf104e4b83d9821bfd5995.tar
perl-URPM-57c70584abaa14f93fcf104e4b83d9821bfd5995.tar.gz
perl-URPM-57c70584abaa14f93fcf104e4b83d9821bfd5995.tar.bz2
perl-URPM-57c70584abaa14f93fcf104e4b83d9821bfd5995.tar.xz
perl-URPM-57c70584abaa14f93fcf104e4b83d9821bfd5995.zip
- enable 'use warnings'
- fix some warnings
Diffstat (limited to 'URPM')
-rw-r--r--URPM/Build.pm1
-rw-r--r--URPM/Query.pm1
-rw-r--r--URPM/Resolve.pm4
-rw-r--r--URPM/Signature.pm1
4 files changed, 6 insertions, 1 deletions
diff --git a/URPM/Build.pm b/URPM/Build.pm
index 18f3faee..042e4c9 100644
--- a/URPM/Build.pm
+++ b/URPM/Build.pm
@@ -3,6 +3,7 @@ package URPM;
# $Id$
use strict;
+use warnings;
sub _get_tmp_dir () {
my $t = $ENV{TMPDIR};
diff --git a/URPM/Query.pm b/URPM/Query.pm
index 5b62f11..6f58552 100644
--- a/URPM/Query.pm
+++ b/URPM/Query.pm
@@ -1,6 +1,7 @@
package URPM;
use strict;
+use warnings;
# Olivier Thauvin <thauvin@aerov.jussieu.fr>
# This package extend URPM functions to permit
diff --git a/URPM/Resolve.pm b/URPM/Resolve.pm
index 7e38db8..4090313 100644
--- a/URPM/Resolve.pm
+++ b/URPM/Resolve.pm
@@ -5,6 +5,7 @@ package URPM;
# $Id$
use strict;
+use warnings;
use Config;
@@ -435,7 +436,8 @@ sub _choose_required {
sub pkg2media {
my ($mediums, $p) = @_;
my $id = $p->id;
- find { $id >= $_->{start} && $id <= $_->{end} } @$mediums;
+ #- || 0 to avoid undef, but is it normal to have undef ?
+ find { $id >= ($_->{start} || 0) && $id <= ($_->{end} || 0) } @$mediums;
}
sub whatrequires {
diff --git a/URPM/Signature.pm b/URPM/Signature.pm
index 0c2eda0..b050f91 100644
--- a/URPM/Signature.pm
+++ b/URPM/Signature.pm
@@ -1,6 +1,7 @@
package URPM;
use strict;
+use warnings;
#- parse from rpmlib db.
#-