aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorThierry Vignaud <thierry.vignaud@gmail.com>2017-10-05 12:16:23 +0200
committerThierry Vignaud <thierry.vignaud@gmail.com>2017-10-05 12:30:39 +0200
commit2f99457c2fbd8cad7ddb77ae4063e4e79b67e561 (patch)
tree52ef0b96d8c7ee8fd5c331e784850ca349d168ac
parente94a137df18868149a7866e764fedf9e255d50ca (diff)
downloadperl-URPM-2f99457c2fbd8cad7ddb77ae4063e4e79b67e561.tar
perl-URPM-2f99457c2fbd8cad7ddb77ae4063e4e79b67e561.tar.gz
perl-URPM-2f99457c2fbd8cad7ddb77ae4063e4e79b67e561.tar.bz2
perl-URPM-2f99457c2fbd8cad7ddb77ae4063e4e79b67e561.tar.xz
perl-URPM-2f99457c2fbd8cad7ddb77ae4063e4e79b67e561.zip
Revert "fix segfault when checking invalid signatures"
This reverts commit 87dbde4f3b078173e53cd45cac000c2d2751b370. Rationale: rpm got fixed We could just initialize header to NULL but rpmReadPackageFile() is supposed to always set a correct value, so keep as it in order to catch another future perl regression
-rw-r--r--NEWS3
-rw-r--r--URPM.xs2
2 files changed, 4 insertions, 1 deletions
diff --git a/NEWS b/NEWS
index feb794e..64253d4 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,6 @@
+- revert fix for segfault with rpm-4.14 when checking invalid signatures as rpm
+ got fixed
+
Version 5.15 - 3 October 2017
- testsuite:
diff --git a/URPM.xs b/URPM.xs
index cf2eac6..8926770 100644
--- a/URPM.xs
+++ b/URPM.xs
@@ -3136,7 +3136,7 @@ Urpm_verify_signature(filename, prefix=NULL)
char result[1024];
rpmRC rc;
FD_t fd;
- Header h = headerNew();
+ Header h;
CODE:
fd = Fopen(filename, "r");
if (fd == NULL)