From ecbceb20b7a21d5a31108e24106d162622044924 Mon Sep 17 00:00:00 2001 From: Pascal Rigaux Date: Wed, 17 Nov 2004 12:23:28 +0000 Subject: warn unneeded ";" after some blocks --- perl_checker.src/test/force_layout.t | 3 +++ perl_checker.src/test/test_it | 4 +++- 2 files changed, 6 insertions(+), 1 deletion(-) (limited to 'perl_checker.src/test') diff --git a/perl_checker.src/test/force_layout.t b/perl_checker.src/test/force_layout.t index 0ebd202..bb5494e 100644 --- a/perl_checker.src/test/force_layout.t +++ b/perl_checker.src/test/force_layout.t @@ -18,3 +18,6 @@ if ($xxx) { missing ";" xxx() } +if ($xxx) { unneeded ";" + xxx(); +}; diff --git a/perl_checker.src/test/test_it b/perl_checker.src/test/test_it index 85214b7..fc2e70f 100755 --- a/perl_checker.src/test/test_it +++ b/perl_checker.src/test/test_it @@ -65,7 +65,9 @@ foreach my $test (@tests) { if ($l[-1] !~ /(;|[\s{]\})\s+$/) { $l[-1] =~ s/^(.*?)(\s+$)/xxx($1);$2/; } else { - $l[-1] =~ s/(\s+$)/; nop();$1/; + my $no_comma = $l[-1] =~ /(^\s*(for|foreach|if|unless|while|sub)\s)|(;\s+$)/; + my $opt_comma = $no_comma ? '' : ';'; + $l[-1] =~ s/(\s+$)/$opt_comma nop();$1/; } } if (! any { /^(sub|use) / } @l) { -- cgit v1.2.1