diff options
author | Pascal Rigaux <pixel@mandriva.com> | 2004-08-11 06:11:14 +0000 |
---|---|---|
committer | Pascal Rigaux <pixel@mandriva.com> | 2004-08-11 06:11:14 +0000 |
commit | 7f39fecd77b6af4ffa303ab4109fad4a0ceaf91a (patch) | |
tree | 4bb91ba6f717a89b40a50cef13ec9639db8d4ea9 /perl_checker.src/test | |
parent | 4d71de6ae45fc48b361dbce0f782c5d57791248c (diff) | |
download | perl_checker-7f39fecd77b6af4ffa303ab4109fad4a0ceaf91a.tar perl_checker-7f39fecd77b6af4ffa303ab4109fad4a0ceaf91a.tar.gz perl_checker-7f39fecd77b6af4ffa303ab4109fad4a0ceaf91a.tar.bz2 perl_checker-7f39fecd77b6af4ffa303ab4109fad4a0ceaf91a.tar.xz perl_checker-7f39fecd77b6af4ffa303ab4109fad4a0ceaf91a.zip |
suggest better for !($foo == $bar) (same for eq, != and ne)
Diffstat (limited to 'perl_checker.src/test')
-rw-r--r-- | perl_checker.src/test/suggest_better.t | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/perl_checker.src/test/suggest_better.t b/perl_checker.src/test/suggest_better.t index 58a1308..caa3677 100644 --- a/perl_checker.src/test/suggest_better.t +++ b/perl_checker.src/test/suggest_better.t @@ -62,6 +62,10 @@ member($xxx, keys %h) you can replace "member($xxx, keys %yyy !($xxx =~ /.../) !($var =~ /.../) is better written $var !~ /.../ +!($xxx == 1) !($foo == $bar) is better written $foo != $bar + +!($xxx eq 'foo') !($foo eq $bar) is better written $foo ne $bar + foreach (@l) { use "push @l2, grep { ... } ..." instead of "foreach (...) { push @l2, $_ if ... }" push @l2, $_ if yyy($_); or sometimes "@l2 = grep { ... } ..." } |