diff options
| author | Pascal Rigaux <pixel@mandriva.com> | 2004-10-13 04:45:02 +0000 |
|---|---|---|
| committer | Pascal Rigaux <pixel@mandriva.com> | 2004-10-13 04:45:02 +0000 |
| commit | d1ec317d8b4153158bf12d79bfec0a581b7817db (patch) | |
| tree | c7be44277c88565c1ab4350d535849c5e642e9aa | |
| parent | e6798126b96281772d88475d1addfe53f30e42d2 (diff) | |
| download | perl_checker-d1ec317d8b4153158bf12d79bfec0a581b7817db.tar perl_checker-d1ec317d8b4153158bf12d79bfec0a581b7817db.tar.gz perl_checker-d1ec317d8b4153158bf12d79bfec0a581b7817db.tar.bz2 perl_checker-d1ec317d8b4153158bf12d79bfec0a581b7817db.tar.xz perl_checker-d1ec317d8b4153158bf12d79bfec0a581b7817db.zip | |
- check push arguments
- add a test for pop arguments
| -rw-r--r-- | perl_checker.src/parser_helper.ml | 7 | ||||
| -rw-r--r-- | perl_checker.src/test/various_errors.t | 8 |
2 files changed, 15 insertions, 0 deletions
diff --git a/perl_checker.src/parser_helper.ml b/perl_checker.src/parser_helper.ml index 0be9353..858dd80 100644 --- a/perl_checker.src/parser_helper.ml +++ b/perl_checker.src/parser_helper.ml @@ -910,6 +910,13 @@ let call_raw force_non_builtin_func (e, para) = | [ List [ Deref(I_array, _) ] ] -> () | _ -> warn_rule (f ^ " is expecting an array and nothing else")) + | "push" | "unshift" -> + (match para with + | Deref(I_array, _) :: l + | [ List (Deref(I_array, _) :: l) ] -> + if l = [] then warn_rule ("you must give some arguments to " ^ f) + | _ -> warn_rule (f ^ " is expecting an array")) + | "system" -> (match un_parenthesize_full_l para with | [ String(l, _) ] -> diff --git a/perl_checker.src/test/various_errors.t b/perl_checker.src/test/various_errors.t index af21eb4..901612f 100644 --- a/perl_checker.src/test/various_errors.t +++ b/perl_checker.src/test/various_errors.t @@ -25,6 +25,14 @@ join(@l) first argument of join() must be a scal join(',', 'foo') join('...', $foo) is the same as $foo +push @l you must give some arguments to push + +push $xxx, 1 push is expecting an array + +pop @l, 1 pop is expecting an array and nothing else + +pop $xxx pop is expecting an array and nothing else + system(qq(foo "$xxx")) instead of quoting parameters you should give a list of arguments my (@l2, $xxx) = @l; @l2 takes all the arguments, $xxx is undef in any case |