From 1a5b978da98890aab1ff1d6200ca290e1bab0dc8 Mon Sep 17 00:00:00 2001
From: Pascal Rigaux <pixel@mandriva.com>
Date: Tue, 14 Aug 2001 13:54:48 +0000
Subject: new check: "using $_ in a sub is generally bad news"

---
 perl_checker | 4 ++++
 1 file changed, 4 insertions(+)

(limited to 'perl_checker')

diff --git a/perl_checker b/perl_checker
index d1cd082..fe94764 100755
--- a/perl_checker
+++ b/perl_checker
@@ -63,6 +63,10 @@ if (/\blocal\b.*\|\|=/) {
     err(q(never use ``local $var ||= <val>'', write ``local $var = $var || <val>''), info());
 }
 
+if (/\bsub\b\s*\{[^{}]*\$_(?!\[)/) {
+    warn_(q(using $_ in a sub is generally bad news), info()) if !/local\s+\$_/;
+}
+
 if (/^\s*package ([\w:]+)/) {
     $package = $1;
     $path{$package} ||= ($ARGV =~ m|(.*/)|)[0];
-- 
cgit v1.2.1