From 6c1fa5cd83b0d46528ee8cecda42f9b1adca0b32 Mon Sep 17 00:00:00 2001 From: Thierry Vignaud Date: Mon, 18 Nov 2013 15:41:22 +0100 Subject: use (my|u)gtk3 instead of *tk2 --- mgaapplet | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) (limited to 'mgaapplet') diff --git a/mgaapplet b/mgaapplet index 967b0889..4597687f 100755 --- a/mgaapplet +++ b/mgaapplet @@ -31,8 +31,8 @@ use feature 'state'; BEGIN { unshift @::textdomains, 'mgaonline' } -use mygtk2 qw(gtknew); #- do not import gtkadd which conflicts with ugtk2 version -use ugtk2 qw(:all); +use mygtk3 qw(gtknew); #- do not import gtkadd which conflicts with ugtk2 version +use ugtk3 qw(:all); use lib qw(/usr/lib/libDrakX/drakfirsttime); use mgaonline; use mgaapplet_gui; @@ -262,7 +262,7 @@ run_program::raw({ detach => 1 }, 'ionice', '-p', $$, '-n7'); Gtk2->main; -ugtk2::exit(0); +ugtk3::exit(0); sub gnome_shell_exit_overview() { eval { Net::DBus->session->get_service('org.gnome.Shell')->get_object('/org/gnome/Shell', 'org.freedesktop.DBus.Properties')->Set('org.gnome.Shell', 'OverviewActive', dbus_boolean(0)) }; @@ -384,7 +384,7 @@ sub configNetwork() { } sub confirm_upgrade() { - local $mygtk2::left_padding = 0; + local $mygtk3::left_padding = 0; my $warn_me = text2bool($local_config{DO_NOT_ASK_FOR_DISTRO_UPGRADE}); my $w = new_portable_dialog(N("New version of Mageia distribution")); my ($temp_dir, $box); @@ -453,7 +453,7 @@ sub refresh_no_more_supported_msg() { } sub no_more_supported_choice() { - local $mygtk2::left_padding = 0; + local $mygtk3::left_padding = 0; my $warn_me = text2bool($local_config{DO_NOT_ASK_FOR_NO_MORE_SUPPORTED}); # FIXME: just tell radio buttons' children to wrap instead: local $mgaapplet_gui::width = 580; @@ -522,8 +522,8 @@ sub no_more_supported() { } sub really_confirm_upgrade() { - local $mygtk2::left_padding = 0; - my $w = ugtk2->new(N("New version of Mageia distribution"), width => $width + 20); + local $mygtk3::left_padding = 0; + my $w = ugtk3->new(N("New version of Mageia distribution"), width => $width + 20); # estimated package size: my $c; -- cgit v1.2.1 From 9566b9f9abbb375d73bb583191502b0859507665 Mon Sep 17 00:00:00 2001 From: Thierry Vignaud Date: Mon, 18 Nov 2013 15:41:22 +0100 Subject: use Gtk3 namespace instead of Gtk2 --- mgaapplet | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) (limited to 'mgaapplet') diff --git a/mgaapplet b/mgaapplet index 4597687f..11c593d9 100755 --- a/mgaapplet +++ b/mgaapplet @@ -36,7 +36,7 @@ use ugtk3 qw(:all); use lib qw(/usr/lib/libDrakX/drakfirsttime); use mgaonline; use mgaapplet_gui; -use Gtk2::Notify '-init', 'mgaapplet'; +use Gtk3::Notify '-init', 'mgaapplet'; use Net::DBus qw(:typing); use Rpmdrake::open_db; @@ -203,7 +203,7 @@ my %actions = ( 'upgrade_distro' => { name => N("Upgrade the system"), launch => \&upgrade }, ); -my $icon = Gtk2::StatusIcon->new; +my $icon = Gtk3::StatusIcon->new; #$icon->shape_combine_mask($img, 0, 0); $icon->signal_connect(popup_menu => sub { my ($_icon, $button, $time) = @_; @@ -260,7 +260,7 @@ $SIG{HUP} = \&restart_applet; run_program::raw({ detach => 1 }, 'ionice', '-p', $$, '-n7'); -Gtk2->main; +Gtk3->main; ugtk3::exit(0); @@ -391,7 +391,7 @@ sub confirm_upgrade() { my $browse; $browse = gtksignal_connect( - Gtk2::FileChooserButton->new(N("Browse"), 'select-folder'), + Gtk3::FileChooserButton->new(N("Browse"), 'select-folder'), 'current-folder-changed' => sub { $temp_dir = $_[0]->get_current_folder; my $ok = -d $temp_dir && ! -l $temp_dir && ((stat($temp_dir))[4] == 0); @@ -793,8 +793,8 @@ sub setState { gtkflush(); # so that bubbles are displayed on right icon - if ($state{$state}{tt}[0] && $icon->isa('Gtk2::StatusIcon') && !$state{$state}{do_not_use_bubble}) { - my $bubble = Gtk2::Notify->new(N("Warning"), formatAlaTeX(translate($state{$state}{tt}[0])) . "\n", + if ($state{$state}{tt}[0] && $icon->isa('Gtk3::StatusIcon') && !$state{$state}{do_not_use_bubble}) { + my $bubble = Gtk3::Notify->new(N("Warning"), formatAlaTeX(translate($state{$state}{tt}[0])) . "\n", '/usr/share/icons/mgaonline.png'); if ($state eq 'new_distribution') { $bubble->add_action('clicked', N("More Information"), \&upgrade); @@ -818,20 +818,20 @@ sub setState { eval { $bubble->show }; } - my $menu = Gtk2::Menu->new; + my $menu = Gtk3::Menu->new; foreach (@arr) { my $action = $actions{$_}; next if !ref($action->{launch}); - $menu->append(gtksignal_connect(gtkshow(Gtk2::MenuItem->new_with_label($action->{name})), activate => $action->{launch})); + $menu->append(gtksignal_connect(gtkshow(Gtk3::MenuItem->new_with_label($action->{name})), activate => $action->{launch})); } - $menu->append(gtkshow(Gtk2::SeparatorMenuItem->new)); - $menu->append(gtksignal_connect(gtkshow(Gtk2::MenuItem->new_with_label(N("About..."))), + $menu->append(gtkshow(Gtk3::SeparatorMenuItem->new)); + $menu->append(gtksignal_connect(gtkshow(Gtk3::MenuItem->new_with_label(N("About..."))), activate => \&about_dialog)); - $menu->append(gtksignal_connect(gtkshow(Gtk2::MenuItem->new_with_label(N("Updates Configuration"))), + $menu->append(gtksignal_connect(gtkshow(Gtk3::MenuItem->new_with_label(N("Updates Configuration"))), activate => sub { run_program::raw({ detach => 1 }, 'mgaapplet-config') })); - $menu->append(gtksignal_connect(gtkset_active($checkme = Gtk2::CheckMenuItem->new_with_label(N("Always launch on startup")), shouldStart()), toggled => sub { setAutoStart(uc(bool2text($checkme->get_active))) })); + $menu->append(gtksignal_connect(gtkset_active($checkme = Gtk3::CheckMenuItem->new_with_label(N("Always launch on startup")), shouldStart()), toggled => sub { setAutoStart(uc(bool2text($checkme->get_active))) })); $checkme->show; - $menu->append(gtksignal_connect(gtkshow(Gtk2::MenuItem->new_with_label(N("Quit"))), activate => sub { mainQuit() })); + $menu->append(gtksignal_connect(gtkshow(Gtk3::MenuItem->new_with_label(N("Quit"))), activate => sub { mainQuit() })); $menu; } @@ -852,5 +852,5 @@ sub mainQuit() { # setAutoStart('FALSE'); Glib::Source->remove($timeout) if $timeout; Glib::Source->remove($network_timeout) if $network_timeout; - Gtk2->main_quit; + Gtk3->main_quit; } -- cgit v1.2.1 From 19cc1b3c65db87e87cb2894049be6f39ac5d880b Mon Sep 17 00:00:00 2001 From: Thierry Vignaud Date: Mon, 18 Nov 2013 15:41:22 +0100 Subject: perlish ->child() => ->get_child() --- mgaapplet | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'mgaapplet') diff --git a/mgaapplet b/mgaapplet index 11c593d9..0ed55ba3 100755 --- a/mgaapplet +++ b/mgaapplet @@ -490,9 +490,9 @@ sub no_more_supported_choice() { # explicitely wrap too long message: foreach ($b1, $b2) { - next if !$_ || !$_->child; - $_->child->set_line_wrap(1); - $_->child->set_size_request($width-50, -1); + next if !$_ || !$_->get_child; + $_->get_child->set_line_wrap(1); + $_->get_child->set_size_request($width-50, -1); } my $res = fill_n_run_portable_dialog($w, \@widgets); -- cgit v1.2.1 From 662fed93f191842def9ac175bceca0aad4c82cfb Mon Sep 17 00:00:00 2001 From: Thierry Vignaud Date: Thu, 5 Dec 2013 14:28:32 +0100 Subject: use new Toolbar API --- mgaapplet | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'mgaapplet') diff --git a/mgaapplet b/mgaapplet index 0ed55ba3..56c697b2 100755 --- a/mgaapplet +++ b/mgaapplet @@ -782,7 +782,7 @@ sub setState { my @arr = @{$state{$state}{menu}}; my $tmp = eval { gtkcreate_pixbuf($state{$state}{colour}[0]) }; $icon->set_from_pixbuf($tmp) if $tmp; - $icon->set_tooltip(formatAlaTeX(translate($state{$state}{tt}[0]))); + $icon->set_tooltip_text(formatAlaTeX(translate($state{$state}{tt}[0]))); my @invisible_states = qw(delayed okay disconnected locked); $icon->set_visible(!member($state, @invisible_states)); -- cgit v1.2.1 From 61563398324066693ec8d07b4f39b0fcc474ea87 Mon Sep 17 00:00:00 2001 From: Thierry Vignaud Date: Fri, 6 Dec 2013 12:09:43 +0100 Subject: s/gtk2/gtk3/ in comments --- mgaapplet | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'mgaapplet') diff --git a/mgaapplet b/mgaapplet index 56c697b2..9f57055c 100755 --- a/mgaapplet +++ b/mgaapplet @@ -31,7 +31,7 @@ use feature 'state'; BEGIN { unshift @::textdomains, 'mgaonline' } -use mygtk3 qw(gtknew); #- do not import gtkadd which conflicts with ugtk2 version +use mygtk3 qw(gtknew); #- do not import gtkadd which conflicts with ugtk3 version use ugtk3 qw(:all); use lib qw(/usr/lib/libDrakX/drakfirsttime); use mgaonline; -- cgit v1.2.1 From 9a495b20b7a790ca6ff70e2f78877881ac002856 Mon Sep 17 00:00:00 2001 From: Thierry Vignaud Date: Fri, 6 Dec 2013 12:09:45 +0100 Subject: Gtk3::Notify->new => Gtk3::Notify::Notification->new (mga#11897) --- mgaapplet | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'mgaapplet') diff --git a/mgaapplet b/mgaapplet index 9f57055c..35b7cec7 100755 --- a/mgaapplet +++ b/mgaapplet @@ -794,7 +794,7 @@ sub setState { gtkflush(); # so that bubbles are displayed on right icon if ($state{$state}{tt}[0] && $icon->isa('Gtk3::StatusIcon') && !$state{$state}{do_not_use_bubble}) { - my $bubble = Gtk3::Notify->new(N("Warning"), formatAlaTeX(translate($state{$state}{tt}[0])) . "\n", + my $bubble = Gtk3::Notify::Notification->new(N("Warning"), formatAlaTeX(translate($state{$state}{tt}[0])) . "\n", '/usr/share/icons/mgaonline.png'); if ($state eq 'new_distribution') { $bubble->add_action('clicked', N("More Information"), \&upgrade); -- cgit v1.2.1 From 41c40e07845517dae1133a6c17586a16003a7d8a Mon Sep 17 00:00:00 2001 From: Thierry Vignaud Date: Mon, 16 Dec 2013 10:22:28 +0100 Subject: icons were redone by mga --- mgaapplet | 1 - 1 file changed, 1 deletion(-) (limited to 'mgaapplet') diff --git a/mgaapplet b/mgaapplet index 35b7cec7..6f512f99 100755 --- a/mgaapplet +++ b/mgaapplet @@ -763,7 +763,6 @@ sub about_dialog() { website => $url, website_label => N("Online WebSite"), authors => 'Thierry Vignaud ', - artists => 'Hélène Durosini', translator_credits => #-PO: put here name(s) and email(s) of translator(s) (eg: "John Smith ") N("_: Translator(s) name(s) & email(s)\n"), -- cgit v1.2.1 From 11da5efc0519fa287935aa5f0867bd8464e8b59b Mon Sep 17 00:00:00 2001 From: Thierry Vignaud Date: Mon, 16 Dec 2013 10:28:40 +0100 Subject: fix crashing when displaying about dialog (mga#12009) set_authors() needs an array ref with Gtk3 --- mgaapplet | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'mgaapplet') diff --git a/mgaapplet b/mgaapplet index 6f512f99..1fef7e38 100755 --- a/mgaapplet +++ b/mgaapplet @@ -762,7 +762,7 @@ sub about_dialog() { comments => N("Mageia Online gives access to Mageia web services."), website => $url, website_label => N("Online WebSite"), - authors => 'Thierry Vignaud ', + authors => [ 'Thierry Vignaud ' ], translator_credits => #-PO: put here name(s) and email(s) of translator(s) (eg: "John Smith ") N("_: Translator(s) name(s) & email(s)\n"), -- cgit v1.2.1 From 4bfd0b9c84baa0d380e15f051984058c6c9adcf0 Mon Sep 17 00:00:00 2001 From: Thierry Vignaud Date: Mon, 16 Dec 2013 10:30:18 +0100 Subject: fix my email --- mgaapplet | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'mgaapplet') diff --git a/mgaapplet b/mgaapplet index 1fef7e38..43a2f863 100755 --- a/mgaapplet +++ b/mgaapplet @@ -5,7 +5,7 @@ # Copyright (C) 2003-2010 Mandriva # # # # Daouda Lo # -# Thierry Vignaud # +# Thierry Vignaud # # # # This program is free software; you can redistribute it and/or modify # # it under the terms of the GNU General Public License Version 2 as # @@ -762,7 +762,7 @@ sub about_dialog() { comments => N("Mageia Online gives access to Mageia web services."), website => $url, website_label => N("Online WebSite"), - authors => [ 'Thierry Vignaud ' ], + authors => [ 'Thierry Vignaud ' ], translator_credits => #-PO: put here name(s) and email(s) of translator(s) (eg: "John Smith ") N("_: Translator(s) name(s) & email(s)\n"), -- cgit v1.2.1 From 1455583f43808bc43fb0ade94aa770e84f62276f Mon Sep 17 00:00:00 2001 From: Thierry Vignaud Date: Sat, 21 Dec 2013 02:04:00 +0100 Subject: split mgaapplet module (needed for next commit) --- mgaapplet | 38 +------------------------------------- 1 file changed, 1 insertion(+), 37 deletions(-) (limited to 'mgaapplet') diff --git a/mgaapplet b/mgaapplet index 43a2f863..77b6f6dd 100755 --- a/mgaapplet +++ b/mgaapplet @@ -35,6 +35,7 @@ use mygtk3 qw(gtknew); #- do not import gtkadd which conflicts with ugtk3 versio use ugtk3 qw(:all); use lib qw(/usr/lib/libDrakX/drakfirsttime); use mgaonline; +use mgaapplet; use mgaapplet_gui; use Gtk3::Notify '-init', 'mgaapplet'; use Net::DBus qw(:typing); @@ -158,43 +159,6 @@ Then, restart \"%s\".", N("Enabled"), 'mgaapplet') ], }, ); -my %comm_codes = ( - locked => { - code => 2, - status => 'locked', - log => "urpmi database locked, skipping updating urpmi database", - }, - error_updating => { - code => 3, - status => 'critical', - log => N_("Error updating media"), - }, - no_update_medium => { - code => 4, - status => 'no_update_medium', - log => "no update media configured", - }, - no_enabled_medium => { - code => 5, - status => 'no_enabled_medium', - log => "all update media are disabled", - }, - updates => { - code => 6, - status => 'updates', - log => "Checking... Updates are available\n\n", - }, - uptodate => { - code => 7, - status => 'okay', - log => "Packages are up to date\n", - }, - db_not_open => { - code => 8, - status => 'critical', - log => "Failed to open urpmi database\n", - }, -); my %actions = ( 'update' => { name => N("Install updates"), launch => \&installUpdates }, -- cgit v1.2.1 From 858573ca6bf57cae345d2047c7a79e2da6a7d345 Mon Sep 17 00:00:00 2001 From: Thierry Vignaud Date: Sat, 21 Dec 2013 02:05:57 +0100 Subject: split mgaapplet-update-checker since we cannot prevent glib/gtk to spawn threads behind our back, we can at least try to prevent segfaults due to mixing threads with secular forks by exec()ing immediately --- mgaapplet | 95 ++------------------------------------------------------------- 1 file changed, 2 insertions(+), 93 deletions(-) (limited to 'mgaapplet') diff --git a/mgaapplet b/mgaapplet index 77b6f6dd..ede55a51 100755 --- a/mgaapplet +++ b/mgaapplet @@ -552,22 +552,6 @@ sub installUpdates() { silentCheck(); gtkflush(); } -sub checker_exit { - my ($state) = @_; - POSIX::_exit($comm_codes{$state}{code}); -} - -sub update_backport_media { - my ($urpm) = @_; - # update inactive backport media: - my @inactive_backport_media = Rpmdrake::open_db::get_inactive_backport_media($urpm); - return if !@inactive_backport_media; - log::explanations("updating inactive backport media " . join(', ', @inactive_backport_media)); - foreach (@inactive_backport_media) { - run_program::run('urpmi.update', if_($root, "--urpmi-root=$root"), $_); - } -} - sub silentCheck() { state $check_time; my $new_time = time(); @@ -583,83 +567,8 @@ sub silentCheck() { # are there any updates ? - $checker_pid = fork(); - if (defined $checker_pid) { - return if $checker_pid; # parent - - # immediate exit, else forked gtk+ object destructors will badly catch up parent applet - my $_safe = before_leaving { - my $err = $@; - log::explanations("mgaapplet check crashed: $err "); - warn "Error: $err\n" . common::backtrace(); - POSIX::_exit(0); - }; - - # be nice with other processes: - setpriority(0, $$, 7); # 0 is PRIO_PROCESS - - my $will_not_update_media; - require urpm; - require urpm::lock; - # so that get_inactive_backport_media() doesn't vivify $urpm->{media}: - my $urpm = Rpmdrake::open_db::fast_open_urpmi_db(); - { - local $urpm->{fatal} = sub { - print "Fatal: @_\n"; - $will_not_update_media = 1; - }; - local $urpm->{error} = $urpm->{fatal}; - - urpm::lock::urpmi_db($urpm, 'exclusive', 1); - } - checker_exit('locked') if $will_not_update_media; - - my $is_it_a_devel_distro = is_it_a_devel_distro(); - - my $media = $is_it_a_devel_distro ? '-a' : '--update'; - if (!run_program::run('urpmi.update', $media, if_($root, "--urpmi-root=$root"))) { - checker_exit('error_updating') if $will_not_update_media; - } - - update_backport_media($urpm); - - require urpm::select; - require urpm::media; - # this eats 52Mb of RAM on 64bit: - # (hence we do it in the forked helper so that the applet doesn't eat too much RAM) - urpm::media::configure($urpm, if_(!$is_it_a_devel_distro, update => 1)); - - my @update_medias = get_update_medias($urpm); - - if (!@update_medias) { - checker_exit('no_update_medium'); - } elsif (!any { ! $_->{ignore} } @update_medias) { - checker_exit('no_enabled_medium'); - } - - if (my $_db = urpm::db_open_or_die($urpm)) { - my $requested = {}; - my $state = {}; - my $need_restart = urpm::select::resolve_dependencies( - $urpm, $state, $requested, - callback_choices => sub { 0 }, - priority_upgrade => $urpm->{options}{'priority-upgrade'}, - auto_select => 1, - ); - my @requested_strict = map { scalar $_->fullname } @{$urpm->{depslist}}[keys %{$state->{selected}}]; - - if ($need_restart || @requested_strict) { - # FIXME: log first found pkgs? - warn ">> need_restart=$need_restart, updates=" . join(', ', @requested_strict) . "\n"; - checker_exit('updates'); - } else { - checker_exit('uptodate'); - } - } else { - checker_exit('db_not_open'); - } - checker_exit('updates'); - } else { + $checker_pid = fork_exec('mgaapplet-update-checker', $root); + if (!$checker_pid) { log::explanations("cannot fork: %s", "update checker ($!)"); go2State('critical'); } -- cgit v1.2.1 From 95b9cd06f14a9817090584d72830df870c591acc Mon Sep 17 00:00:00 2001 From: Thierry Vignaud Date: Sat, 21 Dec 2013 03:17:55 +0100 Subject: fix doing nothing when clicking on notifications buttons (mga#12041) --- mgaapplet | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) (limited to 'mgaapplet') diff --git a/mgaapplet b/mgaapplet index ede55a51..ad66294d 100755 --- a/mgaapplet +++ b/mgaapplet @@ -669,25 +669,29 @@ sub setState { my $bubble = Gtk3::Notify::Notification->new(N("Warning"), formatAlaTeX(translate($state{$state}{tt}[0])) . "\n", '/usr/share/icons/mgaonline.png'); if ($state eq 'new_distribution') { - $bubble->add_action('clicked', N("More Information"), \&upgrade); + $bubble->add_action('upgrade', N("More Information2"), sub { upgrade(); Gtk3->main_quit }); + $bubble->signal_connect('closed' => \&Gtk3::main_quit); if ($sub_state eq 'updates') { push @arr, 'update'; } } elsif ($state eq 'no_more_supported') { - $bubble->add_action('clicked', N("More Information"), \&no_more_supported); + $bubble->add_action('no_more', N("More Information"), sub { no_more_supported(); Gtk3->main_quit }); + $bubble->signal_connect('closed' => \&Gtk3::main_quit); if ($sub_state eq 'updates') { push @arr, 'update'; } } elsif ($state eq 'updates') { unshift @arr, 'upgrade_distro' if $new_distro; - $bubble->add_action('clicked', N("Install updates"), \&installUpdates); + $bubble->add_action('updates', N("Install updates"), sub { installUpdates(); Gtk3->main_quit }); + $bubble->signal_connect('closed' => \&Gtk3::main_quit); } elsif (member($state, qw(no_enabled_medium no_update_medium))) { - $bubble->add_action('clicked', N("Add media"), \&add_media); + $bubble->add_action('add_med', N("Add media"), sub { add_media(); Gtk3->main_quit }); + $bubble->signal_connect('closed' => \&Gtk3::main_quit); } $bubble->set_urgency($state{$state}{urgency}) if $state{$state}{urgency}; $bubble->set_timeout(5000); - eval { $bubble->show }; + eval { $bubble->show; Gtk3->main }; } my $menu = Gtk3::Menu->new; -- cgit v1.2.1 From 909b358594c5e318dbdd2618462d933cf070f632 Mon Sep 17 00:00:00 2001 From: Thierry Vignaud Date: Sat, 21 Dec 2013 03:18:52 +0100 Subject: do not ignore exceptions: display them at least... --- mgaapplet | 1 + 1 file changed, 1 insertion(+) (limited to 'mgaapplet') diff --git a/mgaapplet b/mgaapplet index ad66294d..eb291bd0 100755 --- a/mgaapplet +++ b/mgaapplet @@ -692,6 +692,7 @@ sub setState { $bubble->set_urgency($state{$state}{urgency}) if $state{$state}{urgency}; $bubble->set_timeout(5000); eval { $bubble->show; Gtk3->main }; + warn ">> ERR:$@" if $@; } my $menu = Gtk3::Menu->new; -- cgit v1.2.1 From bb3d7a0b3f5843a5f3d9455858f2e96975ca95f3 Mon Sep 17 00:00:00 2001 From: Thierry Vignaud Date: Sat, 21 Dec 2013 14:03:22 +0100 Subject: fix typo in previous commits (spot by Colin) --- mgaapplet | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'mgaapplet') diff --git a/mgaapplet b/mgaapplet index eb291bd0..2af525ff 100755 --- a/mgaapplet +++ b/mgaapplet @@ -669,7 +669,7 @@ sub setState { my $bubble = Gtk3::Notify::Notification->new(N("Warning"), formatAlaTeX(translate($state{$state}{tt}[0])) . "\n", '/usr/share/icons/mgaonline.png'); if ($state eq 'new_distribution') { - $bubble->add_action('upgrade', N("More Information2"), sub { upgrade(); Gtk3->main_quit }); + $bubble->add_action('upgrade', N("More Information"), sub { upgrade(); Gtk3->main_quit }); $bubble->signal_connect('closed' => \&Gtk3::main_quit); if ($sub_state eq 'updates') { push @arr, 'update'; -- cgit v1.2.1