| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
This was causing the /etc/resolv.conf file to be always updated when
RESOLV_MODS was not set...
Before the commit 5d6156454bf8f6dab4a5fdd7e1bf6 we were not updating
the /etc/resolv.conf file if the RESOLV_MODS was empty.
See https://bugzilla.redhat.com/show_bug.cgi?id=1610411 for more info.
|
|
|
|
|
|
|
|
|
|
| |
Previously, there were 2 additional conditions related to this part of
code, but they were removed in time, so this last condition has
remained an artifact and is de-facto obsolete.
However, the 'pidof -x dhclient' condition could cause the network
service to hang on stop/restart when processes were executed from a
network share... Removing that condition should hypothetically fix it.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For currently unknown reason the dbus-send calls will fail to set the
firewall zone for the given interface if we omit the --print-reply
option...
This looks like some kind of race-condition in dbus-send, since the
--print-reply makes the call synchronous and slower.
Hopefully this is only a temporary workaround until DBus is fixed.
Resolves: #1586284
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
network-functions uses awk to tranform the mac address to upper case.
Replace awk with tr which is two order of magnitude faster:
$ time awk '{ print toupper($0) }' </usr/share/dict/words >/dev/null
real 0m0,227s
user 0m0,224s
sys 0m0,004s
$ time tr '[a-z]' '[A-Z]' </usr/share/dict/words >/dev/null
real 0m0,005s
user 0m0,000s
sys 0m0,005s
Also use here-strings instead of spawning a subshell and a pipe.
Signed-off-by: Matteo Croce <mcroce@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of displaying messages without context, like this:
./network-functions: line 571: echo: write error: Invalid argument
./network-functions: line 598: echo: write error: Permission denied
We will now display pretty error messages (via net_log) about what has
actually failed...
This has been requested by our customer:
https://bugzilla.redhat.com/show_bug.cgi?id=1542514
|
|
|
|
|
|
|
| |
Empty ${RESOLV_MODS} was causing a deletion of config files in
/etc/ppp/peers/*
Resolves: #155
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is complete rework of how we generate the /etc/resolv.conf.
Fixes:
* always update 'nameserver' & 'search' entries when DNS* & DOMAIN
options (respectively) were updated in ifcfg-* files
* always update the order of 'nameserver' entries when the order of
DNS* options was updated
Enhancements:
* added support for DNS3 option (equals to MAXNS value in GLIBC)
* added logic to process duplicate DNS* options
* added logic to process randomly omitted DNS* options (e.g. omitting
DNS1 while specifying DNS2 and/or DNS3 will still work now)
This work was based on these two RHEL-7.5 BZs:
https://bugzilla.redhat.com/show_bug.cgi?id=1364895
https://bugzilla.redhat.com/show_bug.cgi?id=1357658
|
|
|
|
|
| |
Otherwise obtaining IP from DHCP might fail. Based on patch from:
* Rich Alloway <richard.alloway@roguewave.com> | CentOS BZ #0011138
|
|
|
|
|
|
|
|
|
|
| |
And network-scripts/network-functions was patched to use convert2sec().
This function can be used to convert the value of its first parameter
to a number of seconds - based on the time unit (specified as the
second parameter).
This is mostly useful for converting values for use with the sleep(1).
|
|
|
|
|
| |
The time units had to be manually converted from microseconds to
seconds. Hopefully this was done right.
|
| |
|
|
|
|
|
| |
To speed things up. Based on patch & comments from:
https://bugzilla.redhat.com/show_bug.cgi?id=1497759
|
|
|
|
|
|
|
|
|
| |
The ARPUPDATE option has been introduced. It defaults to 'yes'.
By setting the ARPUPDATE to 'no', administrator can disable
updating neighbouring computers with ARP information about current
NIC. This is especially needed when using LVS Load Balancing with
Direct routing enabled.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The way DHCP_HOSTNAME is being sent to DHCP server has been completely
reworked...
DHCP_FQDN now allows user to specify fully qualified domain name to be
sent to DHCP server instead of just using simple hostname. This option
takes precedence before DHCP_HOSTNAME variable.
DHCP_SEND_HOSTNAME can be used to tell initscripts to not send either
DHCP_HOSTNAME or DHCP_FQDN to DHCP server.
Both of these options should behave same as they do in NetworkManager.
|
| |
|
| |
|
|
|
|
| |
... but it is stuck some time
|
|
|
|
|
| |
With quote marks all the parameters to dhclient are passed as one
Resolves: #1410429
|
|
|
|
|
| |
This commit contains a lot of whitespace changes.
Use 'git diff --ignore-all-space' to display the relevant changes.
|
|
|
|
| |
This commit contains only whitespace & indentation style changes.
|
|
|
|
|
| |
Use dbus to refresh configuration files for NetworkManager in order
to make ifup and ifdown faster.
|
|
|
|
| |
Use dbus instead of nmcli to make ifup command faster.
|
|
|
|
|
| |
Cherry-picked from: 1087a2776ab6d27c65233918db7cffecd326dec0
Resolves: #1240775
|
|
|
|
| |
Resolves: #1336869
|
|
|
|
|
| |
Cherry-picked from: c188044
Resolves: #1245951
|
|
|
|
|
| |
Cherry-picked from: 61fb1cb
Resolves: #1345919
|
|
|
|
|
| |
Cherry-picked from: c93ddceaa09d59be56b2b5dd64ab38febb5fafb2
Resolves: #1273286
|
|
|
|
|
| |
Cherry-picked from: 9a55596dbdc402348e56c3f519e6218e8708a5e2
Resolves: #1257544
|
|
|
|
|
| |
Cherry-picked from: 1a4607f
Resolves: #1240775
|
|
|
|
|
| |
Cherry-picked from: da08727f3bbcc419096b160968aee83104bb7cf6
Resolves: #1316019
|
|
|
|
|
| |
Cherry-picked from: 3d1f30095582f84206826f7ede970c45e5a6b5ba
Resolves: #1273435
|
|
|
|
|
|
|
| |
is_available returns 2
Cherry-picked from: 1f230a3d2e2733e30577c91645005801ab2c0f40
Resolves: #1339648
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1162822
When ifup is called on an interface that has BOOTPROTO=dhcp, ifup-eth
will call network-functions:check_link_down() to wait for carrier on
the interface before starting dhclient. If the interface happens to be
a bridge device, carrier will not come on until at least one attached
device is in "forwarding" mode. If the bridge has STP enabled, it
takes at least $DELAY * 2 + 5 seconds (sometimes slightly longer) for
any attached device to go into forwarding mode.
However, check_link_down() will only wait for max(${LINKDELAY}, 5)
seconds for carrier, and there are *many* existing configs that have
STP enabled but no setting for LINKDELAY. Every one of those configs
will now fail to ifup the bridge device.
The solution implemented in this patch is for ifup-eth to set
LINKDELAY to at least ${DELAY} * 2 + 7 when the device is a bridge an
STP is enabled. Since check_link_down() returns within .5 sec of
carrier coming up, the worst effect this could have would be to take
longer to fail in the case of a config where carrier was *never* going
to come up. Otherwise, it will not create any more delay than is
already present in cases that currently work, and will cause many
other configs to become unbroken.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
| |
kudos to john.haxby@oracle.com
Conflicts:
sysconfig/network-scripts/network-functions
|