From 70e92f4e81a2f48c875a7d5ffa1e374ab10ac41a Mon Sep 17 00:00:00 2001 From: Thierry Vignaud Date: Thu, 30 Apr 2015 10:23:53 -0400 Subject: do not run shells uselessly also prevent arguments to be split on spaces & the like --- rescue/NEWS | 2 ++ rescue/bin/guessmounts | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) (limited to 'rescue') diff --git a/rescue/NEWS b/rescue/NEWS index 9a15c388d..99beaff86 100644 --- a/rescue/NEWS +++ b/rescue/NEWS @@ -1,3 +1,5 @@ +- do not run shells uselessly + Version 1.53 - 28 September 2015 by Thierry Vignaud - fix build with libified perl diff --git a/rescue/bin/guessmounts b/rescue/bin/guessmounts index 13ec2802e..07cd62ba3 100755 --- a/rescue/bin/guessmounts +++ b/rescue/bin/guessmounts @@ -135,9 +135,9 @@ if ($root) { my $dev = fs::wild_device::from_part('', $_); mkdir_p($where); print STDERR "\t$dev on $where type $_->{fs_type} options $_->{options}\n"; - system("mount -t $_->{fs_type} $dev $where -o $_->{options}"); + system('mount', '-t', $_->{fs_type}, $dev, $where, '-o', $_->{options}); } - system("mount -t proc proc $target/proc"); + system(qw(mount -t proc proc), "$target/proc"); foreach (qw(/dev /run /sys)) { system('mount', '--bind', $_, "$target/$_"); } -- cgit v1.2.1