From 4a89c725392fcb49befc0a60d251d75d9962b6b5 Mon Sep 17 00:00:00 2001 From: Pascal Rigaux Date: Wed, 19 Sep 2007 14:15:53 +0000 Subject: restore banner on pop up messages (#33753) the tricky part here is we need to differentiate the case when the empty box given in ugtk2.pm was really meant to be discarded (eg: diskdrake during install), but don't want to discard the child if it's useful (wait_message) --- perl-install/mygtk2.pm | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) (limited to 'perl-install/mygtk2.pm') diff --git a/perl-install/mygtk2.pm b/perl-install/mygtk2.pm index 2278a8b93..2d6ea61f9 100644 --- a/perl-install/mygtk2.pm +++ b/perl-install/mygtk2.pm @@ -585,11 +585,16 @@ sub _gtk__MagicWindow { any { !$_->isa('Gtk2::DrawingArea') && $_->visible } $::WizardTable->get_children; }; - my $sub_child = delete $opts->{child} or internal_error("missing child"); + my $sub_child = delete $opts->{child}; my $provided_banner = delete $opts->{banner}; + if ($pop_it && $provided_banner) { + $sub_child = gtknew('VBox', children => [ 0, $provided_banner, if_($sub_child, 1, $sub_child) ]); + } else { + $sub_child ||= gtknew('VBox'); + } + if ($pop_it) { - $sub_child ||= gtknew('VBox', children_tight => [ $provided_banner ]) if $provided_banner; $opts->{child} = $::isInstall ? gtknew('Frame', shadow_type => 'out', child => gtknew('Frame', shadow_type => 'none', border_width => 3, child => $sub_child)) : -- cgit v1.2.1