From c52383f56f1cdf26b8acd2b89a296cc8d5e44966 Mon Sep 17 00:00:00 2001 From: Colin Guthrie Date: Thu, 14 Feb 2013 14:50:43 +0000 Subject: (call_blkid) add a code comment about blkid -p to prevent accidental revert in the future --- perl-install/fs/type.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/perl-install/fs/type.pm b/perl-install/fs/type.pm index 528804655..174cbe222 100644 --- a/perl-install/fs/type.pm +++ b/perl-install/fs/type.pm @@ -271,6 +271,7 @@ sub fs_type_from_magic { sub call_blkid { my ($part) = @_; + # IMPORTANT: Always use the -p argument with blkid. See r7324 commit msg my %h = map { if_(/(.*?)=(.*)/, $1 => $2); } run_program::get_stdout_raw({ timeout => 30 }, 'blkid', '2>', '/dev/null', '-o', 'udev', '-p', devices::make($part->{device})); -- cgit v1.2.1