summaryrefslogtreecommitdiffstats
path: root/perl-install/standalone/interactive_http/interactive_http.cgi
diff options
context:
space:
mode:
authorThierry Vignaud <tv@mageia.org>2012-03-23 19:50:35 +0000
committerThierry Vignaud <tv@mageia.org>2012-03-23 19:50:35 +0000
commitf4bc86bc94aeeeffb8a82b16b38b760590b80bdf (patch)
treeb5a904657487cd5dfec16ca195ee72b9098a086f /perl-install/standalone/interactive_http/interactive_http.cgi
parentcb09d79bc963f95780d214aa12e695d8f9e338e2 (diff)
downloaddrakx-f4bc86bc94aeeeffb8a82b16b38b760590b80bdf.tar
drakx-f4bc86bc94aeeeffb8a82b16b38b760590b80bdf.tar.gz
drakx-f4bc86bc94aeeeffb8a82b16b38b760590b80bdf.tar.bz2
drakx-f4bc86bc94aeeeffb8a82b16b38b760590b80bdf.tar.xz
drakx-f4bc86bc94aeeeffb8a82b16b38b760590b80bdf.zip
perl_checker cleanups
Diffstat (limited to 'perl-install/standalone/interactive_http/interactive_http.cgi')
-rwxr-xr-xperl-install/standalone/interactive_http/interactive_http.cgi23
1 files changed, 11 insertions, 12 deletions
diff --git a/perl-install/standalone/interactive_http/interactive_http.cgi b/perl-install/standalone/interactive_http/interactive_http.cgi
index 4da796719..24899c451 100755
--- a/perl-install/standalone/interactive_http/interactive_http.cgi
+++ b/perl-install/standalone/interactive_http/interactive_http.cgi
@@ -8,7 +8,7 @@ use c;
my $q = CGI->new;
$| = 1;
-my $script_name = $q->url(-relative => 1);
+my $script_name = $q->url('-relative' => 1);
# name inversed (must be in sync with interactive_http.html)
my $pipe_r = "/tmp/interactive_http_w";
@@ -27,24 +27,23 @@ if ($q->param('state') eq 'new') {
error("booh...");
}
-sub read_ {
- local *F;
- open F, "<$pipe_r" or error("Failed to connect to the prog");
+sub read_() {
+ open my $F, "<$pipe_r" or error("Failed to connect to the prog");
my $t;
- print $t while sysread F, $t, 1;
+ print $t while sysread $F, $t, 1;
}
-sub write_ {
+sub write_() {
local *F;
open F, ">$pipe_w" or die;
my $q = CGI->new;
$q->save(\*F);
}
-sub first_step { read_() }
-sub next_step { write_(); read_() }
+sub first_step() { read_() }
+sub next_step() { write_(); read_() }
-sub force_exit_dead_prog {
+sub force_exit_dead_prog() {
-p $pipe_w or return;
{
local *F;
@@ -65,7 +64,7 @@ sub spawn_server {
my @authorised_progs = map { chomp_($_) } cat_('/etc/drakxtools_http/authorised_progs');
member($prog, @authorised_progs) or error("You tried to call a non-authorised program");
- fork and return;
+ fork() and return;
$ENV{INTERACTIVE_HTTP} = $script_name;
@@ -78,9 +77,9 @@ sub spawn_server {
}
sub error {
- print $q->header(), $q->start_html();
+ print $q->header, $q->start_html;
print $q->h1(N("Error")), @_;
- print $q->end_html(), "\n";
+ print $q->end_html, "\n";
exit 0;
}